Re: [PATCH] D21676: clang-rename: add a -s (suffix) option

vmiklos updated this revision to Diff 61833. vmiklos added a comment. This version solves the problem outline in the commit message by implementing an -export-fixes commandline option, quite similar to clang-tidy's matching option. http://reviews.llvm.org/D21676 Files:

[PATCH] D21676: clang-rename: add a -s (suffix) option

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Use case: a class is declared in a header, and defined in two translation units. clang-rename is asked to rename a class member that's referenced in both translation units. Using -i is not

Re: [clang-tools-extra] r273304 - clang-rename: add a -old-name option

Hi Galina, On Tue, Jun 21, 2016 at 06:17:52PM -0700, Galina Kistanova wrote: > This revision broke one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7435 Yes, sorry. Should be fixed by r273314. Regards, Miklos

[clang-tools-extra] r273314 - Fix build of ClangRenameTests

Author: vmiklos Date: Tue Jun 21 15:30:40 2016 New Revision: 273314 URL: http://llvm.org/viewvc/llvm-project?rev=273314=rev Log: Fix build of ClangRenameTests Adapt the test to the code change introduced in r273304. Modified:

[clang-tools-extra] r273304 - clang-rename: add a -old-name option

Author: vmiklos Date: Tue Jun 21 14:48:57 2016 New Revision: 273304 URL: http://llvm.org/viewvc/llvm-project?rev=273304=rev Log: clang-rename: add a -old-name option This is similar to -offset with the following differences: 1) -offset can refer to local variables as well. 2) -old-name makes

Re: [PATCH] D21517: clang-rename: add a -old-name option

vmiklos updated this revision to Diff 61255. vmiklos added a comment. Added a getNamedDeclFor() for the fully qualified name-based search. http://reviews.llvm.org/D21517 Files: clang-rename/USRFinder.cpp clang-rename/USRFinder.h clang-rename/USRFindingAction.cpp

[PATCH] D21517: clang-rename: add a -old-name option

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This is similar to -offset with the following differences: 1) -offset can refer to local variables as well. 2) -old-name makes it easier to refer to e.g. ClassName::MemberName by

[clang-tools-extra] r272816 - clang-rename: implement renaming of classes with a dtor

Author: vmiklos Date: Wed Jun 15 13:35:41 2016 New Revision: 272816 URL: http://llvm.org/viewvc/llvm-project?rev=272816=rev Log: clang-rename: implement renaming of classes with a dtor The declaration wasn't renamed. Also neither part of the declaration wasn't renamed. Reviewers: klimek

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

This revision was automatically updated to reflect the committed changes. Closed by commit rL272816: clang-rename: implement renaming of classes with a dtor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21364?vs=60801=60869#toc Repository: rL LLVM

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60801. vmiklos added a comment. Now the correct patch. :-) http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60800. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp === --- /dev/null +++

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60799. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos added a comment. Thanks, sounds like exactly what I need. http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Work in progress, not complete yet. Current result: clang-rename -offset 135 -new-name=Bar DtorDefTest.cpp -- - handles "Foo" from "Foo::~Foo" correctly - handles "~Foo" from

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL272574: clang-rename: implement handling of remaining named casts (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21270?vs=60479=60572#toc Repository: rL LLVM

[clang-tools-extra] r272574 - clang-rename: implement handling of remaining named casts

Author: vmiklos Date: Mon Jun 13 13:50:45 2016 New Revision: 272574 URL: http://llvm.org/viewvc/llvm-project?rev=272574=rev Log: clang-rename: implement handling of remaining named casts const_cast<> and reinterpret_cast<>. Reviewers: klimek Differential Revision:

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos added a comment. Yes, if there will be a way to avoid hooking into each and every AST callback, that sounds more effective. :-) I'm aware of one more bug around destructors when renaming a class, but then I'm (as a user) quite happy about the current state.

[PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. const_cast<> and reinterpret_cast<>. http://reviews.llvm.org/D21270 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstCastExpr.cpp test/clang-rename/ReinterpretCastExpr.cpp

[clang-tools-extra] r272381 - clang-rename: fix the DynamicCastExpr test on ps4

Author: vmiklos Date: Fri Jun 10 03:29:02 2016 New Revision: 272381 URL: http://llvm.org/viewvc/llvm-project?rev=272381=rev Log: clang-rename: fix the DynamicCastExpr test on ps4 It has RTTI disabled by default, so need to enable it explicitly. Reviewers: silvas Differential Revision:

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

This revision was automatically updated to reflect the committed changes. Closed by commit rL272381: clang-rename: fix the DynamicCastExpr test on ps4 (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21186?vs=60324=60326#toc Repository: rL LLVM

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

vmiklos updated this revision to Diff 60324. vmiklos added a comment. Correct diff this time. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index: test/clang-rename/DynamicCastExpr.cpp === ---

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

vmiklos retitled this revision from "clang-rename: mark the DynamicCastExpr test unsupported on ps4" to "clang-rename: fix the DynamicCastExpr test on ps4". vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60320. vmiklos added a comment. Ah, then the fix is

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Galina, On Thu, Jun 09, 2016 at 10:15:27AM -0700, Galina Kistanova wrote: > This revision broke tests on one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please accept if it's

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Possible solution posted as http://reviews.llvm.org/D21186. Repository: rL LLVM http://reviews.llvm.org/D21120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. It has no RTTI, so the test would always fail in a non-interesting way. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index:

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Hmm, http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332/steps/test/logs/stdio fails with "error: cannot use dynamic_cast with -fno-rtti"; is there some way to detect if "-fno-rtti" is the default, and in that case don't execute

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL272188: clang-rename: implement renaming of classes inside dynamic_cast (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21120?vs=60001=60073#toc Repository: rL LLVM

[clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Author: vmiklos Date: Wed Jun 8 13:38:23 2016 New Revision: 272188 URL: http://llvm.org/viewvc/llvm-project?rev=272188=rev Log: clang-rename: implement renaming of classes inside dynamic_cast Refactor to do the same as what is done already for static_cast. Reviewers: klimek Differential

[PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Refactor to do the same as what is done already for static_cast. http://reviews.llvm.org/D21120 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DynamicCastExpr.cpp Index:

Re: [PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL271933: clang-rename: implement renaming of classes inside static_cast (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21012?vs=59695=59766#toc Repository: rL LLVM

[clang-tools-extra] r271933 - clang-rename: implement renaming of classes inside static_cast

Author: vmiklos Date: Mon Jun 6 14:40:12 2016 New Revision: 271933 URL: http://llvm.org/viewvc/llvm-project?rev=271933=rev Log: clang-rename: implement renaming of classes inside static_cast "Derived" in static_cast(...) wasn't renamed, nor in its pointer equivalent. Reviewers:

Re: [PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

vmiklos updated this revision to Diff 59695. vmiklos added a comment. Done. http://reviews.llvm.org/D21012 Files: clang-rename/USRLocFinder.cpp test/clang-rename/StaticCastExpr.cpp Index: test/clang-rename/StaticCastExpr.cpp

[PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. "Derived" in static_cast(...) wasn't renamed, nor in its pointer equivalent. http://reviews.llvm.org/D21012 Files: clang-rename/USRLocFinder.cpp

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

This revision was automatically updated to reflect the committed changes. Closed by commit rL271572: clang-rename: fix renaming heap allocations (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20635?vs=58467=59447#toc Repository: rL LLVM

[clang-tools-extra] r271572 - clang-rename: fix renaming heap allocations

Author: vmiklos Date: Thu Jun 2 15:00:22 2016 New Revision: 271572 URL: http://llvm.org/viewvc/llvm-project?rev=271572=rev Log: clang-rename: fix renaming heap allocations The check failed, 'Cla *C = new Cla();' was renamed to 'D *C = new Cla();'. Reviewers: klimek Differential Revision:

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos added a comment. Can I help anything with reviewing this, please? http://reviews.llvm.org/D20635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. The check failed, 'Cla *C = new Cla();' was renamed 'D *C = new Cla();'. http://reviews.llvm.org/D20635 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstructExpr.cpp Index:

Re: [PATCH] D20537: clang-rename: fix renaming non-members variables when referenced as macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL270599: clang-rename: fix renaming non-members variables when referenced as macro… (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20537?vs=58136=58290#toc Repository: rL

[clang-tools-extra] r270599 - clang-rename: fix renaming non-members variables when referenced as macro arguments

Author: vmiklos Date: Tue May 24 14:08:53 2016 New Revision: 270599 URL: http://llvm.org/viewvc/llvm-project?rev=270599=rev Log: clang-rename: fix renaming non-members variables when referenced as macro arguments The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y). Reviewers: klimek

[PATCH] D20537: clang-rename: fix renaming non-members variables when referenced as macro arguments

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y). http://reviews.llvm.org/D20537 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DeclRefExpr.cpp Index: test/clang-rename/DeclRefExpr.cpp

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL270204: clang-rename: fix renaming members when referenced as macro arguments (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20446?vs=57921=57923#toc Repository: rL LLVM

[clang-tools-extra] r270204 - clang-rename: fix renaming members when referenced as macro arguments

Author: vmiklos Date: Fri May 20 06:43:59 2016 New Revision: 270204 URL: http://llvm.org/viewvc/llvm-project?rev=270204=rev Log: clang-rename: fix renaming members when referenced as macro arguments The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). Reviewers: klimek Differential

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

vmiklos updated this revision to Diff 57921. vmiklos added a comment. Done. http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp

[PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp

[clang-tools-extra] r269952 - clang-rename: handle non-inline ctor definitions when renaming classes

Author: vmiklos Date: Wed May 18 11:12:48 2016 New Revision: 269952 URL: http://llvm.org/viewvc/llvm-project?rev=269952=rev Log: clang-rename: handle non-inline ctor definitions when renaming classes The result of the test was C::D(), not D::D(). Reviewers: cfe-commits, klimek Differential

Re: [PATCH] D20356: clang-rename: handle non-inline ctor definitions when renaming classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL269952: clang-rename: handle non-inline ctor definitions when renaming classes (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20356?vs=57582=57641#toc Repository: rL LLVM

[PATCH] D20356: clang-rename: handle non-inline ctor definitions when renaming classes

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The result of the test was C::D(), not D::D(). http://reviews.llvm.org/D20356 Files: clang-rename/USRLocFinder.cpp test/clang-rename/CtorDefTest.cpp Index: test/clang-rename/CtorDefTest.cpp

Re: [PATCH] D20296: clang-rename: avoid StringRef members in USRLocFindingASTVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL269796: clang-rename: avoid StringRef members in USRLocFindingASTVisitor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20296?vs=57385=57503#toc Repository: rL LLVM

[clang-tools-extra] r269796 - clang-rename: avoid StringRef members in USRLocFindingASTVisitor

Author: vmiklos Date: Tue May 17 13:17:16 2016 New Revision: 269796 URL: http://llvm.org/viewvc/llvm-project?rev=269796=rev Log: clang-rename: avoid StringRef members in USRLocFindingASTVisitor Even if this is defined in the .cpp file and only used as part of the function (so here it's safe),

[PATCH] D20296: clang-rename: avoid StringRef members in USRLocFindingASTVisitor

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. Even if this is defined in the .cpp file and only used as part of the function (so here it's safe), usually storing StringRefs in the class is dangerous, so don't do so. http://reviews.llvm.org/D20296 Files:

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Thanks for fixing the problem I introduced. :-) http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos abandoned this revision. vmiklos added a comment. Ah, already fixed by http://reviews.llvm.org/D20240, sorry for the noise. :-) http://reviews.llvm.org/D20253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. Blind fix for . http://reviews.llvm.org/D20253 Files: clang-rename/CMakeLists.txt Index: clang-rename/CMakeLists.txt

[clang-tools-extra] r269402 - clang-rename: check that the source location we find actually has the old name

Author: vmiklos Date: Fri May 13 04:17:32 2016 New Revision: 269402 URL: http://llvm.org/viewvc/llvm-project?rev=269402=rev Log: clang-rename: check that the source location we find actually has the old name This more general check could have prevented the specific problem "getSourceOrder() ==

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

This revision was automatically updated to reflect the committed changes. Closed by commit rL269402: clang-rename: check that the source location we find actually has the old name (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20216?vs=57140=57144#toc Repository:

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

vmiklos updated this revision to Diff 57140. vmiklos added a comment. Got rid of startswith() and now using StringRef everywhere instead of a mix of std::string, const std::string and const std::string&. http://reviews.llvm.org/D20216 Files: clang-rename/RenamingAction.cpp

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

vmiklos added inline comments. Comment at: clang-rename/USRLocFinder.cpp:75 @@ +74,3 @@ + StringRef TokenName = Lexer::getSourceText(CharSourceRange::getTokenRange(Range), Context.getSourceManager(), Context.getLangOpts()); + if

[PATCH] D20216: clang-rename: check that the source location we find actually has the old name

vmiklos created this revision. vmiklos added subscribers: cfe-commits, klimek. This more general check could have prevented the specific problem "getSourceOrder() == -1" guards. http://reviews.llvm.org/D20216 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos added a comment. Hi, > Also: should we add a check that the token of the source location we find > actually has the old name? Hmm, how do I get the token at a specific SourceLocation? The best I found so far is SourceManager::getBuffer(), but that looks more like looking up raw

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos added inline comments. Comment at: clang-rename/USRLocFinder.cpp:64 @@ +63,3 @@ + if (Initializer->getSourceOrder() == -1) { +// Ignore implicit initializers. +continue; klimek wrote: > Add a comment like: > // The source location of

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL269161: clang-rename: fix renaming of field with implicit initializers (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20150?vs=56854=56859#toc Repository: rL LLVM

[clang-tools-extra] r269161 - clang-rename: fix renaming of field with implicit initializers

Author: vmiklos Date: Wed May 11 03:08:07 2016 New Revision: 269161 URL: http://llvm.org/viewvc/llvm-project?rev=269161=rev Log: clang-rename: fix renaming of field with implicit initializers The last check failed as Cla::Cla() was rewritten to Cla::hector(). Reviewers: cfe-commits, klimek

[PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The last check failed as Cla::Cla() was rewritten to Cla::hector(). http://reviews.llvm.org/D20150 Files: clang-rename/USRLocFinder.cpp test/clang-rename/CtorInitializerTest.cpp Index:

Re: [PATCH] D20059: clang-rename tests: move the run lines to the top of the test files

This revision was automatically updated to reflect the committed changes. Closed by commit rL268897: clang-rename tests: move the run lines to the top of the test files (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20059?vs=56537=56538#toc Repository: rL LLVM

[clang-tools-extra] r268897 - clang-rename tests: move the run lines to the top of the test files

Author: vmiklos Date: Mon May 9 03:47:18 2016 New Revision: 268897 URL: http://llvm.org/viewvc/llvm-project?rev=268897=rev Log: clang-rename tests: move the run lines to the top of the test files Summary: To be consistent with the other tests. Reviewers: cfe-commits, klimek Differential

[PATCH] D20059: clang-rename tests: move the run lines to the top of the test files

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. To be consistent with the other tests. http://reviews.llvm.org/D20059 Files: test/clang-rename/ClassTest.cpp test/clang-rename/FieldTest.cpp test/clang-rename/VarTest.cpp Index: test/clang-rename/VarTest.cpp

Re: [PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL268857: clang-rename: when renaming a field, rename initializers of that field as well (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D19957?vs=56241=56497#toc Repository:

[clang-tools-extra] r268857 - clang-rename: when renaming a field, rename initializers of that field as well

Author: vmiklos Date: Sat May 7 09:32:59 2016 New Revision: 268857 URL: http://llvm.org/viewvc/llvm-project?rev=268857=rev Log: clang-rename: when renaming a field, rename initializers of that field as well Summary: The second check failed, the initializer wasn't renamed. Reviewers:

Re: [PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

vmiklos added a comment. Not really, I just copied VarTest.cpp. I'll put it to top for new tests. Repository: rL LLVM http://reviews.llvm.org/D19957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second check failed, the initializer wasn't renamed. http://reviews.llvm.org/D19957 Files: clang-rename/USRLocFinder.cpp test/clang-rename/FieldTest.cpp Index: test/clang-rename/FieldTest.cpp

Re: [PATCH] D19905: clang-rename: when renaming a class, rename pointers to that class as well

vmiklos added a comment. Yes, please submit it; I'm not a committer. http://reviews.llvm.org/D19905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19905: clang-rename: when renaming a class, rename pointers to that class as well

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second "CHECK:" failed in the testcase without the code change. http://reviews.llvm.org/D19905 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ClassTest.cpp Index: test/clang-rename/ClassTest.cpp

Re: [PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos added a comment. Thanks! Is there anything I have to do to get this actually committed or I just have to be patient? http://reviews.llvm.org/D18957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos added a comment. Hi, Can I help anything to get this reviewed, please? Thanks, Miklos http://reviews.llvm.org/D18957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This makes it easier for external tools to parse lines starting with clang-rename, as 'renamed at:' lines already end with a newline. http://reviews.llvm.org/D18957 Files:

<    1   2