r373039 - Revert r373034

Author: comex Date: Thu Sep 26 18:58:31 2019 New Revision: 373039 URL: http://llvm.org/viewvc/llvm-project?rev=373039=rev Log: Revert r373034 It breaks the build on MSVC. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/lib/Analysis/Consumed.cpp Modified:

r373034 - [Consumed][NFC] Refactor handleCall to take function argument list.

Author: comex Date: Thu Sep 26 16:47:18 2019 New Revision: 373034 URL: http://llvm.org/viewvc/llvm-project?rev=373034=rev Log: [Consumed][NFC] Refactor handleCall to take function argument list. Differential Revision: https://reviews.llvm.org/D67569 Modified:

r372361 - [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

Author: comex Date: Thu Sep 19 16:00:31 2019 New Revision: 372361 URL: http://llvm.org/viewvc/llvm-project?rev=372361=rev Log: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs. Differential Revision: https://reviews.llvm.org/D67743 Modified:

r372058 - Push lambda scope earlier when transforming lambda expression

Author: comex Date: Mon Sep 16 18:43:33 2019 New Revision: 372058 URL: http://llvm.org/viewvc/llvm-project?rev=372058=rev Log: Push lambda scope earlier when transforming lambda expression Differential Revision: https://reviews.llvm.org/D66067 Modified: cfe/trunk/lib/Sema/TreeTransform.h

Re: [PATCH] D15907: Allow various function attributes to be specified on Objective-C blocks too.

comex added reviewers: aaron.ballman, rsmith. comex added a comment. Ping, and adding potential reviewers like I was supposed to do in the first place. http://reviews.llvm.org/D15907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15907: Allow various function attributes to be specified on Objective-C blocks too.

comex created this revision. comex added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This mostly "just works" by adding Block to the subject list, but there is an issue with warnings in attribute handlers tied to the return type, which for blocks can be inferred. My solution

[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

comex created this revision. comex added a subscriber: cfe-commits. When a function parameter is declared `__attribute__((cleanup))`, neither Clang nor GCC actually executes the cleanup function, but Clang didn't warn about it. For the sake of compatibility, add a warning rather than making

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex updated this revision to Diff 39838. comex marked 16 inline comments as done. http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. Addressed comments. Thanks, rsmith! Comment at: lib/Sema/SemaType.cpp:3756-3760 @@ -3743,2 +3755,7 @@ } +} else if (D.getDeclSpec().getTypeSpecType() == DeclSpec::TST_auto_type) { +

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. (Ping? I verified yesterday that the patch still applies and passes regression tests.) http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. One more ping. As far as I know, everything has been addressed. http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: lib/Sema/SemaType.cpp:2654-2655 @@ -2648,4 +2653,4 @@ case Declarator::ConversionIdContext: if (!SemaRef.getLangOpts().CPlusPlus14) -Error = 12; // conversion-type-id +Error = 14; // conversion-type-id

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: lib/Sema/SemaType.cpp:2675-2678 @@ -2671,5 +2674,6 @@ break; case Declarator::ConversionIdContext: - if (!SemaRef.getLangOpts().CPlusPlus14) -Error = 12; // conversion-type-id + if

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14 @@ +13,3 @@ + auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed in lambda parameter}} + __auto_type g = 2; + struct BitField { int field:2; }; thakis

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. Ping again. http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex updated the summary for this revision. comex updated this revision to Diff 37202. comex marked 3 inline comments as done. comex added a comment. Fixed raised issues. (I don't have commit rights.) http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex marked 5 inline comments as done. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726 @@ -1720,1 +1725,3 @@ +def err_auto_bitfield : Error< + "cannot pass bit-field as __auto_type initializer in C">; rsmith wrote: > pass -> use > > Also, why

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex updated this revision to Diff 37215. comex added a comment. Okay. http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex created this revision. comex added a subscriber: cfe-commits. Herald added subscribers: aemerson, klimek. Add support for GCC's '__auto_type' extension. As per the GCC manual: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html Implemented in GCC 4.9, __auto_type is similar to C++11 auto but