[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

nik added a comment. @jkorous: Please submit. I can't as my svn account is still not ported to github... :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

nik added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42649 to this change. Reverting this change fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53191: [clang] Introduce new completion context types

nik added a comment. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42646 to this change. Reverting it fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53191/new/

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

nik added a comment. In D63482#1567897 , @yvvan wrote: > I have a commit access but I don't understand how am I supposed to commit > (haven't done that for a while). There's no clang svn repo anymore. Do you > know what's the current state of

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

nik added a comment. In D63482#1567927 , @nik wrote: > In D63482#1567897 , @yvvan wrote: > > > I have a commit access but I don't understand how am I supposed to commit > > (haven't done that for a while). There's

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

nik added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:60 + // Called by ClangdServer when some \p Highlightings for \p File are ready. + virtual void onHighlightingsReady(PathRef File, + std::vector Highlightings) = 0;

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG181f252d5373: [clang-tidy] Update documentation for Qt Creator integration. (authored by nik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63763/new/

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik added a comment. In D63763#1557398 , @gribozavr wrote: > LGTM, assuming you know what's new in QtCreator. Sure, I'm involved in Qt Creator development :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63763 Files: clang-tools-extra/docs/clang-tidy/Integrations.rst Index:

[PATCH] D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting

nik added a comment. Some general notes regarding the current state of this patch as I was testing it with a language client: - It still applies for current trunk, except for a *Tests* file. - Note that a VersionedTextDocumentIdentifier has to be used, e.g. a "version" must be included in the

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. In D63331#1543441 , @hokein wrote: > Yeah, we definitely have interest in this feature, and our intern @jvikstrom > will work on this feature this summer. "this summer" depends on the location, so can you concretize this? :) > You

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. Any interest in having the *proposal* implemented? While there is a client implementation available in the theia ide (https://github.com/theia-ide/theia/pull/2332), I have only tested this against Qt Creator's client implementation (also work in progress). Repository:

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik created this revision. nik added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar, mgorny. Herald added a project: clang. TODO: Is the visitor the right approach? TODO: Add tests TODO: Test that only highlightings

[PATCH] D63193: [clangd] Fix typo in GUARDED_BY()

This revision was automatically updated to reflect the committed changes. Closed by commit rL363139: [clangd] Fix typo in GUARDED_BY() (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63193: [clangd] Fix typo in GUARDED_BY()

nik created this revision. nik added reviewers: ilya-biryukov, kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63193 Files:

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

This revision was automatically updated to reflect the committed changes. Closed by commit rL363068: [clang-tidy] Fix invalid read on destruction (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

This revision was automatically updated to reflect the committed changes. Closed by commit rL363067: [libclang] Allow skipping warnings from all included files (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

nik created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun. Herald added a project: clang. ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==8866== Invalid read of size 4

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks Dmitri! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

nik added a comment. In D61486#1532272 , @gribozavr wrote: > Is this patch still needed? Nope, abandoning it now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61486/new/ https://reviews.llvm.org/D61486

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362702: [clang-tidy] Make the plugin honor NOLINT (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 203306. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files:

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:207 CheckNamesByDiagnosticID.try_emplace(ID, CheckName); + CustomDiagIdParamsByDiagnosticID.try_emplace( + ID, CustomDiagIdParams(Level,

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added a comment. As I've commented on, this change is not finished. However, I've addressed the inline comments nevertheless. There is one TODO left for which I would like to have an opinion. Comment at:

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Jan? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361234: [libclang] visit c++14 lambda capture init expressions (authored by nik, committed by ). Changed prior to

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. > Are you sure you have compiled this patch? If I comment out the visit of the > InitExpr in CIndex.cpp again, then I get the same failure as you... Huch, I've indeed somehow missed to compile. Sorry for that. Works fine after compilation :) LGTM. Repository: rG LLVM

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rC361226: [Preamble] Reuse preamble even if an unsaved file does not exist (authored by nik, committed by ). Changed prior to commit: https://reviews.llvm.org/D41005?vs=198809=200415#toc Repository:

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. alexfh? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Sorry for the pointless ping, haven't seen the inline comments. They are addressed now. I've also increased CINDEX_VERSION_MINOR so clients can detect availability of this new flag. > It's been a while since I've looked at the ASTUnit code, though, would be > good if

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 199015. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 Files: include/clang-c/Index.h

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik marked 4 inline comments as done. nik added inline comments. Herald added a subscriber: dexonsmith. Comment at: lib/Frontend/ASTUnit.cpp:682 + auto = D.getSourceManager(); + return M.isInMainFile(M.getExpansionLoc(D.getLocation())); +} ilya-biryukov

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik closed this revision. nik added a comment. Huch, I forgot to add "Differential Revision: " to the commit message, so I'll close this manually once I know how to add the svn revision number to this. https://llvm.org/docs/Phabricator.html states: > In the web UI, under “Leap Into Action” put

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198997. nik marked an inline comment as done and an inline comment as not done. nik added a comment. Renamed to err_pp_including_mainfile_in_preamble. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198809. nik added a comment. Addressed inline comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198799. nik added a comment. Moved the MainFile / MainContentCache->OrigEntry check a bit further up, for consistency with the same test further down in SourceManager::translateFile(). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198656. nik added a comment. Herald added a subscriber: dexonsmith. Minor diff update fixing indentation and removing not needed include. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198654. nik edited the summary of this revision. nik added a comment. Rebased for current trunk. If I miss something obvious, please tell me. Otherwise I'm waiting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. Tests do not pass on current trunk: /d2/llvm/trunk/builds/DebugShared % bin/llvm-lit -a /d2/llvm/trunk/source/tools/clang/test/Index/cxx14-lambdas.cpp llvm-lit: /d2/llvm/trunk/source/utils/lit/lit/llvm/config.py:341: note: using clang:

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 198637. nik added a comment. The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to the external diagnostic engine. @alexfh: What do you think? If that looks roughly OK for you, I'll finish it. Repository: rCTE Clang Tools Extra

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik updated this revision to Diff 198403. nik added a comment. Herald added a project: clang. Adapted c-index-test.c and added function to libclang.exports. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 Files:

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik accepted this revision. nik added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik added a comment. ...and increased CINDEX_VERSION_MINOR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks for the fast comments! In D61487#1489308 , @alexfh wrote: > I suspect that we're missing proper test coverage here. True, ideally all the test scripts would also trigger the plugin case code path. I've started with a

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik added a comment. Did you forget to push the change to c-index-test.c? Otherwise fine with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. This one depends on https://reviews.llvm.org/D61486 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The clang-tidy standalone tool implements the NOLINT filtering in ClangTidyDiagnosticConsumer::HandleDiagnostic. For the plugin case no ClangTidyDiagnosticConsumer is set up as it would

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

nik created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...which does not emit anything. This dummy is useful for filtering. Code expecting a DiagnosticBuilder object can get a dummy and report further details, without knowing/checking whether this is

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Ilya? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik updated this revision to Diff 187765. nik added a comment. Fixed minor typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58501/new/ https://reviews.llvm.org/D58501 Files: include/clang/Basic/Diagnostic.h lib/Basic/DiagnosticIDs.cpp

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Since commit 56f5487e4387a69708f70724d00e9e076153 [modules] Round-trip -Werror flag through explicit module build. the behavior of CXTranslationUnit_KeepGoing changed: Unresolved

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 187318. nik added a comment. Herald added a subscriber: jdoerfert. OK, filtering happens now in FilterAndStoreDiagnosticConsumer, the former StoredDiagnosticConsumer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a project: clang. >> For filtering in StoredDiagnosticConsumer one needs to pass the new bool >> everywhere along where "bool CaptureDiagnostics" is already passed on (to >> end up in the StoredDiagnosticConsumer constructor) . Also, >>

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1592 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik updated this revision to Diff 186813. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Basic/SourceManager.cpp

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked 2 inline comments as done. nik added inline comments. Herald added a subscriber: jdoerfert. Herald added a project: clang. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false;

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 186436. nik added a comment. > Meh, something changed in the meanwhile. > ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking > into it. No, it's just me ;) I've referenced the header file wrong. Repository: rC Clang CHANGES SINCE

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Meh, something changed in the meanwhile. ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 186429. nik marked an inline comment as done. nik added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Addressed comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

nik requested changes to this revision. nik added inline comments. This revision now requires changes to proceed. Comment at: test/Index/print-type.cpp:202 // CHECK: CallExpr=Bar:17:3 [type=outer::inner::Bar] [typekind=Elaborated] [canonicaltype=outer::inner::Bar]

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing the clang's diagnostic interfaces.

[PATCH] D55415: Revert removal of tidy plugin support from libclang

nik added a comment. +1 as this seems to fix the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a subscriber: arphaman. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik marked 4 inline comments as done. nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:581 + unsigned getPreambleCounter() const { return PreambleCounter; } + ilya-biryukov wrote: > NIT: `getPreambleCounterForTests()`? This is clearly

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 176962. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik updated this revision to Diff 176941. nik added a comment. Added a dedicated diagnostic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked 2 inline comments as done and an inline comment as not done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > nik wrote: > >

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik marked 2 inline comments as done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > There's a mechanism to handle preamble with

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 176826. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Lex/Preprocessor.h include/clang/Serialization/ASTWriter.h

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

nik added a comment. Please fix this also for libclang clients. I think it's safe to assume that files might be edited once CXTranslationUnit_PrecompiledPreamble or CXTranslationUnit_CacheCompletionResults is set as flag - that's what clang_defaultEditingTranslationUnitOptions() returns.

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 175210. nik added a comment. > Maybe produce a **fatal** error in the preprocessor? That seems to be the > simplest option: the preprocessor is aware it's building the preamble and > there's definitely some logic to produce fatal errors in other cases (include

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. I still don't have feedback for a real world case except "unintentional #include". Unfortunately, in real world cases the cyclic include might be not obvious at all. @ilya: As far as I understand you prefer to make the preamble generation rather fail as long as we don't

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 174022. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp lib/Frontend/PrecompiledPreamble.cpp unittests/Frontend/PCHPreambleTest.cpp

[PATCH] D54523: [Preamble] Reuse preamble even if an unsaved file does not exist

nik created this revision. Herald added a subscriber: cfe-commits. When a preamble is created an unsaved file not existing on disk is already part of PrecompiledPreamble::FilesInPreamble. However, when checking whether the preamble can be re-used, a failed stat of such an unsaved file invalidated

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. In https://reviews.llvm.org/D41005#1295632, @ilya-biryukov wrote: > > Before this change, this was not a problem because OverriddenFiles were > > keyed on Status.getUniqueID(). Starting with this change, the key is the > > file path. > > I suggest keeping two maps for

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Coming back to this one, I see a failing test: PCHPreambleTest.ReparseWithOverriddenFileDoesNotInvalidatePreamble Note that PCHPreambleTest.ReparseWithOverriddenFileDoesNotInvalidatePreamble references the header paths in different ways ("//./header1.h" vs

[PATCH] D54077: [clangd] Implemented DraftFileSystem

nik added a comment. In https://reviews.llvm.org/D54077#1288413, @nik wrote: > If it helps (and the LSP allows it): In case A.h is edited, we flag it dirty. > If the user makes some file depending on it visible (or the current file), we > trigger a reparse for that. Not sure whether the LSP

[PATCH] D54077: [clangd] Implemented DraftFileSystem

nik added a comment. In https://reviews.llvm.org/D54077#1288404, @ioeric wrote: > I would be very happy if `A.cc` can see the unsaved `A.h` when I am editing > `A.cc`. We have that in Qt Creator (with libclang) and that's quite handy as it can save you some build cycles. > Not sure if I

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. I've only the minimal example at hand right know - I'm waiting for feedback about the real world case. Repository: rC Clang https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. In https://reviews.llvm.org/D53866#1281978, @ilya-biryukov wrote: > Why does resetting the conditional stack is the right thing to do here? Because this case can be detected and handled without loosing the benefits of the preamble. > Failing to build the preamble in that

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik created this revision. Herald added subscribers: cfe-commits, arphaman. If a header file was processed for the second time, we could end up with a wrong conditional stack and skipped ranges: In the particular example, if the header guard is evaluated the second time and it is decided to skip

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik added inline comments. Comment at: include/clang-c/Index.h:5302 +CXCodeCompleteResults *results, unsigned completion_index, +unsigned fixit_index, CXSourceRange *replacement_range); + Please document the parameters. It's more important here than for

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 151116. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D48116 Files: include/clang-c/Index.h include/clang/Basic/Diagnostic.h lib/Basic/DiagnosticIDs.cpp test/Index/ignore-warnings-from-headers.cpp

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik created this revision. Herald added a subscriber: cfe-commits. Depending on the included files and the used warning flags, e.g. - Weverything, a huge number of warnings can be reported for included files. As processing that many diagnostics comes with a performance impact and not all clients

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik added a comment. - Sometimes you refer to "fixits", sometimes "fix-its" and some times "FixIts". Unify to what is already there. - The term "completion items" is new so far. Use "completions" for consistency. https://reviews.llvm.org/D46862

  1   2   3   >