[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

grandinj added a comment. thanks for the quick response Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

grandinj added a comment. I note that building on Ubuntu, I am now seeing failures like: env/gbuildtojson/gbuildtojson.cxx:10: In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/algorithm:74: In file included from

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

grandinj added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + Just curious - if they mostly contain 1 or 2 elements, why

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

grandinj added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:78 + const BoundNodesTreeBuilder + const TraversalKind Traversal; + note that making fields const tends to disable various move optimisations, so better to mark the whole

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

grandinj added a comment. In D76572#1936861 , @Quuxplusone wrote: > Nice. Does LibreOffice have anything (either in clang-tidy or in a paper > guideline) against `T(x)`-style casts? E.g. No, we don't have very many of those in our codebase, so we have

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

grandinj added a comment. Libreoffice has a similar clang-tidy-style cast-checker here: https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/cstylecast.cxx https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/test/cstylecast.cxx Repository: rG LLVM

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

grandinj added a comment. Herald added a project: LLVM. Hi Thanks a lot for this checker - would it be possible to enhance it to also update stuff in associated header files? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52136/new/

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

grandinj added a comment. You might want to look at the equivalent LibreOffice checkers, which we have been using for some time https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/external.cxx

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

grandinj added a comment. Nice! I went with a more brute force approach, and I also struggled with logical vs physical const-correctness https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/store/constmethod.cxx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

grandinj added a comment. There is no need to wrap SVG in HTML if you want to display it in a web-browser, you can just open the web-browser explicitly, they already support opening SVG, use something like webbrowser.open_new(url) i.e. https://docs.python.org/2/library/webbrowser.html

[PATCH] D40409: [Tooling] Acknowledge that many CompilationDatabases don't support enumeration.

grandinj added inline comments. Comment at: include/clang/Tooling/CompilationDatabase.h:122 + /// can enumerate their source files. + virtual std::vector getAllFiles() const { return {}; } I know very little about LLVM's standards, so ignore me if I'm wrong,

[PATCH] D31029: [analyzer] Fix logical not for pointers with different bit width

grandinj added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:313 - Loc makeNull() { -return loc::ConcreteInt(BasicVals.getZeroWithPtrWidth()); + // Pass type to accomodate for different pointer bit-witdths of different + //

[PATCH] D28716: [libc++] Diagnose null inputs in std::string using _LIBCPP_DIAGNOSE_WARNING

grandinj added a comment. would it be better to internally treat __attribute__((non_null)) like diagnose_if ? then you get all the warnings for free? https://reviews.llvm.org/D28716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org