OfekShilon added subscribers: kosarev, OfekShilon.
OfekShilon added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2393
+particular object (so for example, it's never correct to call this function
+passing the addresses of fields in the same struct, elements of
OfekShilon added a comment.
@aaron.ballman 'Ofek Shilon', ofekshi...@gmail.com is fine.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130933/new/
https://reviews.llvm.org/D130933
___
cfe-commits mailing list
OfekShilon updated this revision to Diff 451535.
OfekShilon added a comment.
My apologies for the mess, hopefully the diff I just uploaded includes all the
right fixes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130933/new/
https://reviews.llvm.org/D130933
Files:
OfekShilon added a comment.
> It looks like something might have gone wrong because the diff looks like
> it's now a diff against something other than the main branch (it looks like
> it's adding the SimpleHandler lines in Attr.td, but those lines already exist
> in main).
Sorry about that,
OfekShilon updated this revision to Diff 451237.
OfekShilon added a comment.
Addressed Aaron's comments (thanks!). Hope I got the update-diff procedure
right.
I don't have commit permissions, would appreciate if someone could push this.
CHANGES SINCE LAST ACTION
OfekShilon created this revision.
OfekShilon added reviewers: xur, davidxl.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
OfekShilon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Following this
