[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-05-16 Thread Oksana Shadura via Phabricator via cfe-commits
ksu.shadura added a comment. In https://reviews.llvm.org/D45766#1098823, @Quuxplusone wrote: > In https://reviews.llvm.org/D45766#1097797, @ksu.shadura wrote: > > > Thank you for the test example! I got your point, but I wanted to ask if it > > should be like this for commutative operations? >

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-05-14 Thread Oksana Shadura via Phabricator via cfe-commits
ksu.shadura added a comment. Thank you for the test example! I got your point, but I wanted to ask if it should be like this for commutative operations? In our case it is actually matrix, and subtraction of matrices is not commutative operation.. Repository: rL LLVM

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-05-14 Thread Oksana Shadura via Phabricator via cfe-commits
ksu.shadura added a comment. Hi, we see the false-positive behavior of -Wno-self-assign-overloaded flag in case of subtraction assignment operator. The minimal reproducer that we got: https://godbolt.org/g/8PQMpR typedef int Int_t; typedef double Double_t; class TObject {}; template