[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

oleg.smolsky added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 454149. oleg.smolsky added a comment. Simplify and generalize the AST matcher. We just want to find all `return` statements in function definitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453740. oleg.smolsky added a comment. Add AST matchers for the `if` statements and improve the actual check implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files:

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky marked 3 inline comments as done. oleg.smolsky added a comment. In D131985#3727568 , @Eugene.Zelenko wrote: > In D131985#3727544 , @oleg.smolsky > wrote: > >> In D131985#3727436

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky marked 3 inline comments as done. oleg.smolsky added a comment. Thanks for the quick review, Eugene! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:110 + + Checks for `return` statements with redundant parenthesis. + Eugene.Zelenko wrote: >

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453157. oleg.smolsky added a comment. Improve mark up in the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky added a comment. In D131985#3727436 , @njames93 wrote: > The idea of this check is good, but restricting it to only return statements > seems baffling. A general check that could remove useless parens would have a > lot more value. Of

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453155. oleg.smolsky added a comment. Add a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453151. oleg.smolsky added a comment. Add docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453084. oleg.smolsky added a comment. Drop the trailing \n from the main C++ file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky created this revision. oleg.smolsky added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. oleg.smolsky requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - this

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. In D114995#3218022 , @aaron.ballman wrote: > In D114995#3218004 , @oleg.smolsky > wrote: > >> @aaron.ballman could you commit this change please? I've never had commit >>

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. @aaron.ballman could you commit this change please? I've never had commit rights... Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. Done with review changes. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:1 + //===--- UseDefaultMemberInitCheck.cpp - clang-tidy===// aaron.ballman wrote: > Spurious

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 397086. oleg.smolsky marked 2 inline comments as done. oleg.smolsky added a comment. Addressed review comments: explicit types and doc changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. In D114995#3198033 , @aaron.ballman wrote: > In D114995#3183240 , > @malcolm.parsons wrote: > >> In D114995#3180475 , >> @aaron.ballman

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 395190. oleg.smolsky added a comment. Added a "two constructors" test case along with the support for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. Sure, adding an option is easy, if that's the consensus. What would you call it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a subscriber: aaron.ballman. oleg.smolsky added a comment. @aaron.ballman do you happen to know who is best to review a `clang-tidy` fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391503. oleg.smolsky added a comment. Ran `clang-format` on the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391494. oleg.smolsky added a comment. Ran `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391470. oleg.smolsky added a comment. Fixing the uploaded diff... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky created this revision. Herald added a subscriber: carlosgalvezp. oleg.smolsky requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - we want to deal with non-default constructors that just happen to contain constant

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. @MyDeveloperDay that's the exact point. I authored this change to close a gap in some lambda formatting cases. The tests (existing, modified and added) express all relevant cases that I knew at the time. @jaafar, @curdeius - this is just C++ code. Nothing is set

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1282335, @krasimir wrote: > Looks good! Will stamp when the scopes are removed. Cool, thanks, Krasimir. I've just posted the updated patch. > Oleg, do you need someone to commit this for you? I do, could you commit this please?

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 171932. oleg.smolsky marked 2 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky marked 2 inline comments as done. oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11854 + // case above. + { +auto Style = getGoogleStyle(); djasper wrote: > No need to use a scope here. Feel free to redefine

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. Folks, are there any other comments/suggestions? Repository: rC Clang https://reviews.llvm.org/D52676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170915. oleg.smolsky added a comment. Added a FIXME comment at Krasimir's request. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11736 + // line and there are no further args. + verifyFormat("function(1, [this, that] {\n" + " //\n" krasimir wrote: > oleg.smolsky wrote: > > djasper wrote: > > >

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170776. oleg.smolsky added a comment. Corrected test regressions, removed temporary hacks. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:78 EXPECT_EQ(Expected.str(), format(Code, Style)); +#if 0 if (Style.Language == FormatStyle::LK_Cpp) { Oops., let me fix this... Repository: rC Clang

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170773. oleg.smolsky added a comment. Corrected test regressions. Repository: rC Clang https://reviews.llvm.org/D52676 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky marked 2 inline comments as done. oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n");

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky marked 2 inline comments as done. oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); djasper

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170515. oleg.smolsky edited the summary of this revision. oleg.smolsky added a comment. Added another test case. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); krasimir wrote: > This looks a bit suspicious: I'd

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170270. oleg.smolsky added a comment. Generalized the patch so that it deals with lambda args irrespective of bin packing. Added additional tests and patched existing ones. Repository: rC Clang https://reviews.llvm.org/D52676 Files:

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1268806, @djasper wrote: > In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote: > > > In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > > > > > Ok, I think I agree with both of you to a certain extent, but I

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > Ok, I think I agree with both of you to a certain extent, but I also think > this change as is, is not yet right. > > First, it does too much. The original very first example in this CL is > actually

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. @djasper @klimek could you chime in please? This patch strives to cleanup a quirk in lambda formatting which pushes code too far to the right. Here is the problematic case: void f() { something.something.something.Method(some_arg,

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1251342, @krasimir wrote: > Digging a bit further, seems like the behavior you're looking for could be > achieved by setting the `AlignAfterOpenBracket` option to `DontAlign` or > `AlwaysBreak`: > > % clang-format

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1250124, @oleg.smolsky wrote: > In https://reviews.llvm.org/D52676#1250071, @krasimir wrote: > > > In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote: > > > > > In https://reviews.llvm.org/D52676#1249784, @krasimir

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1250071, @krasimir wrote: > In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote: > > > In https://reviews.llvm.org/D52676#1249784, @krasimir wrote: > > > > > IMO `BinPackArguments==false` does not imply that there

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 167611. oleg.smolsky marked an inline comment as done. oleg.smolsky added a comment. Tweaked if/else/return structure, added comments. No functional changes. Repository: rC Clang https://reviews.llvm.org/D52676 Files: