osandov accepted this revision.
osandov added a comment.
This revision is now accepted and ready to land.
That's fair enough. I don't know if I'm qualified to review this, but this I
think this is a better solution than my fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
osandov added a comment.
I tested my reproducer and it also fixes it, thanks. Should it be an error to
specify `-fno-dwarf-directory-asm` together with `-gdwarf-5`, since that
produces incorrect results?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
osandov added a comment.
Thank you! I don't have commit access. How can I get this committed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77682/new/
https://reviews.llvm.org/D77682
___
cfe-commits
osandov updated this revision to Diff 256352.
osandov edited the summary of this revision.
osandov added a comment.
Update summary and test case to better reflect the issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77682/new/
osandov added a comment.
The style guide I'm following (the Linux kernel style) wants `AfterEnum:
false`. A cursory search suggests that people treat this trailing comma
behavior as a feature
(https://stackoverflow.com/questions/23072223/clang-format-style-options-for-enums).
However, I think
osandov created this revision.
osandov added reviewers: MyDeveloperDay, krasimir.
osandov added projects: clang-format, clang.
Herald added a subscriber: cfe-commits.
clang-format currently puts the first enumerator on the same line as the
enum keyword and opening brace if it fits (for example,
