[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG366e57de23ed: [clang-cl] Add /Zc:wchar_t- option (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added a comment. In D125513#3519200 , @thakis wrote: > Looks good to me after addressing Hans's comment. > > Do you have commit access? Thanks for asking, @thakis. I do have comment access. Repository:

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:50 // RUN: %clang_cl /c -### /Zc:wchar_t- -- %s 2>&1 | FileCheck -check-prefix=WCHAR_T-OFF %s -// WCHAR_T-OFF: argument unused during compilation +// WCHAR_T-OFF:

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng updated this revision to Diff 430096. pzheng marked an inline comment as done. pzheng added a comment. Address @hans's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://reviews.llvm.org/D125513 Files:

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added inline comments. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">;

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng updated this revision to Diff 429559. pzheng added a comment. Address @thakis's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://reviews.llvm.org/D125513 Files: clang/include/clang/Driver/Options.td

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, thakis, hans. Herald added a project: All. pzheng requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Map /Zc:wchar_t- to the cc1 flag -fno-wchar which is already

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng added a comment. Thanks for the heads-up, @thakis. I have reverted the patch for now and will try to reproduce the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a9b4fb4aa6d: [COFF, ARM64] Add __break intrinsic (authored by pzheng). Changed prior to commit:

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng added a comment. Thanks for reviewing the patch, @rnk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-commits mailing list

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng updated this revision to Diff 423754. pzheng added a comment. Address comments from @mstorsjo. Thanks for catching the missing test, @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, efriedma. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D100509: Support GCC's -fstack-usage flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b36a041fd7: Support GCCs -fstack-usage flag (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for all the feedbacks, @MaskRay! I will wait another day before committing the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345498. pzheng added a comment. Address new comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345470. pzheng added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 2 inline comments as done. pzheng added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 344135. pzheng added a comment. Address a few more comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343795. pzheng added a comment. Minor update to some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 7 inline comments as done. pzheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + MaskRay wrote: > CC1

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343794. pzheng added a comment. Addess @MaskRay's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 338551. pzheng added a comment. Add missing comments. Thanks for spotting it, @xbolva00. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files:

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. Thanks for all the great feedbacks, @jansvoboda11, @xbolva00 and @lebedev.ri! Is there any other concern that needs to be addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. I checked some of the functions in zstd where gcc outputs "dynamic,bounded", but did not find any straightforward way to simplify them into standalone tests. If anyone happen to have a simple test case, I would be more than happy to add here. Repository: rG LLVM

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2692259 , @xbolva00 wrote: > Set current_function_has_unbounded_dynamic_stack_size to 1 when pushing a > variable-sized argument onto the stack. > > if (current_function_has_unbounded_dynamic_stack_size)

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2692127 , @xbolva00 wrote: >>> :: > > gcc also supports "bounded" - do you plan to somehow handle it? > (https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#Developer-Options), > eg:

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337802. pzheng added a comment. Mention the flag in release notes based on @xbolva00's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files:

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for your feedback, @jansvoboda11! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 ___

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337778. pzheng added a comment. Address @jansvoboda11's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files:

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2689839 , @lebedev.ri wrote: > Might you be interested in implementing [[ > https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a > follow-up? Thanks for bring it up, @lebedev.ri. Yes, I will

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng created this revision. pzheng added reviewers: apazos, efriedma, seaneveson, bruno, MatzeB, hfinkel. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9645059c5de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cca0f2e5bb: [AArch64] Adding Neon Sm3 Sm4 Intrinsics (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng added a comment. In D87162#2257233 , @MaskRay wrote: > LGTM. > >> It's probably not used very common, but we do have some baremetal use cases >> still relying on these flags to be propagated to GCC. > > Thanks for the explanation! (Though I think

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bccd2b4350f: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng updated this revision to Diff 290038. pzheng marked an inline comment as done. pzheng added a comment. Updated the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87162/new/ https://reviews.llvm.org/D87162 Files:

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng marked an inline comment as done. pzheng added a comment. In D87162#2257192 , @MaskRay wrote: > Can D83648 be closed now? Yes, I have closed it. > BTW, can you describe a bit about your use cases? Forwarding

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng created this revision. pzheng added reviewers: MaskRay, apazos. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. pzheng requested review of this revision. With 6a75496836ea14bcfd2f4b59d35a1cad4ac58cee

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng updated this revision to Diff 278361. pzheng added a comment. Add target triple used in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 Files: clang/include/clang/Driver/Options.td

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng marked 2 inline comments as done. pzheng added a comment. In D83648#2146606 , @MaskRay wrote: > Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html > [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc >

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng updated this revision to Diff 277316. pzheng added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 Files: clang/include/clang/Driver/Options.td

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng added a comment. Actually, this patch won't change --help because it just reduced some duplication by extracting the common part (" the integrated assembler") of the help message into the "help" of "OptOutFFlag". Sorry for the confusion. The real fix here is to restore "integrated_as"

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng created this revision. pzheng added reviewers: MaskRay, dblaikie, echristo. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. DriverOption seems to be accidentally removed from integrated_as definition in commit e5158b5

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added a comment. In D62686#1816681 , @lewis-revill wrote: > Fix .cfi_offset signedness error. Thanks, @lewis-revill. It looks correct now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added a comment. I see the following .cfi_offset directives generated using @shiva0217's test case. Any idea why the offset for ra is 536870908? callt0, __riscv_save_0 .cfi_def_cfa_offset 16 .cfi_offset ra, 536870908 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:278 // Add CFI directives for callee-saved registers. - const std::vector = MFI.getCalleeSavedInfo(); - // Iterate over list of callee-saved registers and emit .cfi_restore - //

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng abandoned this revision. pzheng added a comment. Hi Sam, Thanks for pointing me to the patch. I can abandon this one now. Pengxuan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66266/new/ https://reviews.llvm.org/D66266

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng created this revision. Herald added subscribers: cfe-commits, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso,

[PATCH] D62924: [cmake] Remove duplicate TestingSupport library for linking

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34d1a4e07b8: [cmake] Remove duplicate TestingSupport library for linking (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62924/new/

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

pzheng added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) quantum wrote: > thakis wrote: > > The library is already up here. Why do we need it twice? > We don't. It's removed in the code that's

[PATCH] D62924: [cmake] Remove duplicate TestingSupport library for linking

pzheng created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch cleans up a duplicate use of TestingSupport library. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62924 Files: clang/unittests/Tooling/CMakeLists.txt