[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___

[PATCH] D122087: Add HLSL Language Option and Preprocessor

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122087/new/ https://reviews.llvm.org/D122087 ___

[PATCH] D122085: Add clang DirectX target support

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. All seems very reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122085/new/ https://reviews.llvm.org/D122085

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57476/new/ https://reviews.llvm.org/D57476 ___ cfe-commits

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete added a comment. In D55869#1339537 , @rjmccall wrote: > It sounds like it's fine. Thanks for the review! Just pushed it as r349952. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC349952: Convert some ObjC retain/release msgSends to runtime calls. (authored by pete, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete added a comment. Thanks for all the feedback so far. Is there anything else you'd like me to change before I can land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/ https://reviews.llvm.org/D55869 ___ cfe-commits

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete added a comment. In D55869#1337723 , @js wrote: > In D55869#1337711 , @dexonsmith > wrote: > > > In D55869#1337706 , @js wrote: > > > > > The ObjFW runtime itself does

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete updated this revision to Diff 179017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/ https://reviews.llvm.org/D55869 Files: include/clang/Basic/ObjCRuntime.h lib/CodeGen/CGObjC.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete marked 3 inline comments as done. pete added a comment. In D55869#1335783 , @rjmccall wrote: > So, once upon a time this was a problem because we were rewriting the method > calls in the runtime itself. Can you explain how that's not a problem now?

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete created this revision. pete added reviewers: rjmccall, ahatanak, erik.pilkington. Herald added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as retain/release instead of sending a message to those functions. This is an extension of the work we

[PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

pete added a comment. In D55802#1334008 , @rjmccall wrote: > You're making intrinsics with `weak_external` linkage? I feel like that's > going to be unnecessarily awkward in the future, but okay. Yeah... i was a little surprised that was possible, but

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete added a comment. In D55349#1323926 , @rjmccall wrote: > LGTM. Thanks for the review! Landed in r348687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete updated this revision to Diff 177308. pete marked an inline comment as done. pete added a comment. Added test for integer argument and updated code to only accept pointer types to allocWithZone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete marked 5 inline comments as done. pete added inline comments. Comment at: include/clang/Basic/ObjCRuntime.h:200 +case WatchOS: + return true; + rjmccall wrote: > Did we really add this so long ago? Wow. Yeah! I was thinking that too! CHANGES

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete updated this revision to Diff 177246. pete added a comment. Thanks for the review. Have fixed the comments as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349 Files: include/clang/Basic/ObjCRuntime.h

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete created this revision. pete added reviewers: ahatanak, rjmccall, erik.pilkington. Herald added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as alloc/allocWithZone instead of sending a message to those functions. This patch adds support for

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

pete added a comment. In https://reviews.llvm.org/D30882#1075461, @dexonsmith wrote: > In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote: > > > In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote: > > > > > I don't think this is quite right. I know at least `make`-based > >

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

pete created this revision. Herald added a subscriber: nemanjai. This adds a PP callback for the __has_include and __has_include_next directives. Checking for the presence of a header should add it to the list of header dependencies so this overrides the callback in the dependency scanner. I

[PATCH] D30881: Track skipped files in dependency scanning

pete created this revision. Its possible for a header to be a symlink to another header. In this case, both are actually the same underlying file, and will both have the same include guards. Because of this, if we #include the header, then #include the symlink, or vice versa, then one will