[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-25 Thread Peter Rong via Phabricator via cfe-commits
Peter added a comment. In D140059#4081549 , @vabridgers wrote: > Hello, it appears this patch causes a crash when I analyze this reproducer, > with Z3 enabled. In the case shown here, the analyzer finds that 'f' to the > call a(f) is uninitialized, and

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-20 Thread Peter Rong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0a89825a289d: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm… (authored by Peter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-10 Thread Peter Rong via Phabricator via cfe-commits
Peter updated this revision to Diff 487946. Peter added a comment. use const ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/APSInt.h

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-10 Thread Peter Rong via Phabricator via cfe-commits
Peter marked an inline comment as done. Peter added a comment. Herald added a subscriber: StephenFan. @pcc @efriedma Would you mind review the changes to clang when you are free? If they look good I'll merge them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-07 Thread Peter Rong via Phabricator via cfe-commits
Peter marked an inline comment as done. Peter added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:5386 + if (InitInt) +InitExpr = DBuilder.createConstantValueExpression(InitInt.value()); +} else if (Init.isFloat()) efriedma wrote

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2023-01-07 Thread Peter Rong via Phabricator via cfe-commits
Peter updated this revision to Diff 487118. Peter added a comment. [DebugInfo] update clang to match semantics changes in APSInt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2022-12-26 Thread Peter Rong via Phabricator via cfe-commits
Peter added a comment. After this patch the semantics of getExtValue changed and thus broke clang. @pcc Would you mind take a look if the modification works for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2022-12-26 Thread Peter Rong via Phabricator via cfe-commits
Peter updated this revision to Diff 485328. Peter added a comment. change base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/APSInt.h

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

2022-12-26 Thread Peter Rong via Phabricator via cfe-commits
Peter updated this revision to Diff 485327. Peter added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files