[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4639907 , @kees wrote: > Can you refresh this patch to work with https://reviews.llvm.org/D148381 ? My > testing seems to imply that it doesn't know the size of the array. I assume > the `if (!IsUnboundedArray)` check is

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

shafik added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant or can we close the PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875

[PATCH] D117773: [clang-tidy] added JSON output to clang-tidy-diff.py

shafik added a comment. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant of can we close this PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117773/new/ https://re

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557373. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

probinson added a comment. > You need to do `returnit`. Doh! Thanks. Those two instantiations could have different function bodies, but would have the same mangled name. Got it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147655/new/ https://re

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

Prabhuk updated this revision to Diff 557372. Prabhuk added a comment. Removed IsIntegratedAssemblerDefault. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541 Files: clang/lib/Basic/Targets.cpp clang/li

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8aab289b554: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Changed prior to commit: https:

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 557368. AlexVlx added a comment. Use double dash flags exclusively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSupport.rst clang/docs/ReleaseNotes.rst Index: clang/docs/Relea

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. In D147655#4650964 , @probinson wrote: > Hi @rsmith, > >> these two different templates would have the same mangling: > > template T returnit() {return I;}; > template T returnit() { return I; } > > I tried compiling `long

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

probinson added a comment. Hi @rsmith, > these two different templates would have the same mangling: template T returnit() {return I;}; template T returnit() { return I; } I tried compiling `long foo() { return returnit(); }` with these two templates, and got different manglings. `_Z8re

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:267-269 +- Fix segfault while running clang-rename on a non existing file. + (`#36471 `_) +- Fix crash when diagnosing incorrect usage of ``_Nullable``

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

aaron.ballman added a comment. In D141192#4647977 , @budimirarandjelovicsyrmia wrote: > Ping. Given the lack of response, I think it's safe to assume this patch has been abandoned by the author. I'd recommend starting a new patch review for it on GitH

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. In D145214#4650189 , @hiraditya wrote: > I tested it on a licheepi board (riscv64 debian) and all the tests modified > in this patch have passed. LGTM. Can you help me land this patch? > There are other tsan failures but i th

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi updated this revision to Diff 557362. alexfanqi added a comment. thanks @hiraditya Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cm

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 557354. courbet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/include/clang/Analysis/Analyses/ThreadSafety.h clang/include/

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added a comment. Thanks for the review. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2304-2305 + CFGBlockInfo &Initial = BlockInfo[CFGraph->getEntry().getBlockID()]; + CFGBlockInfo &Final = BlockInfo[CFGraph->getExit().getBlockID()]; + aaronpuche

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie added a comment. @steakhal gentle ping for one last round of reviews CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158156/new/ https://reviews.llvm.org/D158156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557346. chaitanyav added a comment. Rebase with upstream and update code as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/Releas

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

enh accepted this revision. enh added a comment. yeah, lgtm from the Android side too, unless rprichard has more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158641/new/ https://reviews.llvm.org/D158641 _

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4650666 , @rjmccall wrote: > Yeah, the more I think about this, the more I think that while (1) Apple > should upstream its use of an older default, regardless (2) the existence of > any targets at all with an older de

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

dblaikie added a comment. @rsmith ping on this thread - wondering what you'd prefer the direction be here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158296/new/ https://reviews.llvm.org/D158296 ___ cf

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. The Clang Driver/CodeGen and compiler-rt changes look good to me. Of course please wait for an Android reviewer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557335. efriedma added a comment. Revised so guest exit thunks actually work. Thanks for the tip about the symbols; I forgot to look at the object file in addition to the generated assembly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

ilinpv added a comment. The patch tested on NDK r26 bulding simple Function Multi Versioning project and running on Android API 25,29,30,33 - works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158641/new/ https://reviews.llvm.org/D158641 _

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

ilinpv updated this revision to Diff 557332. ilinpv retitled this revision from "[AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs." to "[AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.". ilinpv edited the summary of t

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added a comment. In D157547#4650643 , @efriedma wrote: > Seems to be working for simple cases, but I'm not sure this is actually > working properly (I'm still seeing LNK1000 crashes). I don't know if it's related to crashes that you're seeing, but

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 updated this revision to Diff 557330. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158561/new/ https://reviews.llvm.org/D158561 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 557328. AlexVlx added a comment. Use double dash compiler flags only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx added inline comments. Comment at: clang/docs/HIPSupport.rst:266 + +- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on + phase, has the following effects: MaskRay wrote: > Newer long options that don't use the common prefix

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. Yeah, the more I think about this, the more I think that while (1) Apple should upstream its use of an older default, regardless (2) the existence of any targets at all with an older default means that tests like this always need to be using `-fclang-abi-compat=latest`

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. In D147655#4650663 , @rjmccall wrote: > I've been informed that Apple's change to the default ABI compatibility mode > is in our private fork, so this is not your problem; sorry for the noise. > > I'm not sure why we decided to do

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. I've been informed that Apple's change to the default ABI compatibility mode is in our private fork, so this is not your problem; sorry for the noise. I'm not sure why we decided to do that privately; I'll see if we can fix that. Repository: rG LLVM Github Monorepo

[PATCH] D156344: Disable call to fma for soft-float

long5hot added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. Hey, Richard. It looks like your new tests are failing on Apple's buildbots, I'm guessing because the default ABI compatibility mode is older. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147655/new/ https://reviews.llv

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4650244 , @carlosgalvezp wrote: > @shafik @aaron.ballman @dblaikie > > Hello! Just wanted to check if there's any blockers for merging this patch? > We are now on Clang 18, i.e. 2 releases after the warning was intro

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557315. efriedma added a comment. Updated with my attempt at guest exit thunks. Seems to be working for simple cases, but I'm not sure this is actually working properly (I'm still seeing LNK1000 crashes). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/docs/HIPSupport.rst:266 + +- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on + phase, has the following effects: Newer long options that don't use the common prefix like `-f` are pr

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6569 + + if (Args.hasArg(options::OPT_hipstdpar_interpose_alloc)) +CmdArgs.push_back("-hipstdpar-interpose-alloc"); This can use AddLastArg. CHANGES SINCE LAST ACTION

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1261 HelpText<"HIP runtime installation path, used for finding HIP version and adding HIP include path.">; +def hipstdpar : Flag<["-", "--"], "hipstdpar">, + Visibility<[ClangOption, CC1Option]>

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. Note we have a second crash linked to this PR: https://github.com/llvm/llvm-project/issues/67173#issuecomment-1733647699 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 __

[PATCH] D156711: [clang][ExprConstant] Fix assertion failure in constant expression folding

antmo abandoned this revision. antmo added a comment. yes indeed you fixed this @shafik. thanks for the update. abandoning this revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156711/new/ https://reviews.llvm.org/D156711 __

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list cfe-c

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e97db89ae8e: [PowerPC] Emit IR module flag for current float abi (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D116016?vs=530843&id=557298#toc Repository: rG LLVM Github Mon

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf abandoned this revision. qiucf added a comment. Migrated to https://github.com/llvm/llvm-project/pull/67299 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158066/new/ https://reviews.llvm.org/D158066 __

[PATCH] D159159: [PowerPC] Disable float128 on AIX in Clang

qiucf abandoned this revision. qiucf added a comment. Migrated to https://github.com/llvm/llvm-project/pull/67298 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159159/new/ https://reviews.llvm.org/D159159 __

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

liaolucy added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/ https://reviews.llvm.org/D158824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thank you, the updates look good! Please go ahead and merge after addressing the last minor nits. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:594 +

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

BertalanD added a comment. FYI, we found a crash related to this patch: https://github.com/llvm/llvm-project/issues/67260 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 _

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. @MyDeveloperDay addressed your comments. Thanks! Would love to get this in before Phabricator closes. Anything else I can do to help? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 557275. jaredgrubb added a comment. Rebased and adjusted docs to reflect that this patch would appear in clang-format 18 (not 17 now). Removed extraneous comment change (will do NFC later for that) Removed other build-system changes (as requested). CHANG

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb marked an inline comment as done. jaredgrubb added inline comments. Comment at: clang/unittests/Format/FormatTestObjC.cpp:1619 + // Reflow after first macro. + // FIXME: these should indent but don't. + verifyFormat("- (id)init ATTRIBUTE_MACRO(X)\n"

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 557274. jaredgrubb added a comment. Hopefully this will satisfy and we can merge! I didn't notice the Phabricator timeline and I'm hoping we can finish this before Oct 1. Rebased. Removed extraneous doc comment not related to patch (as requested). Removed

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

AlexYzhov added a comment. Add command without backend wrapper destroys the compatibility to different linkers. Some people will use gcc driver instead of ld/lld itself as linker, a "-Wl," prefix is needed in this situation. i've met familiar issue that corrupts the link step: /opt/homebrew/

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 557270. RIscRIpt added a comment. Rebase onto main. Run lit clang/test. Bump. Any chance we continue the review? I know it looked stale for a while I couldn't address review comments, but now I have time to work at this patch. Repository: rG LLVM Github

[PATCH] D157890: Propagate the volatile qualifier of exp to store /load operations .

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2641d9b2807d: Propagate the volatile qualifier of exp to store /load operations . (authored by umesh.kalappa0, committed by long5hot). Herald added

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

carlosgalvezp added a comment. @shafik @aaron.ballman @dblaikie Hello! Just wanted to check if there's any blockers for merging this patch? We are now on Clang 18, i.e. 2 releases after the warning was introduced, so IMO I believe it's a good time to turn it into a hard error and test it in the

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4649864 , @dyung wrote: > Hi @rsmith, we have an internal test where your change seems to have changed > the mangling in C++17 mode and wanted to check if that was intentional. [...] > Are these changes in non-C++20 m

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557263. Prabhuk added a comment. Updated the test name and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/l

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:108 +TEST(DataLayoutTest, TargetTripleManglingComponent) { + Triple TT = Triple("x86_64-unknown-uefi"); UEFI may be a better name in case we test mo

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557261. Prabhuk added a comment. Add DataLayoutTest for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/Ta

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. I tested it on a licheepi board (riscv64 debian) and all the tests passed. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

vvereschaka added a comment. Hi @sammccall, also failed `FAIL: Clang-Unit::69` test on these builders - https://lab.llvm.org/buildbot/#/builders/86/builds/65581 - https://lab.llvm.org/buildbot/#/builders/60/builds/14027 - https://lab.llvm.org/buildbot/#/builders/119/builds/15226 Repository:

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + UnwindTableLevel Remove the IsIntegratedAssemble

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

dyung added a comment. Hi @sammccall, your change seems to be causing a test failure on several bots, can you take a look and revert if you need time to investigate? TEST 'Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/8/35' FAILED ***

[PATCH] D159540: [Basic] X86 backend changes for UEFI

mysterymath added a comment. There should also be tests for this behavior in llvm/test/CodeGen/X86. I wouldn't think it necessary to fully test the calling convention; that should already be well covered; just something in those key test files (e.g., `sse-regcall.ll`) to verify that the `uefi`

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

MaskRay accepted this revision. MaskRay added a comment. DataLayout needs a unittest in llvm/unittests/IR/DataLayoutTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bd5bd888f1: [dataflow] use true/false literals in formulas, rather than variables (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D153485?vs=537304&id=557245#toc Repository

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

jyknight reopened this revision. jyknight added a comment. This revision is now accepted and ready to land. Reopening the review since it ended up reverted, but I do think we DO want to have at least some of the changes proposed here (and/or from the pending D158372

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis added a comment. Herald added subscribers: pmatos, asb, abrachet. Herald added a project: All. Also useful for random other projects on github: https://github.com/mapbox/mason/pull/545#issuecomment-367082479 GCC also added support for this flag: https://github.com/gcc-mirror/gcc/commit/f

[PATCH] D156890: [clang] Remove outdated INSTALL.txt

stephanlachnit added a comment. In D156890#4649226 , @cor3ntin wrote: > @stephanlachnit do you need me to land this on your behalf? What email should > we use? Yes, please! You can use stephanlach...@debian.org Repository: rG LLVM Github Monorepo C

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov added a comment. @cor3ntin any suggestions on how to proceed here? I hope the approach taken in the current patch should already provide meaningful and improved results in most cases. It only affects the diagnostics output, so changing or reverting it should be relatively easy in

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155572/new/ https://reviews.llvm.org/D155572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

Prabhuk updated this revision to Diff 557227. Prabhuk added a comment. Addressed review comments about the inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541 Files: clang/lib/Basic/Targets

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added a comment. @phosek -- Regarding the abandoning commit. I had messed up the commit splitting process earlier. Uploaded the correct set of files for this change now. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557223. Prabhuk added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Triple.cpp

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557221. Prabhuk added a comment. Datalayout update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp ll

[PATCH] D19385: [scan-build] fix warnings emitted on Clang Format code base

apelete added a comment. I guess it can be closed, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19385/new/ https://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. Is it possible to abandon this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:58-59 + + // Other UEFI binary subsystems that are currently unsupported: + // efi_boot_service_driver, efi_rom, efi_runtime_driver. + CmdArgs.push_back("-subsystem:efi_application"); --

[PATCH] D159540: [Basic] X86 backend changes for UEFI

Prabhuk updated this revision to Diff 557214. Prabhuk added a comment. Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for Swift and OCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D15

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. Hi @rsmith, we have an internal test where your change seems to have changed the mangling in C++17 mode and wanted to check if that was intentional. Consider the following code: // Literals in templates #include template T returnit() {return I;}; enum colour { R

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. I do not think there is a sensible way to keep [`upgrade-datalayout2.ll`](https://github.com/llvm/llvm-project/blob/main/llvm/test/Bitcode/upgrade-datalayout2.ll) working, with the way the upgrade logic is structured, and we should rethink that test. The change here inte

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG700baeb765cf: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter (authored

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added a comment. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586 #endif it = FixablesForAllVars.byVar.erase(it); } else if (Tracker.hasUnclaimedUses(it->first)) { NoQ wrote:

[PATCH] D159540: [Basic] X86 backend changes for UEFI

mysterymath added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:522 // Mingw64 and native Win64 use Win64 CC CCIfSubtarget<"isTargetWin64()", CCDelegateTo>, You'll need to add switching for Win64 here too; this appears to be the conv

[PATCH] D159540: [Basic] X86 backend changes for UEFI

Prabhuk updated this revision to Diff 557203. Prabhuk added a comment. Uploading the backend changes correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D159540 Files: llvm/lib/Target/X86/MCTargetDesc/X8

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk marked an inline comment as done. Prabhuk added a comment. Clang Driver Changes - https://reviews.llvm.org/D159541 Current - https://reviews.llvm.org/D152206 X86 Backend changes - https://reviews.llvm.org/D159540 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557202. Prabhuk added a comment. Splitting commit into 3 commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTarge

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Introduce changes necessary for UEFI X86_64 ta

[PATCH] D159540: [Basic] X86 backend changes for UEFI

Prabhuk updated this revision to Diff 557199. Prabhuk added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang Driver changes for UEFI X86_64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ htt

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

aaronpuchert added a comment. Yeah, we should get this over the line. I'm still not quite sure where to put the check. Reading @rsmith's comment again, SemaInit might perhaps be acceptable for now, except that I should add the additional tests (in case we don't have them already). I think we a

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

erichkeane added a comment. In D148381#4649683 , @void wrote: > Friendly Ping. Aaron is away at a conference this week, so hopefully he'll do another pass when he gets back next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

rnk closed this revision. rnk added a comment. Let's close it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for reviving this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 __

<    4   5   6   7   8   9   10   11   12   13   >