[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added inline comments. Comment at: llvm/include/llvm/Support/TargetRegistry.h:26 #include "llvm/ADT/iterator_range.h" +#include "llvm/MC/MCObjectFileInfo.h" #include "llvm/Support/CodeGen.h" flip1995 wrote: > MaskRay wrote: > >

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added inline comments. Comment at: llvm/include/llvm/Support/TargetRegistry.h:26 #include "llvm/ADT/iterator_range.h" +#include "llvm/MC/MCObjectFileInfo.h" #include "llvm/Support/CodeGen.h" MaskRay wrote: > `include/llvm/Support/TargetRegistry.h now

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 345432. flip1995 added a comment. - [MC] Don't check if constructed MOFI is a nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 Files:

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2754426 , @MaskRay wrote: > Can `createMCObjectFileInfo` return `MCObjectFileInfo` instead of > `std::unique_ptr`? `createMCObjectfileInfo` returns a `MCObjectFileInfo *` similar to every other `create*` function

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 344849. flip1995 added a comment. Herald added subscribers: lldb-commits, atanasyan, jrtc27. Herald added a project: LLDB. rebased and addressed review comments: - [MC] Remove MOFI argument from MCContext constructor - [MC] Remove getTextSectionAlignment

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 marked an inline comment as done. flip1995 added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:407 - MOFI->initMCObjectFileInfo(Ctx, PIC); + // FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and + // MCObjectFileInfo needs a

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 343605. flip1995 added a comment. Remove redundant item names in doc comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 Files:

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2743735 , @MaskRay wrote: > Can you post the RISCV patch depending on this one? Yes, sure. See https://reviews.llvm.org/D102052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added inline comments. Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:57 - MOFI.reset(new MCObjectFileInfo); - MC.reset( - new MCContext(TheTriple, MAI.get(), MRI.get(), MOFI.get(), MSTI.get())); - MOFI->initMCObjectFileInfo(*MC, /*PIC=*/false); +

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2743735 , @MaskRay wrote: > Can you post the RISCV patch depending on this one? Yes, sure. See https://reviews.llvm.org/D102052. Comment at: llvm/include/llvm/Support/TargetRegistry.h:1029 +///

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. Herald added subscribers: dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_amini, rupprecht, gbedwell,

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 343056. flip1995 added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. > I'll keep this open for a few days as it touches too many things. Sounds good  I used `arc diff`. The commits I made with `git` have my name and email attached. But it seems like `arc` doesn't use them? I'll figure it out tomorrow, can't be that hard, I hope.

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. Not sure how the process from here on out is. I think it is important to note, that I don't have push rights and someone else will have to land this for me (I guess?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342354. flip1995 added a comment. Fix arc mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342352. flip1995 marked 3 inline comments as done. flip1995 edited the summary of this revision. flip1995 added a comment. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 342345. flip1995 added a comment. [MC] Untangle MCContext and MCObjectFileInfo This untangles the MCContext and the MCObjectFileInfo. There is a circular dependency between MCContext and MCObjectFileInfo. Currently this dependency also exists during

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. > The refactoring adding `Triple` to `MCContext::MCContext` [...] should be > separate. In order to make the `MCContext` construction independent from the `MCObjectFileInfo`, passing the `Triple` to the `MCContext` is necessary anyway. Moving it completely to the

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. Thanks for the review! I already thought that I will have to split this up, so I made the commits self contained so I'll do that. One question before I start: Where should I split this? Should I only split out the RISC-V patch and leave the changes that targets can

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. flip1995 added reviewers: MaskRay, rnk, asb. Herald added subscribers: frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, rupprecht, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27,