[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4299722 , @aaron.ballman wrote: > LGTM! Do you need someone to land this on your behalf? If so, what name and > email address would you like used for patch attribution? Yes, I need someone who can commit it

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4295928 , @aaron.ballman wrote: > The issue is that `GetDiagnosticTypeSpecifierID()` is called for more > diagnostics than just `warn_declspec_attribute_ignored`. You need to also > update the

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 517207. ipriyanshi1708 added a comment. Fixed the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. In D147989#4293278 , @aaron.ballman wrote: > Oops, I spoke too soon -- it looks like the precommit CI failure is related > to this patch. This is what I get when I tested

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 516037. ipriyanshi1708 marked 4 inline comments as done. ipriyanshi1708 added a comment. Removed unwanted changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 516036. ipriyanshi1708 added a comment. Added case for enum struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 marked 3 inline comments as done. ipriyanshi1708 added a comment. In D147989#4283666 , @samtebbs wrote: > This looks good to me now, nice work. Let's wait a few days for others' input > to be safe. okay! Thank You Sir.

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 515196. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic in a better way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514931. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514911. ipriyanshi1708 added a comment. Removed spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514909. ipriyanshi1708 added a comment. Updated the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257721 , @aaron.ballman wrote: > Thank you for working on this! > > The changes are missing test coverage; please be sure to add that, along with > a release note about the fix. I think there's likely more

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 513549. ipriyanshi1708 marked 5 inline comments as done. ipriyanshi1708 added a comment. Improved the logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512445. ipriyanshi1708 added a comment. Applied C++ Overloading Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257947 , @samtebbs wrote: > Thanks for the input Aaron and Martin. This is looking good. With the > suggested changes and some formatting > I

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512437. ipriyanshi1708 added a comment. Added the Release note for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257721 , @aaron.ballman wrote: > Thank you for working on this! > > The changes are missing test coverage; please be sure to add that, along with > a release note about the fix. I think there's likely more

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512421. ipriyanshi1708 added a comment. Removed the spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512419. ipriyanshi1708 added a comment. Implemented the required changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512349. ipriyanshi1708 edited the summary of this revision. ipriyanshi1708 added a comment. Updated the summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512344. ipriyanshi1708 retitled this revision from "Fix Attribute Placememt" to "[clang] Fix Attribute Placement". ipriyanshi1708 added a comment. Updated the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147989: Fix Attribute Placememt

ipriyanshi1708 updated this revision to Diff 512343. ipriyanshi1708 added a comment. Removed extra lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: Fix Attribute Placememt

ipriyanshi1708 updated this revision to Diff 512340. ipriyanshi1708 added a comment. 1. Updating D147989 : Fix Attribute Placememt # 2. Enter a brief description of the changes included in this update. Fixes https://github.com/llvm/llvm-project/issues/61660

[PATCH] D147989: Fix Attribute Placememt

ipriyanshi1708 created this revision. Herald added a project: All. ipriyanshi1708 added a reviewer: samtebbs. ipriyanshi1708 published this revision for review. Herald added a project: clang. Fixed the error message for attribute placement. Earlier it was showing 'place it after "enum"' but it

[PATCH] D147141: [clang][documentation][enhancement]Documented Optimization Flags

ipriyanshi1708 created this revision. Herald added a project: All. ipriyanshi1708 added reviewers: samtebbs, aaron.ballman. ipriyanshi1708 published this revision for review. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53681 . Optimization flags are not

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 added a comment. Yes, I am OK with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 added a comment. Greetings Sir, Thank you for accepting my revision. Please do commit it as I am contributing for the first time and I don't have commit access. Thanks & Regards Priyanshi Agarwal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 updated this revision to Diff 507961. ipriyanshi1708 added a comment. Fixed one more Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ipriyanshi1708 added reviewers: samtebbs, aaron.ballman. ipriyanshi1708 published this revision for review. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fixes

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

ipriyanshi1708 added a comment. Hi @AryanGodara , I am an Outreachy applicant. I was also working on this issue and also created a patch for this issue i.e., https://reviews.llvm.org/D146530 . Can we collaborate to solve this issue so that only one patch will be there for a issue as told by

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213078 , @aaron.ballman wrote: > In D146530#4213076 , > @ipriyanshi1708 wrote: > >> In D146530#4213045 , >> @aaron.ballman

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213045 , @aaron.ballman wrote: > This appears to be the same efforts that have been going on in > https://reviews.llvm.org/D146041. Can you coordinate with @AryanGodara so > that there's only one patch for

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, asb, fedor.sergeev, krytarowski. Herald added a reviewer: aaron.ballman. Herald added a project: All. ipriyanshi1708 updated this revision to Diff 506994. ipriyanshi1708 added a comment. ipriyanshi1708