[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf03e728007: [OpenMP] Add OpenMP offloading toolchain for AMDGPU (authored by Pushpinder Singh , committed by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal added inline comments. Comment at: clang/lib/Driver/Driver.cpp:755 + *this, TT, *HostTC, C.getInputArgs(), Action::OFK_OpenMP); +else if (TT.isAMDGCN()) + DeviceTC = JonChesterfield wrote: > Minor s

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 320740. pdhaliwal added a comment. - Use 0 for default -O option - Rename addOptLevelArgs to addLLCOptArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: cla

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal marked 3 inline comments as done. pdhaliwal added a comment. After addressing the review comments, I have internally verified changes on few simple test programs. They seem to be working fine. Comment at: clang/lib/Driver/Driver.cpp:3004 +} + } + //

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 320722. pdhaliwal added a comment. Addressed review comments. - Combined the toolchain creation logic for nvptx and amdgcn - Replaced -Xopenmp-target with -emit-llvm-bc inside AMDGPUOpenMP.cpp - Removed opt from pipeline Repository: rG LLVM Github Monor

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 318120. pdhaliwal added a comment. - Moved common methods of HIP and OpenMP to base ROCMToolChain - Removed unnecessary asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.or

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 317831. pdhaliwal added a comment. Fixed failing debian tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Dri

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317810. pdhaliwal added a comment. Herald added a subscriber: mgorny. > Won't this just prevent us from building clang due to the missing cmake > changes? It compiles and builds fine, however, I wasn't actually aware such sanity checking being present. It

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317553. pdhaliwal added a comment. Fix clang-tidy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, grokos, JonChesterfield, ronlieb, ABataev. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-comm

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

This revision was automatically updated to reflect the committed changes. Closed by commit rG4909cb1a0fe9: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, ABataev. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

pdhaliwal created this revision. pdhaliwal added reviewers: saiislam, ABataev, jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This was missed when default version was upgraded to 5.0 (part of D81098 )

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. In D79400#2121685 , @vsapsai wrote: > Seems like this change causes `ninja clean` to fail with the error > > > ninja: error: remove(include/llvm/Support): Directory not empty > > Full repro steps are > > > ninja install >

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal abandoned this revision. pdhaliwal marked an inline comment as done. pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389 - for (Arg *A : Args) { -DAL->append(A); + if (DeviceOffloadKind != Action::OFK_OpenMP) { +for (Arg *A :

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389 - for (Arg *A : Args) { -DAL->append(A); + if (DeviceOffloadKind != Action::OFK_OpenMP) { +for (Arg *A : Args) { arsenm wrote: > Needs a comment? I don't understand w

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal updated this revision to Diff 267870. pdhaliwal added a comment. Added lit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80996/new/ https://reviews.llvm.org/D80996 Files: clang/lib/Driver/ToolChains/HIP.cpp clang/test/Drive

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal created this revision. pdhaliwal added reviewers: yaxunl, msearles, sameerds. Herald added subscribers: cfe-commits, sstefan1, guansong, t-tye, tpr, dstuttard, wdng, kzhuravl. Herald added a reviewer: jdoerfert. Herald added a project: clang. When offloading kind is OFK_OpenMP, the host

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 267153. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Support/CMakeLists.txt Index: llvm/include/llvm/

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 267123. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Support/CMakeLists.txt Index: llvm/include/llvm/

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1945 + if (NOT touch_head_result EQUAL 0) +return() + endif() scott.linder wrote: > This seems to implement the behavior that when the log is not present a

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 266794. pdhaliwal marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Suppor

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 266172. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake Index: llvm/cmake/modules/AddLLVM.cmake

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. > 3. Another way is to gracefully handle the file write error, for which I > don't think there is a portable way. (which @scott.linder also suggested) I have found the portable way to do this. So cmake provides a command-line tool `touch` (doc

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. Hi, Sorry for late reply. > If that is not feasible for some reason, I would lean towards your option > (2), but I think more is needed in this patch to ensure the generation script > is always run, right? I think you are right. As of now, just removing the dependen

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. I understand that `.git/logs/HEAD` acts as a dependency for `vcs_revision_h` target. However, problem here is that cmake fails when it tries to create `.git/logs/HEAD` in read-only filesystem. I had following ideas for solving above issue, 1. Skip creating `.git/logs

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. Removing `find_first_existing_vc_file` makes a lot of sense, as since llvm has moved from svn to git, there is no need to have logic for svn dependency. Even the generation script is dependent on git executable only. I will keep my patch ready just in case other revie

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 262299. pdhaliwal added a comment. Added more context to diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: clang/lib/Basic/CMakeLists.txt lld/Common/CM

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. In D79400#2021255 , @scott.linder wrote: > Can you provide more context in the diff? Looking at the current `master` > locally it seems like this patch changes the behavior of the > `llvm_vcsrevision_h` target when `logs/HEAD`

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal created this revision. pdhaliwal added reviewers: chandlerc, beanz, pcc. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. The AddLLVM.cmake file exposes a function find_first_existing_vc_file which in case of git repository looks for .git/

<    1   2