[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6e6abd76cd3: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect (authored by qiongsiwu1). Repository: rG LLVM

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554842. qiongsiwu1 added a comment. Address code review. Thanks for the input @w2yehia ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files:

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/fprofile-update.c:17 +// AIX specific tests +// RUN: %if system-aix %{ %clang -### %s -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554523. qiongsiwu1 added a comment. Address code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/fprofile-update.c

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); This check here is copied from

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D157280 enabled `-fprofile-update` for

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Thanks for chiming in @phosek ! In D155290#4587438 , @phosek wrote: > Can we avoid the use of `pthread_atfork` and the dependency on pthreads? > Using pthreads inside the profile runtime implementation is problematic in >

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

This revision was automatically updated to reflect the committed changes. Closed by commit rG611ce24114aa: [PGO] Enable `-fprofile-update` for `-fprofile-generate` (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 550067. qiongsiwu1 added a comment. Fixing method parameter name format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. In D157280#4586078 , @MaskRay wrote: > Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4582825 , @MaskRay wrote: > Using `%p` should not magically change the behavior and I am unsure the > result is better for PGO. > If we decide to provide such a mode, it needs to be opt-in by adding a new >

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4574797 , @MaskRay wrote: > In D155290#4572965 , @qiongsiwu1 > wrote: > >> Ping for review. >> >> If there are no comments on whether we should add `-lpthread` for

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 548695. qiongsiwu1 added a comment. Update clang users manual. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. If there are no comments on whether we should add `-lpthread` for platforms other than AIX, I will land this patch soon, and let the official buildbots check for problems. If there are problems, I will let the bots run a bit (probably a day or so)

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, davidxl, w2yehia. Herald added subscribers: wlei, ormris, wenlei, hiraditya. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + if (NeedsProfileRT || needsGCovInstrumentation(Args)) +CmdArgs.push_back("-lpthreads"); + w2yehia wrote: > w2yehia wrote: >

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. We'd like to get this in to LLVM 17 if possible. Please let me know if there are comments/suggestions. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 542042. qiongsiwu1 added a comment. Updating a test to see if it passes pre-commit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 Files:

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 541005. qiongsiwu1 added a comment. Minor comment spelling fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:795 - /* When PNS >= OldPNS, the last one wins. */ - if (!FilenamePat || parseFilenamePattern(FilenamePat, CopyFilenamePat))

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 540998. qiongsiwu1 added a comment. Revise the tests to use llvm tools to dump profile data to check for profile validity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, davidxl, vsk, ellis. Herald added subscribers: wlei, Enna1, wenlei. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41447f6fdfe4: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 539544. qiongsiwu1 added a comment. Address test case review comments. Thanks so much @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4490581 , @MaskRay wrote: > We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you > know why it is not feasible for the places you want to check? I am checking/using

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b66b3417c02: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when… (authored by qiongsiwu1). Repository: rG LLVM

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. @MaskRay @w2yehia @shchenz could you let me know if there are further comments? I will land this patch if there are none. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 539105. qiongsiwu1 added a comment. Fixing inconsistent braces. Thanks for the feedback @hubert.reinterpretcast ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532256. qiongsiwu1 added a comment. Clean up code in `addLTOOptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532241. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() <<

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. In D152924#4426895 , @shchenz wrote: > Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does > not work as expected. Is this expected or by design(We can only

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532110. qiongsiwu1 added a comment. Revising the option processing logic to not pass in `-no-integrated-as=0`. Thanks @shchenz and @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 532099. qiongsiwu1 added a comment. Revert to the DataSections logic. It is better not to change that in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: >

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: >

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4421624 , @steven_wu wrote: > `lld` does not use LTOCodeGenerator. > > I am also not sure how disable integrated assembler suppose to work? Do you > have an end to end design for how to invoke assembler during

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, shchenz, Esme. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers:

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 530903. qiongsiwu1 added a comment. Revising the logic to pass `-data-sections=` to `libLTO`. We now pass `-data-sections=1` to `libLTO` by default unless it is explicitly turned off. Old behaviour: 1. Pass `-data-sections=1` if the target requires

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 529030. qiongsiwu1 added a comment. Address code review. Thanks @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 Files:

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Gentle ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, w2yehia. qiongsiwu1 added a project: clang. Herald added subscribers: kbarton, inglorion, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers:

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. In D151503#4381548 , @tra wrote: > @qiongsiwu1 : I've updated the patch. PTAL. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

qiongsiwu1 added a comment. Thanks for the patch! Recently we added the options `mxcoff-roptr` and `mno-xcoff-roptr` https://reviews.llvm.org/D144190 that fall into this the scope of this patch (e.g.

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > qiongsiwu1 wrote: > > > tra wrote: > > > > qiongsiwu1 wrote: > > > > > Do we need an install

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150597/new/

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham. qiongsiwu1 added a project: clang. Herald added a subscriber: nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. https://reviews.llvm.org/D150586 has landed and the problematic test case is removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Patch to remove the problematic test case. https://reviews.llvm.org/D150586 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 added a comment. I can revise the case and add it as a backend/llc test case if we would like to keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150586/new/ https://reviews.llvm.org/D150586

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham, MaskRay, cebowleratibm. qiongsiwu1 added a project: clang. Herald added subscribers: kristof.beyls, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. This patch is causing some buildbot failures. Specifically https://lab.llvm.org/buildbot/#/builders/139/builds/40652 https://lab.llvm.org/buildbot/#/builders/258/builds/810 I am looking into them. Please revert if this cannot wait. Thanks! Repository: rG LLVM

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9715af434579: [AIX][clang] Storage Locations for Constant Pointers (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Pre-commit CI x64 Debian is failing https://buildkite.com/llvm-project/premerge-checks/builds/152189 because the build machine's cmake version is too old. I am landing this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 522132. qiongsiwu1 added a comment. Thanks so much @hubert.reinterpretcast !! The comments are addressed. I will land the patch when the pre-commit CI finishes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 520375. qiongsiwu1 added a comment. Rebase. Ping for review @hubert.reinterpretcast . Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. @hubert.reinterpretcast please let me know if there are comments/suggestions! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. Thanks for the fix Zarko! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148960/new/ https://reviews.llvm.org/D148960

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148177/new/ https://reviews.llvm.org/D148177

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Specifically, the option is renamed to `-mxcoff-roptr` and `-mno-xcoff-roptr` to indicate that this option only affects the `XCOFF` binary format, so it is expected to not affect `ELF` or other formats. Thanks! Repository: rG LLVM Github

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > > This needs the backend

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" hubert.reinterpretcast wrote: >

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509367. qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. Fix the LTO data sections check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509360. qiongsiwu1 added a comment. Moving the `-shared` check to the AIX linker and modifying the tests so we test pure linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509342. qiongsiwu1 added a comment. Rebase and address feedback other than test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. The new option is renamed to `-mxcoff-roptr` to avoid confusions if we are using it during a pure linking job on non-AIX platforms. The option name now implies that it applies to XCOFF only, so silently ignoring the option on other platforms is not that serious a

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509118. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Renaming the `-mroptr` option to `-mxcoff-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509091. qiongsiwu1 added a comment. Simplify LTO data section error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509057. qiongsiwu1 added a comment. Fixing LTO data sections error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716 +if (!Args.hasFlag(options::OPT_fdata_sections, + options::OPT_fno_data_sections, UseSeparateSections) && +

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 507752. qiongsiwu1 added a comment. Address code review. Thanks for your comments/suggestions @MaskRay !! - Fixing comments. - Using `--target=` in tests. - Reducing number of RUN lines in tests. @hubert.reinterpretcast I ended up having a mix of tests

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:21 +// RUN: FileCheck %s --check-prefix=ROPTR +// RUN: %clang -### -target powerpc64-ibm-aix-xcoff -S -mroptr %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=ROPTR MaskRay

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = hubert.reinterpretcast wrote: > This only checks for `-m[no-]roptr`

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 505181. qiongsiwu1 added a comment. Thanks for the comments @stephenpeckham ! This update addresses all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503946. qiongsiwu1 added a comment. Adding LTO error check tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503944. qiongsiwu1 added a comment. Adding tests to check that the default behaviour is identical with `-mno-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503941. qiongsiwu1 added a comment. Fixing release note. Adding pure linking tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503934. qiongsiwu1 added a comment. Adding logic to pass `mroptr` to the backend during LTO codegen. Error check is not ideal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503796. qiongsiwu1 added a comment. Rename the `ReadOnlyPointers` option in the source to `XCOFFReadOnlyPointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503440. qiongsiwu1 added a comment. Update `-mroptr` cc1 option help text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503437. qiongsiwu1 added a comment. Addressing review comments - fixing typos, and updating the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

  1   2   >