[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra abandoned this revision. raghavendhra added a comment. setPropertyExecutionMode function is no longer present / used in clang because of a change in https://reviews.llvm.org/D142569 So abandoning this patch to migrate that function into OMPIRBuilder. Repository: rG LLVM Github

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 544219. raghavendhra added a comment. Remove llvm:: from function setPropertyExecutionMode(). Rebasing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 543696. raghavendhra added a comment. Addressed review comments by making setPropertyExecutionMode() to return a Global Value instead of void. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra marked 2 inline comments as done. raghavendhra added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4917 + LLVMCompilerUsed.emplace_back(GVMode); +} + jdoerfert wrote: > No `llvm::` here. Sorry, Can you please elaborate

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542999. raghavendhra added a comment. Addressed JP's review comments and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files:

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra marked 2 inline comments as done. raghavendhra added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4914 + GVMode->setVisibility(llvm::GlobalVariable::ProtectedVisibility); + assert(!GVMode->isDeclaration() && + "Only globals with

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542787. raghavendhra added a comment. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542786. raghavendhra added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files:

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra created this revision. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. raghavendhra requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

raghavendhra accepted this revision. raghavendhra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. Ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.llvm.org/D131915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra updated this revision to Diff 468448. raghavendhra added a comment. Herald added projects: clang, LLVM, Flang. Herald added subscribers: llvm-commits, cfe-commits. Seperated map_operands with map-type and map-type-modifier as enum attributes. Repository: rG LLVM Github Monorepo

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. In D105255#3707088 , @abidmalikwaterloo wrote: > In D105255#3706602 , @raghavendhra > wrote: > >> @abidmalikwaterloo Can you please check your last patch pushed for review? >>

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. @abidmalikwaterloo Can you please check your last patch pushed for review? https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can not apply your patch something to do with usage of diff --update ? Can you please check? Repository: rG LLVM

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. @abidmalikwaterloo ninja check-mlir is failing with your most upto date patch. Can you please double check? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

raghavendhra accepted this revision. raghavendhra added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 ___ cfe-commits mailing list

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

raghavendhra added a reviewer: raghavendhra. raghavendhra added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 ___ cfe-commits mailing list