[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652872 , @AlexVlx wrote: > In D155775#4652851 , @ro wrote: > >> In D155775#4652785 , @AlexVlx >> wrote: >> >>> In D155775#4652780

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652785 , @AlexVlx wrote: > In D155775#4652780 , @dyung wrote: > >> >> At this point, would it be easier to add a REQUIRES line for the target the >> test should support rather

[PATCH] D159222: [clang] Consistently use isOSSolaris()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc7b753a5cd: [clang] Consistently use isOSSolaris() (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85309: [Driver] Support GNU ld on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd39a9e3b4d4a: [Driver] Support GNU ld on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D85309?vs=554946=555463#toc

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ro marked an inline comment as done. Closed by commit rGb1b1f364d633: [Driver] Dont default to DWARF 2 on Solaris (authored by ro). Changed prior to commit:

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/CodeGen/dwarf-version.c:7 // RUN: %clang -target x86_64-linux-gnu -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +// RUN: %clang -target i386-pc-solaris -g -S -emit-llvm -o

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently defaults to DWARF 2 on Solaris. This dates back to LLVM 3.8.0. I suspect

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59 // RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \ -// RUN: --target=x86_64-pc-windows-msvc \ +// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \ // RUN: -nogpuinc

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554946. ro marked an inline comment as done. ro added a comment. Move `isLinkerGnuLd` to `Solaris.{h,cpp}` and into `solaris` namespace to make it unambigously clear where to use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305 +bool tools::isLinkerGnuLd(const ToolChain , const ArgList ) { + // Only used if targetting Solaris. MaskRay wrote: > I suppose that this

[PATCH] D159222: [clang] Consistently use isOSSolaris()

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. While looking over the Solaris GNU ld patch (D85309 ),

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554711. ro retitled this revision from "[WIP][clang][Driver] Support GNU ld on Solaris" to "[Driver] Support GNU ld on Solaris". ro added a comment. Herald added subscribers: llvm-commits, Sanitizers, Enna1, ormris. Herald added a reviewer: sscalpone. Herald added

[PATCH] D158955: [Driver] Improve legibility of ld -z options on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG779353e576ea: [Driver] Improve legibility of ld -z options on Solaris (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158959: [clang-tidy] Disambiguate calls to log

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03dff0d4acaf: [clang-tidy] Disambiguate calls to log (authored by

[PATCH] D158959: [clang-tidy] Disambiguate calls to log

ro created this revision. ro added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, pengfei, zzheng, fedor.sergeev, xazax.hun, jyknight. Herald added a reviewer: njames93. Herald added a project: All. ro requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D158955: [Driver] Improve legibility of ld -z options on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, fedor.sergeev, emaste. Herald added a project: All. ro requested review of this revision. Following the lead of the Linux code, this patch passes the `ld -z` options as two

[PATCH] D158206: [Driver] Add PIE support on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ro marked an inline comment as done. Closed by commit rG62945bb81116: [Driver] Add PIE support on Solaris (authored by ro). Changed prior to commit:

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:136 +const char *crtbegin = nullptr; +if (Args.hasArg(options::OPT_shared) || IsPIE) + crtbegin = "crtbeginS.o"; MaskRay wrote: > Q:

[PATCH] D158207: [Driver] Link with crtbeginS.o/crtendS.o on Solaris

ro abandoned this revision. ro added a comment. Merged into D158206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158207/new/ https://reviews.llvm.org/D158207 ___

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro updated this revision to Diff 551539. ro marked 2 inline comments as done. ro edited the summary of this revision. ro added a comment. Herald added a subscriber: jrtc27. - Merged D158207 . - Incorporate review comments. Repository: rG LLVM Github Monorepo

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro marked 2 inline comments as done. ro added a comment. In D158206#4596471 , @MaskRay wrote: >> I'll submit a follow-up patch to make use of crtbeginS.o and crtendS.o >> shortly. > > I think this patch should make this change, so that the change is

[PATCH] D158207: [Driver] Link with crtbeginS.o/crtendS.o on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` doesn't currently use `crtbeginS.o` and `crtendS.o` on Solaris with

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently lacks PIE support on Solaris. This patch fixes this. Tested on

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae84ad15efd7: [Driver] Select newest GCC installation on Solaris (authored by ro). Changed prior to commit:

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 550226. ro marked an inline comment as done. ro added a comment. Herald added a subscriber: ormris. - Simplify `SolarisPrefixes` sorting. - Switch to unitest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro marked an inline comment as done. ro added a comment. In D157275#4585184 , @MaskRay wrote: > Thanks for the update. Regarding testing, it seems that unittests will be > more convenience than creating so many placeholder files in `Inputs/`. >

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 549925. ro added a comment. Herald added a subscriber: mgrang. Updated based on discussions in Issue #53709: - Sort Solaris GCC prefixes in reverse version order so the latest version is picked. - Update testcase to match. Tested on `amd64-pc-solaris2.11` and

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arrive in

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. As described in Issue #53709

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43dfe0f08eca: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro added inline comments. Comment at: clang/test/Driver/lit.local.cfg:23 ".yaml", +".test", ] MaskRay wrote: > Instead of adding a new extension, you can just name your test `.c`? I could, but went for `.test` instead because the `clang` invocations

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Since GCC 11, the bundled Solaris/SPARC GCC uses the `sparcv8plus` subdirectory

[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

ro added a comment. It seems this patch broke the Solaris/amd64 buildbot : FAIL: Clang::cfi-check-fail.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155736/new/

[PATCH] D156861: [Driver] Remove references to Solaris 12

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0dc887d7ed2: [Driver] Remove references to Solaris 12 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156861/new/

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro added a comment. In D156861#4555280 , @MaskRay wrote: > While you are modifying the lines `static const char ...[]` should look > better than `static const char *const SolarisX86Triples[]` While this would certainly avoid the ugly formatting, it

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4554884 , @MaskRay wrote: > In D156363#4554812 , @jhuber6 wrote: > >> >> Probably because we're not specifying the `--target=` I'll add that in my >> fix for AMDGPU I'm working

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4553043 , @ro wrote: > It seems the latest commit of this patch has (re-)introduced two failures on > the Solaris/amd64 buildbot > : > > FAIL:

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. It seems the latest commit of this patch has (re-)introduced two failures on the Solaris/amd64 buildbot : FAIL: Clang::clang_f_opts.c FAIL: Clang::lto.c I cannot really make sense of that. Repository: rG

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. Solaris 12 was re-christened as Solaris 11.4 while still in beta, so all references are long obsolete

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b5149aa442e: [Driver] Link shared asan runtime lib with -z now on Solaris/x86 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro updated this revision to Diff 544660. ro added a comment. Add testcases. Re-tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm.org/D156325 Files:

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro added a comment. In D156325#4537237 , @MaskRay wrote: > This needs a clang/test/Driver test. Indeed, I forgot. Added now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro created this revision. ro added reviewers: vitalybuka, MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. As detailed in Issue #64126, several asan tests `FAIL` due to a cycle in `AsanInitInternal`.

[PATCH] D141596: [Driver] Add crtfastmath.o on Solaris if appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c4a70f8f6f3: [Driver] Add crtfastmath.o on Solaris if appropriate (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141596/new/

[PATCH] D141596: [Driver] Add crtfastmath.o on Solaris if appropriate

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `Flang :: Driver/fast_math.f90` `FAIL`s on Solaris because `crtfastmath.o` is missing

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. In D129156#3949194 , @awarzynski wrote: > > Sorry that you are hitting this - things like this happen, sadly. I think > that the easiest to resolve it would be to tweak the expected error so that > it works on Solaris as well

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. This introduced a new failure on Solaris: FAIL: Flang :: Driver/pass-plugin-not-found.f90 Running the failing command manually shows: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

[PATCH] D133405: [Linux] Hack around Linux/sparc

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e56821bac02: [Linux] Hack around Linux/sparc bits/stdio-ldbl.h (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro updated this revision to Diff 459017. ro added a comment. Add comment, tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D133405 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3779190 , @MaskRay wrote: > So, sparc64 gcc does seem to define the macro by default. (I am using Debian > testing and can't tell whether it's distro setting or upstream default) > ¯\_(ツ)_/¯ > > % sparc64-linux-gnu-gcc

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3776096 , @MaskRay wrote: > It's not a compiler's job to define this workaround... Yes and no: GCC successfully does it via its `fixincludes` mechanism. Unfortunately, LLVM doesn't provide something similar and doesn't

[PATCH] D133407: [Driver] Support non-canonical triples with new runtime lib layout

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: StephenFan, abidh, jrtc27, fedor.sergeev, kristof.beyls, jyknight. Herald added a project: All. ro requested review of this revision. This is the companion patch to D133406

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro created this revision. ro added reviewers: glaubitz, MaskRay. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've been using this hack to

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3731653 , @glaubitz wrote: > In D130688#3731619 , @ro wrote: > >> In D130688#3731611 , @glaubitz >> wrote: >> >>> >> >> >> >>> Yeah,

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3731611 , @glaubitz wrote: > > Yeah, someone from the LEON community should comment whether they would be OK > to default to V9 on all Linux targets. I don't really want to omit Gentoo > here which still support Linux

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. It's almost three weeks since the last comments. Any suggestions on how to proceed with this patch? Given that the original issue (atomics not inlined with `-m32`) is now worked around by always linking with `--as-needed -latomic --no-as-needed`, the patch is no longer

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro abandoned this revision. ro added a comment. Nick Clifton just commited a fix both to the binutils 2.39 branch and master. So the workaround certainly isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3686512 , @MaskRay wrote: > Making the behavior different for different Linux distributions is not great, > but if it matches the practice, I think it is fine. It's the best we can do in `clang`, I fear, due to the

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3714884ae4: [clang][Driver] Handle SPARC -mcpu=native etc. (authored by ro). Changed prior to commit:

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1897bbd0e3: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux (authored by ro). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:139 + if (Triple.getArch() == llvm::Triple::sparc && + (Triple.isOSSolaris() || Distro(D.getVFS(), Triple).IsDebian())) return "v9"; glaubitz wrote: > Can we do it

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro added a comment. In D130566#3682923 , @dblaikie wrote: >> This is all extremely weird, but until the error shows up again, I'll put >> this patch on hold (not yet abandoning since there seems to be no way to >> unabandon if necessary). > > You can

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

ro updated this revision to Diff 448290. ro marked 3 inline comments as done. ro edited the summary of this revision. ro added a comment. - Incorporate review comments. - Add testcases. - Reject `-march`, matching GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro created this revision. ro added reviewers: glaubitz, MaskRay, jrtc27. ro added a project: clang. Herald added subscribers: StephenFan, pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. This is the Debian/sparc64 equivalent of D86621

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

ro updated this revision to Diff 448253. ro marked 2 inline comments as done. ro added a comment. - Switch to `--push-state`/`--pop-state`. - Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130569/new/ https://reviews.llvm.org/D130569

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

ro marked 2 inline comments as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:634 + // LLVM support for atomics on 32-bit SPARC V8+ is incomplete, so + // forcibly link with libatomic as a workaround. MaskRay wrote: >

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro added a comment. In D130566#3681129 , @dblaikie wrote: >> During a build on Debian 11/sparc64, several binaries fail to link with >> >> /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: >> 0x23 > > What's the linker doing

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro added a comment. In D130566#3679480 , @glaubitz wrote: > Interesting and thanks for catching this! How did you discover this issue? Is > there any particular program that fails to build due to this issue? Sure: many programs fail to link during

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux [clang-linux-sparc-libatomic.patch, submitted 2022-07-26]

ro created this revision. ro added reviewers: glaubitz, jrtc27, MaskRay, efriedma. ro added a project: clang. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. This is the Linux/sparc64 equivalent to D118021

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro created this revision. ro added reviewers: glaubitz, MaskRay. ro added a project: clang. Herald added subscribers: jsji, StephenFan, pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. During a build on Debian 11/sparc64, several binaries fail

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

ro added a comment. In D130273#3670623 , @MaskRay wrote: > I notice that in gcc, -march/-mtune/-mcpu are handled in gcc/config/* and > every port may have somewhat different behaviors. E.g. x86 and aarch64 are > different (and I suspect x86 has the

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

ro created this revision. ro added reviewers: MaskRay, glaubitz, jrtc27. ro added a project: clang. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. To make use of SPARC support in `getHostCPUName` as implemented by

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro abandoned this revision. ro added a comment. Superceded by D119829 and D120048 . If absolutely necessary, D120059 could be revived if Illumos cannot implement `dlpi_tls_modid`.

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fc966d2e41: [Driver] Support Solaris/amd64 GetTls (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 410083. ro added a comment. Testcase formatting improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files: clang/lib/Driver/ToolChains/Solaris.cpp

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6 +/// Check sparc-sun-solaris2.11, 32bit +// RUN: %clang %s -### 2>&1 \ +// RUN: --target=sparc-sun-solaris2.11 \ MaskRay wrote: > The first line is now shorter. You can move

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 409881. ro marked 2 inline comments as done. ro added a comment. Test fixes as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files:

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro marked 2 inline comments as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we use sysroot to make these tests

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3329375 , @ro wrote: > > As an experiment, I've tried to use `GetStaticTlsBoundary` instead. It does > indeed work on recent Solaris 11.4 and the resulting patch is at D120048 > . I'm

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3322312 , @ro wrote: > In D91605#3321554 , @MaskRay wrote: > >> `GetTls` is about the static TLS block size. It consists of the main >> executable's TLS, and initially loaded shared

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3321556 , @MaskRay wrote: > The Clang driver change should be in a separate patch with clang/test/Driver > tests. Done now: D119829 . Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. ro requested review of this revision. This is the driver part of D91605 , a workaround to allow direct calls to `__tls_get_addr`

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3321554 , @MaskRay wrote: > `GetTls` is about the static TLS block size. It consists of the main > executable's TLS, and initially loaded shared objects' TLS, `struct pthread`, > and padding. > Solaris should be able to

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. @vitalybuka , @MaskRay could I persuade you to review the revision version which should be much less controversial and completely Solaris-specific? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91605/new/

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro updated this revision to Diff 408389. ro added a subscriber: nikic. ro added a comment. Since the build-time check for the `ld -z relax=transtls` option was met with massive resistance and was only necessary for Illumos anyway, this revision just uses it unconditionally. Tested on

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6afa9e6b0d9: [Driver] Use libatomic for 32-bit SPARC atomics support (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:46 // CHECK-LD-SPARC64-SAME: "-L[[SYSROOT]]/usr/lib/sparcv9" +// CHECK-LD-SPARC64-NOT: "-zignore" +// CHECK-LD-SPARC64-NOT: "-latomic" ro wrote: > MaskRay wrote: > > Such NOT patterns are

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407455. ro marked an inline comment as done. ro added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 Files:

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:20 // CHECK-LD-SPARC32-SAME: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD-SPARC32-SAME: "-zignore" +// CHECK-LD-SPARC32-SAME: "-latomic" MaskRay wrote: > If they

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407120. ro added a comment. Add tests in `solaris-ld.c`. Spot-checked by running the single test with `llvm-lit` on `sparcv9-sun-solaris2.11`, `amd64-solaris2.11`, and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. In D118021#3307079 , @MaskRay wrote: > This needs some tests, otherwise there is a risk that others may break your > changes when refactoring driver code. I thought it would be enough that any breakage there would cause a large

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping^2. It would be great if this could be reviewed/commited soon: it fixes hundreds of testsuite failures, so I'd like to get it into LLVM 14. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefdd0a29b7eb: [clang][Sparc] Fix __builtin_extract_return_addr etc. (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro updated this revision to Diff 404939. ro added a comment. Herald added a subscriber: jrtc27. - Use `CreateGEP` - Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 Files:

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3285825 , @efriedma wrote: > In D91607#3283350 , @ro wrote: > >> In D91607#3280808 , @efriedma wrote: >> >>> Testcase? >> >> I thought the 3

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3280808 , @efriedma wrote: > Testcase? I thought the 3 testcases adjusted in D91608 to use `__builtin_extract_return_addr` and fixed by this patch were enough. Otherwise, should I just

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. Ping. This hasn't been reviewed in more than a year and is still required for D91608 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403607. ro marked an inline comment as done. ro added a comment. Omit `sanitizer_atomic_clang.h` part, belongs to D118021 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403604. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. - Clarify comment. - Use `__ATOMIC_SEQ_CST`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/

  1   2   3   >