[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

Rajveer100 wrote: Thanks for the approval, could you land this for me? https://github.com/llvm/llvm-project/pull/91119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

Rajveer100 wrote: I am not sure what causes the build failure here. https://github.com/llvm/llvm-project/pull/91119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/91119 >From 78a2afab67eef9a8a05ced89df0aadb56a2ec2b8 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 5 May 2024 18:05:00 +0530 Subject: [PATCH] [clang][analyzer] Check for label location bindings in

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/91119 >From 5c7712d1841664a9424b98abdd22d7967d00913f Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 5 May 2024 18:05:00 +0530 Subject: [PATCH] [clang][analyzer] Check for label location bindings in

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

Rajveer100 wrote: Should we introduce a new Kind in `DerefKind`? https://github.com/llvm/llvm-project/pull/91119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

Rajveer100 wrote: @steakhal https://github.com/llvm/llvm-project/pull/91119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/91119 >From dcc23f7751ba2ceb281a9b027907dbf849ba65c6 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 5 May 2024 18:05:00 +0530 Subject: [PATCH] [clang][analyzer] Check for label location bindings in

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/91119 >From c1d62262d2545e4999f08f2ba28a12c71789926f Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 5 May 2024 18:05:00 +0530 Subject: [PATCH] [clang][analyzer] Check for label location bindings in

[clang] [clang][analyzer] Check for label location bindings in `DereferenceChecker` (PR #91119)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/91119 Resolves #89264 Values should not be stored in addresses of labels, this throws a fatal error when this happens. >From 36b1ee31d8d740cdbee6a1787d7ef81d6abeb8ad Mon Sep 17 00:00:00 2001 From: Rajveer Date:

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

Rajveer100 wrote: @shafik Could you land this for me? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From caabd75b0223408ad62baff3d9d6d7f7d78c4c7f Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From f2a9a4137d39dd9f3896c64f41d5700774ec9204 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

Rajveer100 wrote: I have removed this entirely, although it still may not be optimal, it did reduce few more test failures: ```C++ Constructor->getTemplateSpecializationKind() != TSK_ImplicitInstantiation ``` Any particular suggestions apart from updating the tests?

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/81251 >From bf51e9dfb160ec32b3f3a7d052c1da24f06a Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 9 Feb 2024 19:20:39 +0530 Subject: [PATCH] [clang] Clang should detect illegal copy constructor with template

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/81251 >From 4bb6d4d1b5a813bc3a60c1bc6aab97ea863bd261 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 9 Feb 2024 19:20:39 +0530 Subject: [PATCH] [clang] Clang should detect illegal copy constructor with template

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/81251 >From 5c5a91dbdf7239025d7bc5961afc0f375d3b1627 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 9 Feb 2024 19:20:39 +0530 Subject: [PATCH] [clang] Clang should detect illegal copy constructor with template

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/81251 >From 7c58bd55bdd5c9a9cc838fec35e957f7952b2b52 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 9 Feb 2024 19:20:39 +0530 Subject: [PATCH] [clang] Clang should detect illegal copy constructor with template

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/81251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From a27a6858e44047bc0ff55485355932259e2f9358 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

Rajveer100 wrote: Considering the PR sounds good to you, yes it would be great to have it merged. https://github.com/llvm/llvm-project/pull/82251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

Rajveer100 wrote: > @Rajveer100 you need us to merge that for you? I am not sure what you meant by this? https://github.com/llvm/llvm-project/pull/82251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/82251 >From 05dbfac2043c22bdb73d5f09221421209bfe1f22 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Mon, 19 Feb 2024 19:29:48 +0530 Subject: [PATCH] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

Rajveer100 wrote: @cor3ntin I have mistakenly added a merge commit, let me fix that. https://github.com/llvm/llvm-project/pull/82251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/82251 >From 05dbfac2043c22bdb73d5f09221421209bfe1f22 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Mon, 19 Feb 2024 19:29:48 +0530 Subject: [PATCH] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/82251 >From 05dbfac2043c22bdb73d5f09221421209bfe1f22 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Mon, 19 Feb 2024 19:29:48 +0530 Subject: [PATCH] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/82251 >From 8fd5e1bb55a778c778bc8829199318661e4d4573 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Mon, 19 Feb 2024 19:29:48 +0530 Subject: [PATCH] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and

[clang] [clang] [SemaCXX] Disallow deducing "this" on operator `new` and `delete` (PR #82251)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/82251 Resolves Issue #82249 As described in the issue, any deallocation function for a `class X` is a static member (even if not explicitly declared static). >From 3ad4e85144739e16be13a4d5641b24d1a7e5b00b Mon Sep

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @shafik Could you let me know if there are any more changes that are needed here? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

Rajveer100 wrote: @cor3ntin @shafik I am not quite sure if this is the intended fix, also I will check the few other failing tests once the _CI_ completes its job. https://github.com/llvm/llvm-project/pull/81251 ___ cfe-commits mailing list

[clang] [clang] Clang should detect illegal copy constructor with template class as its parameter (PR #81251)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/81251 Resolves Issue #80963 As described in the snippet of the issue, `A` is correctly detected while it fails to reject in other cases. >From c931dd64e63817619c6b7f649828580b3fb2e6ec Mon Sep 17 00:00:00 2001

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From 864bd0ef7b6bbb0bc1502ef5884ae3c261d3b156 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @cor3ntin Could you help me in closing this? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From 1923c212515033dbb92f09c6d11cd2b679261459 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @cor3ntin Could you describe the format of the `release note` briefly so I can `amend` my `commit` accordingly? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: Why are `clang-format` changes showing up for changes not committed by me? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify +// RUN: %clang_cc1 -fsyntax-only -std=c++23 %s -verify + +// expected-no-diagnostics + +struct A {}; +using CA = const A; + +struct S1 : CA { Rajveer100 wrote: In the `godbolt` links, the

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From efea75d1ae4a1da80b16b3e743a15a82b5f8d971 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/70594 Resolves Issue #35603 This change makes the `assertion` less strict in `debug` builds by stripping qualifiers from the base class and ignoring them. I hope `weakened` assertions don't affect other cases