This revision was automatically updated to reflect the committed changes.
Closed by commit rC340468: [ASTImporter] Add test for
ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt (authored by teemperor, committed
by ).
Repository:
rC Clang
https://reviews.llvm.org/D51121
Files:
test/Import/objc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340467: [ASTImporter] Actually test ArrayInitLoopExpr in the
array-init-loop-expr test. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340466: [ASTImporter] Remove duplicated and dead
CXXNamedCastExpr handling code. (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51110?vs=161994&id=162084#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340465: [ASTImporter] Add test for ObjCTypeParamDecl
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51059
Files:
test/Import/objc-param-decl/Inputs/S.m
test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340464: [ASTImporter] Add test for SwitchStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51056?vs=161798&id=16208
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340463: [ASTImporter] Add test for ObjCAutoreleasePoolStmt
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51123
Files:
test/Import/objc-autoreleasepool/Inputs
teemperor added inline comments.
Comment at: test/Import/objc-try-catch/Inputs/F.m:9
+Exception *e;
+@throw e;
+ }
We usually should create a expression here, but the ObjCMessageExpr isn't
implemented yet, so this bit weird code has to do the job.
Rep
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51123
Files:
test/Import/objc-autoreleasepool/Inputs/F.m
test/Import/objc-autoreleasepool/test.m
Index: test/Import/objc-aut
teemperor added a comment.
Turns out, the clang-import-test actually allows passing clang args via `-Xcc`,
so I probably will revert the lang options changes I did in the previous
commits.
Repository:
rC Clang
https://reviews.llvm.org/D51121
__
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51121
Files:
test/Import/objc-try-catch/Inputs/F.m
test/Import/objc-try-catch/test.m
Index: test/Import/objc-try-catch/test.
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
The `array-init-loop-expr` test is currently not testing the importing of
ArrayInitLoopExprs.
This is because we import the `S` struct into the `test.cpp` context
and only do a co
teemperor added a comment.
See
http://lab.llvm.org:8080/coverage/coverage-reports/clang/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/AST/ASTImporter.cpp.html#L6044
for the test coverage entry.
Repository:
rC Clang
https://reviews.llvm.org/D51110
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
`CXXNamedCastExpr` importing is already handled in the respective
`VisitCXXNamedCastExpr` method.
So this code here can never be reached under normal circumstances and we might
as
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51056
Files:
test/Import/switch-stmt/Inputs/F.cpp
test/Import/switch-stmt/test.cpp
Index: test/Import/switch-stmt/test.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340304: [ASTImporter] Add test for CXXNoexceptExpr (authored
by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50737
Files:
test/Import/cxx-noexcept-expr/Inputs/F.cpp
te
teemperor added inline comments.
Comment at: test/Import/cxx-noexcept-expr/test.cpp:1
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s |
FileCheck %s
+
hiraditya wrote:
> Can we add a line/comment to explain what this test does? Same f
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340297: [ASTImporter] Add test for CXXForRangeStmt (authored
by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51001
Files:
test/Import/cxx-for-range/Inputs/F.cpp
test/I
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340220: [ASTImporter] Add test for C++'s try/catch
statements. (authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50978
Files:
test/Import/cxx-try-catch/Inputs/F.
teemperor updated this revision to Diff 161580.
teemperor added a comment.
- Clarified that the Exception options in LangOpts are not related to the
dynamic_cast support by moving them above the comment (Thanks Aleksei!)
https://reviews.llvm.org/D50978
Files:
test/Import/cxx-try-catch/Inputs
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51001
Files:
test/Import/cxx-for-range/Inputs/F.cpp
test/Import/cxx-for-range/test.cpp
Index: test/Import/cxx-for-range/test
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Also enable exceptions in clang-import-test so that we can parse the test files.
Repository:
rC Clang
https://reviews.llvm.org/D50978
Files:
test/Import/cxx-try-catch/Inputs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340182: [ASTImporter] Add test for C++ casts and fix broken
const_cast importing. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
teemperor updated this revision to Diff 161496.
teemperor added a comment.
- Added comment why we enable RTTI.
https://reviews.llvm.org/D50932
Files:
lib/AST/ASTImporter.cpp
test/Import/cxx-casts/Inputs/F.cpp
test/Import/cxx-casts/test.cpp
tools/clang-import-test/clang-import-test.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340180: [ASTImporter] Test for importing condition variable
from a ForStmt (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50928?vs=161342&id=161493#toc
Repos
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50932
Files:
lib/AST/ASTImporter.cpp
test/Import/cxx-casts/Inputs/F.cpp
test/Import/cxx-casts/test.cpp
tools/clang-import-test/clang-i
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50928
Files:
test/Import/for-stmt/Inputs/F.cpp
test/Import/for-stmt/test.cpp
Index: test/Import/for-stmt/test.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339919: [ASTImporter] Add test for member pointer types.
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50792?vs=1608
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339918: [ASTImporter] Add test for importing
CompoundAssignOperators (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339917: [ASTImporter] Add test for DoStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50810?vs=160918&id=161075#to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339916: [ASTImporter] Add test for WhileStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50811?vs=160919&id=161074
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339915: [ASTImporter] Add test for IndirectGotoStmt
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50813
Files:
test/Import/indirect-goto/Inputs/F.cpp
test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339839: [ASTImporter] Add test for CXXDefaultInitExpr
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50732?vs=160678&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339838: [ASTImporter] Add test for CXXScalarValueInit
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50735?vs=160685&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339837: [ASTImporter] Add test for ForStmt and ContinueStmt
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50812?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339831: [ASTImporter] Add test for ArrayInitLoopExpr
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50733?vs=160682&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339830: [ASTImporter] Add test for ExprWithCleanups
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50731
Files:
test/Import/expr-with-cleanups/Inputs/S.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339825: [ASTImporter] Add test for IfStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50796?vs=160876&id=160930#to
teemperor added a comment.
As a side note: It seems this test case actually reveals that we don't import
the body of Foo's destructor?
test/Import/cxx-default-init-expr/Inputs/S.cpp:1:8: inline function
'Foo::~Foo' is not defined
struct Foo {
^
test/Import/cxx-default-init-expr/I
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50813
Files:
test/Import/indirect-goto/Inputs/F.cpp
test/Import/indirect-goto/test.cpp
Index: test/Import/indirect-goto/test.cpp
===
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50812
Files:
test/Import/for-stmt/Inputs/F.cpp
test/Import/for-stmt/test.cpp
Index: test/Import/for-stmt/test.cpp
==
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50811
Files:
test/Import/while-stmt/Inputs/F.cpp
test/Import/while-stmt/test.cpp
Index: test/Import/while-stmt/test.cpp
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50810
Files:
test/Import/do-stmt/Inputs/F.cpp
test/Import/do-stmt/test.cpp
Index: test/Import/do-stmt/test.cpp
=
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50796
Files:
test/Import/if-stmt/Inputs/F.cpp
test/Import/if-stmt/test.cpp
Index: test/Import/if-stmt/test.cpp
=
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50793
Files:
test/Import/compound-assign-op/Inputs/F.cpp
test/Import/compound-assign-op/test.cpp
Index: test/Import/compound-assign-op/t
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50792
Files:
test/Import/cxx-member-pointers/Inputs/S.cpp
test/Import/cxx-member-pointers/test.cpp
Index: test/Import/cxx-member-pointer
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50737
Files:
test/Import/cxx-noexcept-expr/Inputs/F.cpp
test/Import/cxx-noexcept-expr/test.cpp
Index: test/Import/cxx-noexcept-expr/test
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50735
Files:
test/Import/cxx-scalar-value-init/Inputs/S.cpp
test/Import/cxx-scalar-value-init/test.cpp
Index: test/Import/cxx-scalar-val
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50733
Files:
test/Import/array-init-loop-expr/Inputs/S.cpp
test/Import/array-init-loop-expr/test.cpp
Index: test/Import/array-init-loop-
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50732
Files:
test/Import/cxx-default-init-expr/Inputs/S.cpp
test/Import/cxx-default-init-expr/test.cpp
Index: test/Import/cxx-default-in
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50731
Files:
test/Import/expr-with-cleanups/Inputs/S.cpp
test/Import/expr-with-cleanups/test.cpp
Index: test/Import/expr-with-cleanups/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339506: [ASTImporter] Added test case for opaque enums
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50550?vs=160057
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339505: [ASTImporter] Added test case for CXXConversionDecl
importing (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50552
Files:
test/Import/conversion-decl/Inputs/F.cpp
test/Import/conversion-decl/test.cpp
Index: test/Import/conversion-decl/test.cpp
=
teemperor updated this revision to Diff 160057.
teemperor added a comment.
- Removed broken FileCheck directive
https://reviews.llvm.org/D50550
Files:
test/Import/enum/Inputs/S.cpp
test/Import/enum/test.cpp
Index: test/Import/enum/test.cpp
=
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50550
Files:
test/Import/enum/Inputs/S.cpp
test/Import/enum/test.cpp
Index: test/Import/enum/test.cpp
==
teemperor added a comment.
I don't think Clang/LLVM use `[[deprecated]]` anywhere. Just change the API and
people have to migrate their code.
Repository:
rC Clang
https://reviews.llvm.org/D50352
___
cfe-commits mailing list
cfe-commits@lists.llv
teemperor resigned from this revision.
teemperor added a comment.
This revision now requires review to proceed.
Woops, I wanted to resign actually (and not accept this).
Repository:
rC Clang
https://reviews.llvm.org/D50347
___
cfe-commits mailing
teemperor planned changes to this revision.
teemperor marked an inline comment as done.
teemperor added a comment.
(Just marking this as "Plan changes" because otherwise it's just stuck in my
"Waiting on review" queue).
https://reviews.llvm.org/D43871
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334471: Fix that AlignedAllocation.h doesn't compile
because of VersionTuple (authored by teemperor, committed by ).
Repo
teemperor created this revision.
https://reviews.llvm.org/rL334399 put VersionTuple in the llvm namespace, but
this header still assumes it's in the clang namespace.
This leads to compilation failures with enabled modules when building Clang.
Repository:
rC Clang
https://reviews.llvm.org/D48
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333123: [modules] Mark
__wmmintrin_pclmul.h/__wmmintrin_aes.h as textual (authored by teemperor,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
teemperor edited reviewers, added: v.g.vassilev; removed: slydiman.
teemperor added a comment.
(Wrong Vassil, sorry)
https://reviews.llvm.org/D47277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
teemperor created this revision.
teemperor added reviewers: rsmith, slydiman.
Since clang r332929 these two headers throw errors when included from somewhere
else than their wrapper header. It seems marking them as textual is the best
way to fix the builds.
Fixes this new module build error:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333069: Fix unaligned memory access when reading
INPUT_FILE_OFFSETS data (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
teemperor created this revision.
teemperor added reviewers: rsmith, v.g.vassilev.
The blob data is unaligned, so we also should read it as such. Should fix the
random failures with the sanitizer builds.
Repository:
rC Clang
https://reviews.llvm.org/D47247
Files:
lib/Serialization/ASTReade
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332913: Add missing include for cstdint to Visibility.h
(authored by teemperor, committed by ).
Herald added a subscriber:
teemperor created this revision.
We use uint8_t in this header, so we need to include cstdint.
Repository:
rC Clang
https://reviews.llvm.org/D47164
Files:
include/clang/Basic/Visibility.h
Index: include/clang/Basic/Visibility.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331021: Make MultiplexASTDeserializationListener part of the
API [NFC] (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D37475?vs=113847&id=144287#toc
Repositor
teemperor updated this revision to Diff 139963.
teemperor added a comment.
- Added more test cases for reverse include order and clang modules.
https://reviews.llvm.org/D43871
Files:
lib/Headers/mm_malloc.h
lib/Sema/SemaExceptionSpec.cpp
test/CXX/except/except.spec/Inputs/clang/mm_malloc.
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D44191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
As this will land in clang 7, can you add a note to the release notes that this
breaks backwards compatibility for this interface (can be another commit)?
Also, we should point out that
teemperor created this revision.
teemperor added reviewers: rsmith, v.g.vassilev, chandlerc.
The GNU C library includes headers from the `_Builtin_intrinsics` module. As
the `_Builtin_intrinsics` module via
the `mm_malloc.h` header also includes the `stdlib.h` header from libc, we get
a cyclic d
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D43809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
See the inline comments. Please run clang-format over this patch after
addressing them (there are a few indentation issues).
Comment at: include/clang/Fronte
teemperor updated this revision to Diff 131204.
teemperor added a comment.
Herald added a subscriber: hintonda.
- Rebased and clang formatted.
https://reviews.llvm.org/D37557
Files:
unittests/AST/CMakeLists.txt
unittests/AST/PostOrderASTVisitor.cpp
unittests/Tooling/CMakeLists.txt
unitt
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323310: Refactor RecursiveASTVisitor test for post-order
traversal (authored by teemperor, committed by ).
Herald added a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323122: [modules] Correctly overload getModule in the
MultiplexExternalSemaSource (authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D39416
Files:
include/clang/Se
teemperor updated this revision to Diff 120808.
teemperor added a comment.
- Removed `virtual` keyword when we already have `override`.
https://reviews.llvm.org/D39416
Files:
include/clang/Sema/MultiplexExternalSemaSource.h
lib/Sema/MultiplexExternalSemaSource.cpp
Index: lib/Sema/Multiple
teemperor created this revision.
The MultiplexExternalSemaSource doesn't correctly overload the `getModule`
function,
causing the multiplexer to not forward this call as intended.
https://reviews.llvm.org/D39416
Files:
include/clang/Sema/MultiplexExternalSemaSource.h
lib/Sema/MultiplexExte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313049: Use the VFS from the CompilerInvocation by default
(authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D37416?vs=114823&id=114857#toc
Repository:
rL LLVM
https://revie
teemperor updated this revision to Diff 114823.
teemperor added a comment.
- Rebased with the correct diff...
https://reviews.llvm.org/D37416
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/FrontendAction.cpp
unittests/Frontend/CMakeLists.
teemperor updated this revision to Diff 114790.
teemperor added a comment.
- Rebased diff before merging.
https://reviews.llvm.org/D37416
Files:
lib/Frontend/CompilerInstance.cpp
unittests/Frontend/CMakeLists.txt
unittests/Frontend/CompilerInstanceTest.cpp
Index: unittests/Frontend/Compi
teemperor updated this revision to Diff 114524.
teemperor added a comment.
- Moved code from FrontendAction.cpp into createFileManager()
https://reviews.llvm.org/D37416
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/FrontendAction.cpp
uni
teemperor updated this revision to Diff 114504.
teemperor added a comment.
Herald added a subscriber: mgorny.
- Added test case.
https://reviews.llvm.org/D37416
Files:
lib/Frontend/CompilerInstance.cpp
unittests/Frontend/CMakeLists.txt
unittests/Frontend/CompilerInstanceTest.cpp
Index: u
teemperor created this revision.
Herald added subscribers: mgorny, klimek.
The new test is now in the right directory with the other ASTVisitor tests and
uses
now the provided TestVisitor framework.
Repository:
rL LLVM
https://reviews.llvm.org/D37557
Files:
unittests/AST/CMakeLists.txt
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
@johannes The blocking reviewer is because it touches clone detection code :)
Fine with me, I have some comments on things but nothing that affects this
review. LGTM!
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312533: [Bash-autocomplete] Fix crash when invoking
--autocomplete without value. (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D37465?vs=113829&id=113842#toc
Repository:
teemperor created this revision.
Currently clang segfaults when invoked with `clang --autocomplete=`.
This patch adds the necessary boundary checks and some tests for corner cases
like this.
Repository:
rL LLVM
https://reviews.llvm.org/D37465
Files:
lib/Driver/Driver.cpp
test/Driver/aut
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312468: [analyzer] Increase minimum complexity filter of the
CloneChecker. (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D34178?vs=113725&id=113726#toc
Repository:
rL LLV
teemperor updated this revision to Diff 113725.
teemperor added a comment.
- Rebased and updated patch before merging.
https://reviews.llvm.org/D34178
Files:
lib/StaticAnalyzer/Checkers/CloneChecker.cpp
test/Analysis/copypaste/asm.cpp
test/Analysis/copypaste/attributes.cpp
test/Analysis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312440: [analyzer] MinComplexityConstraint now early exits
and only does one macro… (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D34361?vs=113692&id=113693#toc
Repository:
teemperor updated this revision to Diff 113692.
teemperor added a comment.
- Rebased and fixed merge conflicts before merging.
https://reviews.llvm.org/D34361
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
Index: lib/Analysis/CloneDetection.cpp
teemperor added a comment.
@arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I
remembered we had some CMake sanity check about not having an *.inc in our
include dir:
https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure
if it actually fires for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [analyzer] Performance optimizations for the
CloneChecker (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D34182?vs=108839&id=113361#toc
Repository:
rL LLVM
https:
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D37249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311991: [modules] Add test for using declaration in classes.
(authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D37180?vs=112788&id=113044#toc
Repository:
rL LLVM
https://rev
teemperor added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1160
+void Driver::handleAutocompletions(const llvm::opt::Arg *A) const {
+ // Print out all options that start with a given argument. This is used for
I think a more generic interface wo
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, was on vacation.
> Since StmtDataCollectors.inc resides in lib I have to use relative paths (so
> the include directive looks different depending on the current file
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Found one more minor comment typo. And could you do your changes to
`OptParserEmitter.cpp` all in this patch? Because Rui/Me pointed out those
things on this review, so this patch should
teemperor added inline comments.
Comment at: clang/lib/Driver/DriverOptions.cpp:14
#include "llvm/Option/Option.h"
+#include
I think the C++ version of the assert header is more consistent: `#include
`
Comment at: llvm/utils/TableGen/OptPa
201 - 300 of 367 matches
Mail list logo