[PATCH] D156576: Remove rdar links in clang/lib. NFC

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155012/new/ https://reviews.llvm.org/D155012

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

ravikandhadai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:623 +def err_drv_darwin_sdk_missing_arclite : Error< + "SDK does not contain 'libarclite' at the path '%0'. This likely means you need to increase your minimum deployment

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131714/new/ https://reviews.llvm.org/D131714

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Alex. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 ___

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109402/new/ https://reviews.llvm.org/D109402 ___

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

ravikandhadai added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:889 + + /// Return true if th analyzed function is actually a default implementation + /// of the method that has to be overriden. typo: th -> the Repository: rG LLVM