bradfier accepted this revision.
bradfier added a comment.
This revision is now accepted and ready to land.
If this doesn't break the test case for '>>>' then it looks good, although I'm
not sure what has changed in the interim to allow that to work. When I made the
patch in r299952 we
bradfier added a comment.
In https://reviews.llvm.org/D31652#723664, @thakis wrote:
> Looks good. Do you have commit access?
Thanks! And no I don't have commit access.
Repository:
rL LLVM
https://reviews.llvm.org/D31652
___
cfe-commits
bradfier added a comment.
Friendly ping.
Repository:
rL LLVM
https://reviews.llvm.org/D31652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bradfier added a comment.
Thanks for that @thakis, that's a much better solution than the first attempt!
Repository:
rL LLVM
https://reviews.llvm.org/D31652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bradfier updated this revision to Diff 94438.
bradfier edited the summary of this revision.
bradfier added a comment.
Switch to a more appropriate (and much simpler) method of identifying these
Java-specific operators.
Also removed any references to fictitious "logical left shifts", I think I
bradfier added inline comments.
Comment at: include/clang/Basic/LangOptions.def:95
LANGOPT(ObjC2 , 1, 0, "Objective-C 2")
+LANGOPT(Java , 1, 0, "Java")
BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0,
arphaman wrote:
> I don't think
bradfier added a comment.
In https://reviews.llvm.org/D31652#719990, @arphaman wrote:
> Are the `<<<` and `>>>` operators handled correctly?
Yes, as a side-effect of CUDA kernel-call syntax which uses `>>>` and `<<<`,
those tokens are recognised as punctuators.
Repository:
rL LLVM
bradfier updated this revision to Diff 94334.
bradfier added a reviewer: klimek.
bradfier added a comment.
Add more diff context, add klimek as reviewer.
Repository:
rL LLVM
https://reviews.llvm.org/D31652
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/TokenKinds.def
bradfier created this revision.
Herald added a subscriber: klimek.
At present, clang-format mangles Java containing logical shift assignment
operators ('>>>=' or '<<<='), splitting them in two, resulting in invalid code:
public class Minimal {
public void func(String args) {
int
