Re: [PATCH] D11837: Add WebKit brace style configuration option.

2015-08-10 Thread Roman Kashitsyn via cfe-commits
lifted added a comment. In http://reviews.llvm.org/D11837#220408, @klimek wrote: Can you also fix the current code in getWebKitStyle? Yep, I've already done it. http://reviews.llvm.org/D11837 ___ cfe-commits mailing list

Re: [PATCH] D11837: Add Qt brace style configuration option.

2015-08-10 Thread Roman Kashitsyn via cfe-commits
lifted added a comment. Hm, the referenced style guide doesn't say anything about namespaces. You're right. Futhermore, it's hard to find any namespaces in qt repos at all - Qt uses a macro for conditional compilation with namespaces. I also couldn't find anything in the qt source repo

Re: [PATCH] D11837: Add WebKit brace style configuration option.

2015-08-10 Thread Roman Kashitsyn via cfe-commits
lifted added a comment. I had commit access earlier, but I haven't tried it for long time. I'll ask for help if there are any problems. http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11837: Add WebKit brace style configuration option.

2015-08-10 Thread Roman Kashitsyn via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL26: Add WebKit brace style configuration option. (authored by lifted). Changed prior to commit: http://reviews.llvm.org/D11837?vs=31660id=31665#toc Repository: rL LLVM

r244446 - Add WebKit brace style configuration option.

2015-08-10 Thread Roman Kashitsyn via cfe-commits
Author: lifted Date: Mon Aug 10 08:43:19 2015 New Revision: 26 URL: http://llvm.org/viewvc/llvm-project?rev=26view=rev Log: Add WebKit brace style configuration option. Summary: Add brace style `BS_WebKit` as described on https://www.webkit.org/coding/coding-style.html: * Function