[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-17 Thread Ruyman via Phabricator via cfe-commits
Ruyk added a subscriber: Naghasan. Ruyk added a comment. @Naghasan please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-04 Thread Ruyman via Phabricator via cfe-commits
Ruyk added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used")

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-01-21 Thread Ruyman via Phabricator via cfe-commits
Ruyk added a comment. Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION