[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. This was discussed in llvm-dev mailing list, and originally we had a change that was closer to what GCC was reporting however there was no consensus on what was needed. The purpose of this change is to bring parity in terms of available options with GCC.

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @MaskRay Yes this would unblock applications. Regarding your concern, the information from this implementation as well as GCC's should be used conservatively as both are approximate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping @Quuxplusone this is being used as a diagnostic flag that aliases "-Wframe-larger-than", I think if we want to add more user-facing documentation to clarify things we should revisit what the "-Wframe-larger-than=" tracks as well. Currently there isn't too

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added inline comments. Comment at: clang/docs/ReleaseNotes.rst:79-80 +- ``-Wstack-usage=`` warn if stack usage of user functions might + exceed . + Quuxplusone wrote: > Does this mean: > - Warn if the size of any single function's stack frame

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @bruno all tests are passing, could you take another look when you have a chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 349274. rsanthir.quic added a comment. Updated Release Notes and rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/docs/ReleaseNotes.rst

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348563. rsanthir.quic added a comment. Updated test and aligned negative flag with gcc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348555. rsanthir.quic added a comment. Updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348531. rsanthir.quic added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Moving forward with simpler approach here: https://reviews.llvm.org/D102782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101964/new/ https://reviews.llvm.org/D101964

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Moving forward with simpler approach here: https://reviews.llvm.org/D102782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101965/new/ https://reviews.llvm.org/D101965

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. Thanks for reviewing @bruno doesn't look like the failure is related to my change: https://buildkite.com/llvm-project/premerge-checks/builds/39905#5f70c261-ae54-451b-b771-7012bcee7387 "No space left on device" Unless I am looking at the wrong thing. Repository:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 346582. rsanthir.quic added a comment. Localized changes to Options.td, needed to explicitly add negative flag for -Wframe-larger-than Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this implementation "-Wstack-usage" acts as an alias to "-Wframe-larger-than" Repository:

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic added a comment. Another approach is explored here: https://reviews.llvm.org/D101964 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101965/new/ https://reviews.llvm.org/D101965 ___

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic added a comment. Another approach is explored here: https://reviews.llvm.org/D101965 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101964/new/ https://reviews.llvm.org/D101964 ___

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang, hiraditya. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The -Wstack-usage flag has been added, which provides a warning

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang, hiraditya. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds support for the -Wstack-usage flag. It also changes

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0395f9e70b8f: [ARM] Neon Polynomial vadd Intrinsic fix (authored by rsanthir.quic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic updated this revision to Diff 340567. rsanthir.quic marked an inline comment as done. rsanthir.quic added a comment. minor fixes and merged https://reviews.llvm.org/D100499 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100772/new/ https://reviews.llvm.org/D100772 Files:

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic marked an inline comment as done. rsanthir.quic added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:712 + +// Crypto +// TODO: poly128_t not implemented on aarch32

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Merging with https://reviews.llvm.org/D100772 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 ___ cfe-commits mailing list

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Here's the fix for enabling these on ARM: https://reviews.llvm.org/D100772 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 ___ cfe-commits mailing list

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic updated this revision to Diff 338539. rsanthir.quic added a comment. only the pol128 intrinsic is incompatible with ARM, the rest should be supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 Files:

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Thanks for looking into this @DavidSpickett ! What you found makes sense. I'll update this patch to remove only the poly128 vadd from the mapping. I'll also add another patch that will correctly enable the remaining vadd intrinsics for ARM. Repository: rG

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. As you mentioned, I thought it was only supported due to `CheckFPAdvSIMDEnabled64`. If the header is also guarding for AArch64 does that not support the idea that it is AArch64 specific? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

rsanthir.quic added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:36 + bool HasSHA3; + bool HasSM4; bool HasUnaligned; Would it make sense to further differentiate SM3 and SM4? I see that we differentiate between the two in arm_neon.td

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added a comment. Thank you for reviewing this @DavidSpickett ! If you get a chance could you commit this for me? I do not have commit access yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325034. rsanthir.quic added a comment. rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325027. rsanthir.quic added a comment. Windows builds were failing due to missing builtins in Intrinsics map CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files:

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:928 + +class SHA512H_pattern + : Pat<(v2i64 (OpNode (v2i64 V128:$Vd), (v2i64 V128:$Vn), (v2i64 V128:$Vm))), DavidSpickett wrote: > This is unused. a good catch thank

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 324711. rsanthir.quic marked 3 inline comments as done. rsanthir.quic added a comment. Minor corrections and removed unused code, also added complete testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 324347. rsanthir.quic added a comment. Removed extra whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 324336. rsanthir.quic marked an inline comment as done. rsanthir.quic retitled this revision from "[AArch64] Adding Polynomial vadd Intrinsics support" to "[AArch64] Adding Neon Polynomial vadd Intrinsics". rsanthir.quic added a comment. removed

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic marked an inline comment as done. rsanthir.quic added inline comments. Comment at: clang/test/CodeGen/aarch64-poly-add.c:4 +// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature +neon \ +// RUN: -disable-O0-optnone -ffp-contract=fast -emit-llvm -o - %s |

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic updated this revision to Diff 324153. rsanthir.quic added a comment. rebased due to merge issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic added a comment. This is the final of three patches to address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, kevin.qin, labrinea, pbarrio, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 322713. rsanthir.quic added a comment. alphabetized check in NeonEmitter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. @labrinea could you commit this when you have some time please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added a comment. This is the second of three patches to address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic created this revision. rsanthir.quic added reviewers: apazos, t.p.northover, labrinea, pbarrio. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic updated this revision to Diff 322470. rsanthir.quic added a comment. Updated test name and checks performed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. @t.p.northover Could you take a look before I ask for this to be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 ___ cfe-commits mailing list

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic updated this revision to Diff 320199. rsanthir.quic marked an inline comment as done. rsanthir.quic added a comment. Corrected register ordering for sm4e and removed redundant argument in sm3ss1 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic marked 2 inline comments as done. rsanthir.quic added a comment. Thank you for taking a look at this @labrinea ! Comment at: llvm/test/CodeGen/AArch64/neon-sm4-sm3.ll:77 +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:sm4e v1.4s, v0.4s +; CHECK-NEXT:mov

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. This is the first in a series of patches that will address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, pbarrio. Herald added subscribers: hiraditya, kristof.beyls. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds SM3