[libunwind] r311562 - unwind: explicitly align `_Unwind_Control_Block`

2017-08-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Aug 23 08:33:45 2017 New Revision: 311562 URL: http://llvm.org/viewvc/llvm-project?rev=311562=rev Log: unwind: explicitly align `_Unwind_Control_Block` The C++ ABI requires that the exception object is double-word aligned. The alignment attribute was applied to the

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

2017-08-22 Thread Saleem Abdulrasool via cfe-commits
ot;. With this change, it > >>>>> is not a struct anymore on ARM. Should that code be fixed, or is it a > >>>>> problem in this change? > >>>>> > >>>>> compiler-rt/lib/builtins/gcc_personality_v0.c:153:23: error: > >>>>> d

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

2017-08-12 Thread Saleem Abdulrasool via cfe-commits
, > > On Thu, Jul 27, 2017 at 9:46 AM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Merged to 5.0 in r309290. > > > > On Wed, Jul 26, 2017 at 3:55 PM, Saleem Abdulrasool via cfe-commits > > <cfe-commits@lists.llvm.org> wrote:

r309327 - Headers: fix _Unwind_{G,S}etGR for non-EHABI targets

2017-07-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jul 27 14:56:25 2017 New Revision: 309327 URL: http://llvm.org/viewvc/llvm-project?rev=309327=rev Log: Headers: fix _Unwind_{G,S}etGR for non-EHABI targets The EHABI definition was being inlined into the users even when EHABI was not in use. Adjust the condition to

r309226 - Headers: improve ARM EHABI coverage of unwind.h

2017-07-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Jul 26 15:55:23 2017 New Revision: 309226 URL: http://llvm.org/viewvc/llvm-project?rev=309226=rev Log: Headers: improve ARM EHABI coverage of unwind.h Ensure that we define the `_Unwind_Control_Block` structure used on ARM EHABI targets. This is needed for building

r306830 - Driver: fix option declaration

2017-06-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 30 08:15:39 2017 New Revision: 306830 URL: http://llvm.org/viewvc/llvm-project?rev=306830=rev Log: Driver: fix option declaration The option is a "joined" argument. Fix silly copy-paste error. This allows the parsing to work at runtime. Modified:

r306829 - Driver: honor -nostdinc and -isystem-after on CrossWindows

2017-06-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 30 08:15:38 2017 New Revision: 306829 URL: http://llvm.org/viewvc/llvm-project?rev=306829=rev Log: Driver: honor -nostdinc and -isystem-after on CrossWindows This changes CrossWindows to look for -nostdinc instead of -nostdlibinc. In addition, fixes a bug where

r306622 - CodeGen: handle missed case of COMDAT handling

2017-06-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Jun 28 17:54:44 2017 New Revision: 306622 URL: http://llvm.org/viewvc/llvm-project?rev=306622=rev Log: CodeGen: handle missed case of COMDAT handling When Protocol references are constructed, we need to add the reference symbol to a COMDAT group on non-MachO object

r306447 - test: fix test for release builds

2017-06-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 27 11:57:50 2017 New Revision: 306447 URL: http://llvm.org/viewvc/llvm-project?rev=306447=rev Log: test: fix test for release builds Use a regex capture to avoid hardcoding the name. This should repair the failing buildbot. Modified:

r306444 - CodeGen: load indirect ObjC ARC arguments in prologue

2017-06-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 27 11:37:51 2017 New Revision: 306444 URL: http://llvm.org/viewvc/llvm-project?rev=306444=rev Log: CodeGen: load indirect ObjC ARC arguments in prologue When generating a prologue, add loads for ARC arguments passed indirectly. Patch by Dave Lee! Added:

Re: r306127 - [GSoC] Add support for CC1 options.

2017-06-26 Thread Saleem Abdulrasool via cfe-commits
I think that we shouldn't be providing completion for `-cc1` options. `-cc1as` options are fine as the IAS serves as a replacement for the traditional unix `as`. But, the `NoDriverOption` values shouldn't be exposed to users. They are internal details, with no compatibility. If users start

r306347 - AST: enhance mangling for blocks with MS ABI

2017-06-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jun 26 16:28:42 2017 New Revision: 306347 URL: http://llvm.org/viewvc/llvm-project?rev=306347=rev Log: AST: enhance mangling for blocks with MS ABI When generating the decorated name for a static variable inside a BlockDecl, construct a scope for the block invocation

r306123 - test: fix negative test case

2017-06-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 23 11:52:49 2017 New Revision: 306123 URL: http://llvm.org/viewvc/llvm-project?rev=306123=rev Log: test: fix negative test case Add missing -### to the driver to ensure that we dont try to run the actual command. The host may not support the IAS. Should fix the

r306115 - Revert "Revert r305164/5/7."

2017-06-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 23 10:34:16 2017 New Revision: 306115 URL: http://llvm.org/viewvc/llvm-project?rev=306115=rev Log: Revert "Revert r305164/5/7." Restore the `-gz` option to the driver with some minor tweaks to handle the additional case for `-Wa,--compress-debug-sections`. This

r305638 - CodeGen: make the type match the comment for a libcall

2017-06-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 17 12:30:31 2017 New Revision: 305638 URL: http://llvm.org/viewvc/llvm-project?rev=305638=rev Log: CodeGen: make the type match the comment for a libcall Fix the type for a (runtime) library call to match both the comment and the runtime implementation. As it

[libcxxabi] r305175 - build: use cmake to pass -std=c++11

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 18:59:26 2017 New Revision: 305175 URL: http://llvm.org/viewvc/llvm-project?rev=305175=rev Log: build: use cmake to pass -std=c++11 Rather than manually checking for support for the spelling of the C++ standard, indicate to CMake that we require that the

[libcxxabi] r305174 - build: use POSITION_INDEPENDENT_CODE CMake property

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 18:59:24 2017 New Revision: 305174 URL: http://llvm.org/viewvc/llvm-project?rev=305174=rev Log: build: use POSITION_INDEPENDENT_CODE CMake property Use the POSITION_INDEPENDENT_CODE target property to indicate that we should be building with -fPIC or the

[libcxxabi] r305173 - cxa_demangle: fix -Wimplicit-fallthrough for GCC:7

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 17:57:31 2017 New Revision: 305173 URL: http://llvm.org/viewvc/llvm-project?rev=305173=rev Log: cxa_demangle: fix -Wimplicit-fallthrough for GCC:7 Use the C++11 (formalised in C++17) tag to indicate a fallthrough in the switch case. Silences a

[libcxxabi] r305172 - private_typeinfo: add missing field initializers

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 17:57:26 2017 New Revision: 305172 URL: http://llvm.org/viewvc/llvm-project?rev=305172=rev Log: private_typeinfo: add missing field initializers Cleanup the -Wmissing-field-initializers warnings from gcc:7 builds. NFC. Modified:

r305167 - test: attempt to repair build bots

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 13:55:17 2017 New Revision: 305167 URL: http://llvm.org/viewvc/llvm-project?rev=305167=rev Log: test: attempt to repair build bots Split the no-ias tests and give them a target to ensure that they go down the GNU toolchain path. Adjust the no compression

r305164 - Driver: pass along [-]-[no]compress-debug-sections unfiltered

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 12:49:17 2017 New Revision: 305164 URL: http://llvm.org/viewvc/llvm-project?rev=305164=rev Log: Driver: pass along [-]-[no]compress-debug-sections unfiltered Rather than validating the flags, pass them through without any validation. Arguments passed via -Wa or

r305165 - Driver: add support for `-gz` and `-gz=`

2017-06-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jun 11 12:49:23 2017 New Revision: 305165 URL: http://llvm.org/viewvc/llvm-project?rev=305165=rev Log: Driver: add support for `-gz` and `-gz=` These options control the behaviour of the compression of debug info sections on ELF targets. Our behaviour slightly

r305039 - Represent debug information compression type fully

2017-06-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jun 8 19:40:30 2017 New Revision: 305039 URL: http://llvm.org/viewvc/llvm-project?rev=305039=rev Log: Represent debug information compression type fully This is tied with the LLVM side of the change to expose the debug information compression types to clang. We now

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-07 Thread Saleem Abdulrasool via cfe-commits
I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid code: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'unsigned int *' [-Wincompatible-pointer-types] Switching the signature on LP64

r304662 - tests: silence -Wobjc-root-class warnings

2017-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 3 11:18:13 2017 New Revision: 304662 URL: http://llvm.org/viewvc/llvm-project?rev=304662=rev Log: tests: silence -Wobjc-root-class warnings Silence warnings about no ObjC class root for the types defined for the tests. Modified:

r304661 - CodeGen: fix section names for different file formats

2017-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 3 11:18:09 2017 New Revision: 304661 URL: http://llvm.org/viewvc/llvm-project?rev=304661=rev Log: CodeGen: fix section names for different file formats This changes the codegen to match the section names according to the ObjC rewriter as well as the runtime. The

r303804 - Basic: fix whitespace in file header (NFC)

2017-05-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed May 24 15:27:09 2017 New Revision: 303804 URL: http://llvm.org/viewvc/llvm-project?rev=303804=rev Log: Basic: fix whitespace in file header (NFC) Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL:

r302270 - CodeGen: avoid use of @clang.arc.use intrinsic at O0

2017-05-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri May 5 13:39:06 2017 New Revision: 302270 URL: http://llvm.org/viewvc/llvm-project?rev=302270=rev Log: CodeGen: avoid use of @clang.arc.use intrinsic at O0 The clang.arc.use intrinsic is removed via the ARC Contract Pass. This pass is only executed in optimized builds

r302184 - Driver: only inject libstdc++ paths when needed on CrossWindows

2017-05-04 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu May 4 14:18:21 2017 New Revision: 302184 URL: http://llvm.org/viewvc/llvm-project?rev=302184=rev Log: Driver: only inject libstdc++ paths when needed on CrossWindows When building with libc++ don't bother with injecting the libstdc++ search paths into the linker

r301783 - utils: Silence -Wpedantic warning

2017-04-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 30 19:26:59 2017 New Revision: 301783 URL: http://llvm.org/viewvc/llvm-project?rev=301783=rev Log: utils: Silence -Wpedantic warning llvm/tools/clang/utils/TableGen/ClangAttrEmitter.cpp:1673:67: warning: default argument specified for lambda parameter [-Wpedantic]

r300909 - Sema: protect against ObjC++ typo-correction failure

2017-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 20 17:23:10 2017 New Revision: 300909 URL: http://llvm.org/viewvc/llvm-project?rev=300909=rev Log: Sema: protect against ObjC++ typo-correction failure ObjC++ has two different types of "pointer" types (ObjCClassPointerType and PointerType). Both can be indirected

r300908 - Parse: cleanup some bleeding whitespace

2017-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 20 17:23:07 2017 New Revision: 300908 URL: http://llvm.org/viewvc/llvm-project?rev=300908=rev Log: Parse: cleanup some bleeding whitespace Clean up some bleeding whitespace that I noticed. NFC Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified:

r299800 - Toolchains: remove crtbegin on xwindows

2017-04-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 7 15:47:06 2017 New Revision: 299800 URL: http://llvm.org/viewvc/llvm-project?rev=299800=rev Log: Toolchains: remove crtbegin on xwindows crtbegin is not really a proper windows support thing. This was duplicated when the toolchain was initially built. If the

Re: r299774 - Sema: prevent __declspec(naked) use on x64

2017-04-07 Thread Saleem Abdulrasool via cfe-commits
cfe-commits" > > <cfe-commits@lists.llvm.org> wrote: > > > > > > > > On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits > > <cfe-commits@lists.llvm.org> wrote: > >> > >> On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via

r299774 - Sema: prevent __declspec(naked) use on x64

2017-04-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 7 10:13:47 2017 New Revision: 299774 URL: http://llvm.org/viewvc/llvm-project?rev=299774=rev Log: Sema: prevent __declspec(naked) use on x64 MSDN (https://msdn.microsoft.com/en-us/library/h5w10wxs.aspx) indicates that `__declspec(naked)` is only permitted on x86

[libunwind] r299591 - AddressSpace: fix DWARF based unwinding handling on Android

2017-04-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 5 16:29:38 2017 New Revision: 299591 URL: http://llvm.org/viewvc/llvm-project?rev=299591=rev Log: AddressSpace: fix DWARF based unwinding handling on Android It is possible that there are no program headers in the module. Do not attempt to dereference nullptr as

[libunwind] r299575 - Fix invalid memory access on android x86

2017-04-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 5 13:33:23 2017 New Revision: 299575 URL: http://llvm.org/viewvc/llvm-project?rev=299575=rev Log: Fix invalid memory access on android x86 On certain versions of android x86, the main module `app_process` is not built as PIE. When accessing the

[libunwind] r297744 - DarwinParser: include limits

2017-03-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Mar 14 10:17:55 2017 New Revision: 297744 URL: http://llvm.org/viewvc/llvm-project?rev=297744=rev Log: DarwinParser: include limits In debug mode, we have assertions that the values do not exceed the limits of the type holding them. In order to account for the type

[libunwind] r297291 - DARWF: silence some warnings about conversions

2017-03-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Mar 8 10:03:27 2017 New Revision: 297291 URL: http://llvm.org/viewvc/llvm-project?rev=297291=rev Log: DARWF: silence some warnings about conversions Add a check for an overflow and explicitly cast the value. We would have silently overflowed previously. Modified:

r296769 - Serialization: use the PCH chain to check PCH mode

2017-03-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Mar 2 11:37:11 2017 New Revision: 296769 URL: http://llvm.org/viewvc/llvm-project?rev=296769=rev Log: Serialization: use the PCH chain to check PCH mode When we are deciding whether we are creating a PCH or a module, we would check if the ModuleMgr had any elements to

r295683 - Sema: use PropertyDecl for property selector

2017-02-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 20 17:45:49 2017 New Revision: 295683 URL: http://llvm.org/viewvc/llvm-project?rev=295683=rev Log: Sema: use PropertyDecl for property selector Using the constructed name for the class properties with dot syntax may yield an inappropriate selector (i.e. if it is

r295620 - Driver: inline a single caller of a function (NFC)

2017-02-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 19 15:50:40 2017 New Revision: 295620 URL: http://llvm.org/viewvc/llvm-project?rev=295620=rev Log: Driver: inline a single caller of a function (NFC) Inline the addCompilerRT call to the single caller. NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

[libcxx] r295560 - test: silence warnings on clang under clang-cl

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:41 2017 New Revision: 295560 URL: http://llvm.org/viewvc/llvm-project?rev=295560=rev Log: test: silence warnings on clang under clang-cl When running under clang-cl mode, we do not define `__GNUC__`, resulting in the test failing. Modified:

[libcxx] r295559 - math: add type promoting template definition on MSVCRT

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:38 2017 New Revision: 295559 URL: http://llvm.org/viewvc/llvm-project?rev=295559=rev Log: math: add type promoting template definition on MSVCRT When building with MSVCRT, we need to manually provide the type promoting overloads to allow the correct type

[libcxx] r295558 - test: explicitly size enumeration

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:36 2017 New Revision: 295558 URL: http://llvm.org/viewvc/llvm-project?rev=295558=rev Log: test: explicitly size enumeration On certain targets, enumerations may be smaller than an `unsigned long`. Use an explicitly sized enumeration. Modified:

[libcxx] r295561 - Revert "threading_support: make __thread_sleep_for be alertable"

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:43 2017 New Revision: 295561 URL: http://llvm.org/viewvc/llvm-project?rev=295561=rev Log: Revert "threading_support: make __thread_sleep_for be alertable" This reverts SVN r295329. Although `__libcpp_thread_sleep_for` should be alertable, the

[libcxx] r295510 - math: fix typo in macro

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:44 2017 New Revision: 295510 URL: http://llvm.org/viewvc/llvm-project?rev=295510=rev Log: math: fix typo in macro MAJOR was misspelt as NAJOR. Fix the spelling. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h Modified:

[libcxx] r295511 - test: prevent incorrect quoting of paths

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:46 2017 New Revision: 295511 URL: http://llvm.org/viewvc/llvm-project?rev=295511=rev Log: test: prevent incorrect quoting of paths The path would previously get an extra leading space as the arguments would be parsed when generating the final command to

[libcxx] r295509 - cmath: Use c99 math on a new enough msvcrt

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:42 2017 New Revision: 295509 URL: http://llvm.org/viewvc/llvm-project?rev=295509=rev Log: cmath: Use c99 math on a new enough msvcrt MSVCRT 14+ supports the C99 math routines that we need. Use them accordingly. Modified: libcxx/trunk/include/cmath

[libcxx] r295329 - threading_support: make __thread_sleep_for be alertable

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:45 2017 New Revision: 295329 URL: http://llvm.org/viewvc/llvm-project?rev=295329=rev Log: threading_support: make __thread_sleep_for be alertable On Windows, we were using `Sleep` which is not alertable. This means that if the thread was used for a user

[libcxx] r295330 - math: correct the MSVCRT condition

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:50 2017 New Revision: 295330 URL: http://llvm.org/viewvc/llvm-project?rev=295330=rev Log: math: correct the MSVCRT condition Fixes a number of tests in the testsuite on Windows. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h

[libcxx] r294958 - config: disable thread safety analysis on COFF

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:51 2017 New Revision: 294958 URL: http://llvm.org/viewvc/llvm-project?rev=294958=rev Log: config: disable thread safety analysis on COFF clang cannot properly handle __declspec and __attribute__ on classes right now. This prevents the shared_mutex tests

[libcxx] r294956 - test: mark another test as requiring pthreads

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:47 2017 New Revision: 294956 URL: http://llvm.org/viewvc/llvm-project?rev=294956=rev Log: test: mark another test as requiring pthreads This is checking pthread specific behaviour. Add a requirement on pthreads. Modified:

[libcxx] r294957 - math: actually pull the declarations/overloads into std

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:50 2017 New Revision: 294957 URL: http://llvm.org/viewvc/llvm-project?rev=294957=rev Log: math: actually pull the declarations/overloads into std The previous changes missed the change to include/cmath. These changes allow some of the rand.distribution

[libcxx] r294917 - test: use char32_t rather than wchar_t

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 15:42:35 2017 New Revision: 294917 URL: http://llvm.org/viewvc/llvm-project?rev=294917=rev Log: test: use char32_t rather than wchar_t wchar_t is not as portable as char32_t. On Windows, wchar_t is 16-bytes and on Linux 32-bits. The conversion to utf8 causes

[libcxx] r294918 - math: follow up to SVN r294902

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 15:42:37 2017 New Revision: 294918 URL: http://llvm.org/viewvc/llvm-project?rev=294918=rev Log: math: follow up to SVN r294902 Pull in the math functions from ucrt 14+ after auditing the library. It seems that they are now complete for C99 math. Fixes more

[libcxx] r294903 - test: mark requirement for pthread test

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:48 2017 New Revision: 294903 URL: http://llvm.org/viewvc/llvm-project?rev=294903=rev Log: test: mark requirement for pthread test This test explicitly is checking the behaviour of std::thread and pthread interactions. This requires pthreads. Add an

[libcxx] r294902 - math: pull more C functions from std

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:45 2017 New Revision: 294902 URL: http://llvm.org/viewvc/llvm-project?rev=294902=rev Log: math: pull more C functions from std The newer ucrt version provides the gamma meth routines. Includede them when building the library. Modified:

[libcxx] r294901 - test: squelch -Wreturn-type error

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:44 2017 New Revision: 294901 URL: http://llvm.org/viewvc/llvm-project?rev=294901=rev Log: test: squelch -Wreturn-type error Add an unreachable marker to avoid a -Wreturn-type error when building on Windows. Modified:

[libcxx] r294899 - cmath: adjust math forwards for Windows

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 10:44:17 2017 New Revision: 294899 URL: http://llvm.org/viewvc/llvm-project?rev=294899=rev Log: cmath: adjust math forwards for Windows The newer versions of ucrt have the math routines. Use the CRT version to determine if we should include the math routines.

r294877 - CodeGen: use # as the comment leader for ARC marker

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 17:03:13 2017 New Revision: 294877 URL: http://llvm.org/viewvc/llvm-project?rev=294877=rev Log: CodeGen: use # as the comment leader for ARC marker Use # as the comment leader for AArch64 auto-release elision marker. This is to keep it in sync with the value

r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:18 2017 New Revision: 294872 URL: http://llvm.org/viewvc/llvm-project?rev=294872=rev Log: CodeGen: annotate ObjC ARC functions with ABI constraints Certain ARC runtime functions have an ABI contract of being forwarding. Annotate the functions with the

r294871 - test: ignore some warnings in test code (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:15 2017 New Revision: 294871 URL: http://llvm.org/viewvc/llvm-project?rev=294871=rev Log: test: ignore some warnings in test code (NFC) Silence some diagnostics which clang now generates. This makes it easier to see the failures in lit output. NFC.

Re: r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Hi Hans, Would you mind grabbing this for the 4.0 release as well? It's merely correcting the documentation, so should have no impact on the toolchain itself. On Sat, Feb 11, 2017 at 9:24 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd &g

r294854 - CodeGen: rename variables to adhere to naming convention

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:07 2017 New Revision: 294854 URL: http://llvm.org/viewvc/llvm-project?rev=294854=rev Log: CodeGen: rename variables to adhere to naming convention Adjust style before making more intrusive changes. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp

r294853 - Sema: simplify conditional execution (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:04 2017 New Revision: 294853 URL: http://llvm.org/viewvc/llvm-project?rev=294853=rev Log: Sema: simplify conditional execution (NFC) The conditional cast is unnecessary since we know that it will always succeed. NFC. Modified:

r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:09 2017 New Revision: 294855 URL: http://llvm.org/viewvc/llvm-project?rev=294855=rev Log: docs: update docs for objc_storeStrong behaviour objc_storeStrong does not return a value. Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst

[libcxx] r294720 - test: XFAIL windows for non-portable test

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:51:21 2017 New Revision: 294720 URL: http://llvm.org/viewvc/llvm-project?rev=294720=rev Log: test: XFAIL windows for non-portable test This test validates that the lock_guard is declared variadically across C++03 and C++11. Given the lack of stable ABI on

[libcxx] r294719 - test: fix test under Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:51:19 2017 New Revision: 294719 URL: http://llvm.org/viewvc/llvm-project?rev=294719=rev Log: test: fix test under Windows When running the test under clang-cl, we do not report `__GNUC__`, which is needed to supress the warnings which are being treated as

[libcxx] r294716 - test: allow -target usage on Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:24:34 2017 New Revision: 294716 URL: http://llvm.org/viewvc/llvm-project?rev=294716=rev Log: test: allow -target usage on Windows When running the tests on Windows with a debug build, _DEBUG must be added to the flags prior to the -target as the forced

[libcxx] r294705 - docs: add some documentation for building on Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 9 21:58:20 2017 New Revision: 294705 URL: http://llvm.org/viewvc/llvm-project?rev=294705=rev Log: docs: add some documentation for building on Windows This covers how to build libc++ for Windows. This allows others to replicate the MS ABI style build for libc++.

[libcxx] r294698 - __threading_support: fix windows build

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 9 20:49:52 2017 New Revision: 294698 URL: http://llvm.org/viewvc/llvm-project?rev=294698=rev Log: __threading_support: fix windows build The build was broken as there was no overload for long and std::chrono::nanoseconds. Add an explicit conversion to use the

r294401 - Sema: add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 7 21:30:13 2017 New Revision: 294401 URL: http://llvm.org/viewvc/llvm-project?rev=294401=rev Log: Sema: add warning for c++ member variable shadowing Add a warning for shadowed variables across records. Referencing a shadow'ed variable may not give the desired

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs <jonat...@codesourcery.com> wrote: > > > On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: > >> Don't use the cast for the check, use isa. Although, since you use the >> value later,

r294332 - Revert "Basic: match GCC behaviour for SuS macro"

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 7 13:00:06 2017 New Revision: 294332 URL: http://llvm.org/viewvc/llvm-project?rev=294332=rev Log: Revert "Basic: match GCC behaviour for SuS macro" This reverts commit SVN r294148. Seems that it was mistaken, and GCC does still define `__unix` and `unix` when in

[libcxx] r294270 - filesystem: return the constructed object

2017-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 6 20:46:59 2017 New Revision: 294270 URL: http://llvm.org/viewvc/llvm-project?rev=294270=rev Log: filesystem: return the constructed object This really should get identified properly by the compiler to convert to a NVRO, but compress the code anyways. This makes

[libcxx] r294171 - Refer to _LIBCPP_MSVC macro where applicable

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 23:26:49 2017 New Revision: 294171 URL: http://llvm.org/viewvc/llvm-project?rev=294171=rev Log: Refer to _LIBCPP_MSVC macro where applicable Replace preprocess conditions of defined(_MSC_VER) && !defined(__clang__) with defined(_LIBCPP_MSVC). NFC. Patch by

r294148 - Basic: match GCC behaviour for SuS macro

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 16:18:15 2017 New Revision: 294148 URL: http://llvm.org/viewvc/llvm-project?rev=294148=rev Log: Basic: match GCC behaviour for SuS macro GCC does not generate `__unix` nor `unix` macros. The latter already intrudes into the user's namespace and should be

[libcxx] r294127 - filesystem: fix n4100 conformance for `temp_directory_path`

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 11:21:52 2017 New Revision: 294127 URL: http://llvm.org/viewvc/llvm-project?rev=294127=rev Log: filesystem: fix n4100 conformance for `temp_directory_path` N4100 states that an error shall be reported if `!exists(p) || !is_directory(p)`. We were missing the

r293867 - CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC)

2017-02-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Feb 1 23:45:43 2017 New Revision: 293867 URL: http://llvm.org/viewvc/llvm-project?rev=293867=rev Log: CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC) Drive by cleanup noticed while investigating an IR verifier assertion. Modified:

Re: Add warning for c++ member variable shadowing

2017-01-31 Thread Saleem Abdulrasool via cfe-commits
Hmm, the braces in the if (bases.find(...)...) are not needed. Could you also add a test case for virtual inheritance? On Mon, Jan 30, 2017 at 8:34 PM, James Sun wrote: > Hi Saleem > > > > Thanks for the quick response. A test case is added. It covers some > ordinary cases as

Re: [libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Can you file a PR for changing this to internal visibility please? I think that we could probably do that in the unstable ABI versioning in fact. On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bogner > Date: Mon Jan 30 19:26:09 2017

Re: Add warning for c++ member variable shadowing

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
I think that the patch is starting to look pretty good! Can you add some test cases for the particular cases to diagnose in a separate test set to ensure that we have proper coverage of the various cases rather than relying on the existing test cases? Something to make sure that we get the

r293556 - Serialization: use range based for loop (NFC)

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 16:25:28 2017 New Revision: 293556 URL: http://llvm.org/viewvc/llvm-project?rev=293556=rev Log: Serialization: use range based for loop (NFC) Just a small clean up noticed when doing post-commit review of Duncan's previous change for ModuleFile memory ownership

[libcxx] r293543 - experimental: avoid using raw _WIN32 in filesystem

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 13:57:27 2017 New Revision: 293543 URL: http://llvm.org/viewvc/llvm-project?rev=293543=rev Log: experimental: avoid using raw _WIN32 in filesystem Use the _LIBCPP_WIN32API macro instead of _WIN32 checks. Fix a missed renaming for style conformance. Modified:

[libcxx] r293531 - experimental: port directory_iterator to Windows

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 12:50:34 2017 New Revision: 293531 URL: http://llvm.org/viewvc/llvm-project?rev=293531=rev Log: experimental: port directory_iterator to Windows This adds a basic first cut implementation for directory_iterator on Windows. It uses the FindFirstFile/FindNextFile

[libcxx] r293530 - experimental: add missing file header

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 12:50:32 2017 New Revision: 293530 URL: http://llvm.org/viewvc/llvm-project?rev=293530=rev Log: experimental: add missing file header The directory_iterator implementation file was missing the file header. Add one. NFC. Modified:

[libcxx] r293454 - experimental: remove some extraneous _LIBCPP_FUNC_VIS

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 21:58:26 2017 New Revision: 293454 URL: http://llvm.org/viewvc/llvm-project?rev=293454=rev Log: experimental: remove some extraneous _LIBCPP_FUNC_VIS These member functions were decorated with `_LIBCPP_FUNC_VIS` when the class is also decorated with external

[libcxx] r293450 - experimental: inline single use of a typedef

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 18:15:50 2017 New Revision: 293450 URL: http://llvm.org/viewvc/llvm-project?rev=293450=rev Log: experimental: inline single use of a typedef The typedef is not particularly long, and used in exactly one location. Just spell it out at the site. NFC. Modified:

[libcxx] r293449 - experimental: tolerate the existence of a `__deref` macro

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 18:15:47 2017 New Revision: 293449 URL: http://llvm.org/viewvc/llvm-project?rev=293449=rev Log: experimental: tolerate the existence of a `__deref` macro Microsoft's SAL has a `__deref` macro which results in a compilation failure when building the filesystem

[libcxx] r293445 - experimental: remove dead function

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 16:31:28 2017 New Revision: 293445 URL: http://llvm.org/viewvc/llvm-project?rev=293445=rev Log: experimental: remove dead function This template was defined inline, within the TU only and had no uses across the entire repository. Remove the dead code. NFC.

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
think? > > On Sat, Jan 21, 2017 at 8:22 AM, Saleem Abdulrasool via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: compnerd > > Date: Sat Jan 21 10:22:59 2017 > > New Revision: 292723 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=29272

Re: [libunwind] r292721 - DWARF: convert error logs to _LIBUNWIND_LOG

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
/steps/bootstrap%20clang/logs/stdio > > > > llvm/projects/libunwind/src/config.h:90:41: error: token pasting of > > ',' and __VA_ARGS__ is a GNU extension > > [-Werror,-Wgnu-zero-variadic-macro-arguments] > > fprintf(stderr, "libunwind: " msg "\n",

[libunwind] r293257 - Revert "DWARF: convert error logs to _LIBUNWIND_LOG"

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 26 20:26:52 2017 New Revision: 293257 URL: http://llvm.org/viewvc/llvm-project?rev=293257=rev Log: Revert "DWARF: convert error logs to _LIBUNWIND_LOG" This reverts SVN r292721. Avoid the use of the GNU extension as the preprocessor in C++11 mode requires at least

r293014 - Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 21:36:28 2017 New Revision: 293014 URL: http://llvm.org/viewvc/llvm-project?rev=293014=rev Log: Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions and then later disable ARC with

Re: Add warning for c++ member variable shadowing

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code. The ignore warning comments are restating what is in the code, please remove them.

Re: [libunwind] r292722 - DWARF: allow enabling tracing at runtime

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
-metal environment to make this work? > > Thanks, > Oliver > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Saleem Abdulrasool via cfe-commits > > Sent: 21 January 2017 16:23 > > To: cf

[libunwind] r293008 - DWARF: fix -Asserts builds

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 20:27:45 2017 New Revision: 293008 URL: http://llvm.org/viewvc/llvm-project?rev=293008=rev Log: DWARF: fix -Asserts builds no-op the DWARF tracing macros in non-debug builds. Modified: libunwind/trunk/src/DwarfParser.hpp libunwind/trunk/src/config.h

[libcxxabi] r292973 - cxa_demangle: fix rvalue ref check

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 13:57:05 2017 New Revision: 292973 URL: http://llvm.org/viewvc/llvm-project?rev=292973=rev Log: cxa_demangle: fix rvalue ref check When checking if the type is a r-value ref, we would not do a complete check. This would result in us treating a trailing

[libcxxabi] r292963 - cxa_demangle: avoid butchering the last parameter type

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 12:42:56 2017 New Revision: 292963 URL: http://llvm.org/viewvc/llvm-project?rev=292963=rev Log: cxa_demangle: avoid butchering the last parameter type Fix an off-by-one case which would destroy the final parameter in a CV-qualified function type with a

<    1   2   3   4   5   6   7   8   9   >