Re: r272741 - Headers: tweak for MSVC[<1800]

2016-06-16 Thread Saleem Abdulrasool via cfe-commits
2:34 AM, "Saleem Abdulrasool via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > >> Author: compnerd >> Date: Tue Jun 14 19:28:15 2016 >> New Revision: 272741 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=272741=rev >> Log: >&

r272741 - Headers: tweak for MSVC[<1800]

2016-06-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 14 19:28:15 2016 New Revision: 272741 URL: http://llvm.org/viewvc/llvm-project?rev=272741=rev Log: Headers: tweak for MSVC[<1800] Earlier versions of MSVC did not include inttypes.h. Ensure that we dont try to include_next on those releases. Modified:

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

2016-06-13 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. Comment at: lib/Basic/Targets.cpp:5709 @@ -5715,1 +5708,3 @@ + +return false; } Please collapse this: return Name == "generic" || llvm::AArch64::parseCPUArch(Name) != llvm::ARM::AK_INVALID;

r272424 - Driver: make it easier to select the SjLj EH model

2016-06-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 10 15:12:00 2016 New Revision: 272424 URL: http://llvm.org/viewvc/llvm-project?rev=272424=rev Log: Driver: make it easier to select the SjLj EH model GCC still permits enabling the SjLj EH model. This is something which can be done on various targets. Hoist the

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the

r271762 - Sema: do not attempt to sizeof a dependent type

2016-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 3 22:16:21 2016 New Revision: 271762 URL: http://llvm.org/viewvc/llvm-project?rev=271762=rev Log: Sema: do not attempt to sizeof a dependent type We would attempt to evaluate the sizeof a dependent type to check for an integral overflow. However, because the

r271750 - CodeGen: correct assertion

2016-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 3 18:26:30 2016 New Revision: 271750 URL: http://llvm.org/viewvc/llvm-project?rev=271750=rev Log: CodeGen: correct assertion The assertion added earlier was overly strict. We need to strip the pointer casts (as when constructing the GV). Correct the types

Re: [PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

2016-06-01 Thread Saleem Abdulrasool via cfe-commits
compnerd requested changes to this revision. This revision now requires changes to proceed. Comment at: CMakeLists.txt:259 @@ +258,3 @@ +add_target_flags_if(LIBCXX_TARGET_TRIPLE "-target ${LIBCXX_TARGET_TRIPLE}") +add_target_flags_if(LIBCXX_SYSROOT "--sysroot ${LIBCXX_SYSROOT}")

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
to coalesce the CFString structures (though, AFAIK, none do atm ... perhaps lld should be the first!). In the worst case, this will just get collapsed into the .rodata section, so its no worse off. > On 30 May 2016 at 12:23, Saleem Abdulrasool via cfe-commits > <cfe-commits@lists.llvm.o

r271221 - CodeGen: address post-commit review comments

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 30 13:26:06 2016 New Revision: 271221 URL: http://llvm.org/viewvc/llvm-project?rev=271221=rev Log: CodeGen: address post-commit review comments David Majnemer pointed out that isOSBinFormatMachO is more compact. NFC. Modified:

r271212 - test: add explicit targets for some tests

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 30 11:36:48 2016 New Revision: 271212 URL: http://llvm.org/viewvc/llvm-project?rev=271212=rev Log: test: add explicit targets for some tests These tests currently expect MachO section names and do not provide a target. Explicitly provide one. Modified:

r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 30 11:23:07 2016 New Revision: 271211 URL: http://llvm.org/viewvc/llvm-project?rev=271211=rev Log: CodeGen: tweak CFConstantStrings for COFF and ELF Adjust the constant CFString emission to emit into more appropriate sections on ELF and COFF targets. It would

r271138 - CodeGen: support blocks on COFF targets in DLLs

2016-05-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat May 28 14:41:35 2016 New Revision: 271138 URL: http://llvm.org/viewvc/llvm-project?rev=271138=rev Log: CodeGen: support blocks on COFF targets in DLLs This extends the blocks support to support blocks with a dynamically linked blocks runtime. The previous code

Re: [PATCH] D20270: libc++abi: build with -fvisibility=hidden

2016-05-25 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r270816 with the changes. Repository: rL LLVM http://reviews.llvm.org/D20270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r270816 - libc++abi: build with -fvisibility=hidden

2016-05-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed May 25 21:12:20 2016 New Revision: 270816 URL: http://llvm.org/viewvc/llvm-project?rev=270816=rev Log: libc++abi: build with -fvisibility=hidden Enable building libc++abi with hidden visibility by default. The ABI mandated interfaces (and a few extra) are already set

r270528 - CodeGen: indicate to the backend the exception model

2016-05-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 23 22:21:01 2016 New Revision: 270528 URL: http://llvm.org/viewvc/llvm-project?rev=270528=rev Log: CodeGen: indicate to the backend the exception model Thread through -fsjlj-exceptions to the backend via the TargetOptions. This is in preparation for supporting

r270520 - clang-c: de-anonymize structure declaration

2016-05-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 23 20:23:24 2016 New Revision: 270520 URL: http://llvm.org/viewvc/llvm-project?rev=270520=rev Log: clang-c: de-anonymize structure declaration The statement constructed an anonymous structure which was typedefed. The anonymous structure has internal linkage, and

r270392 - Driver: support exherbo's multiarch support

2016-05-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun May 22 21:17:28 2016 New Revision: 270392 URL: http://llvm.org/viewvc/llvm-project?rev=270392=rev Log: Driver: support exherbo's multiarch support Exherbo has an alternative file system layout to accommodate multiarch. The loader is located at

r270352 - Driver: sink getLinuxDynamicLoader into the Toolchain

2016-05-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat May 21 22:12:19 2016 New Revision: 270352 URL: http://llvm.org/viewvc/llvm-project?rev=270352=rev Log: Driver: sink getLinuxDynamicLoader into the Toolchain The parameter already requires the toolchain, sink the method into the class. This also enables the use of the

r270351 - Driver: simplify getDynameLinker

2016-05-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat May 21 20:37:36 2016 New Revision: 270351 URL: http://llvm.org/viewvc/llvm-project?rev=270351=rev Log: Driver: simplify getDynameLinker Convert the cascading if/else to a switch. This makes it easier to follow the logic. Minor difference is that we no longer default

r270180 - CodeGen: address -Wcast-qual warning

2016-05-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu May 19 22:58:12 2016 New Revision: 270180 URL: http://llvm.org/viewvc/llvm-project?rev=270180=rev Log: CodeGen: address -Wcast-qual warning Add a const_cast rather than the C-style cast. NFC. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified:

r269630 - CodeGen: convert some const char * to StringRef

2016-05-15 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 16 00:06:49 2016 New Revision: 269630 URL: http://llvm.org/viewvc/llvm-project?rev=269630=rev Log: CodeGen: convert some const char * to StringRef Convert some use of const char * to StringRef. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified:

[libcxxabi] r269255 - libc++abi: make __cxa_call_unexpected visible

2016-05-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed May 11 18:56:37 2016 New Revision: 269255 URL: http://llvm.org/viewvc/llvm-project?rev=269255=rev Log: libc++abi: make __cxa_call_unexpected visible This may be invoked by the compiler, and needs to be made available so that the users can reference it. Modified:

r268784 - test: attempt to repair windows build

2016-05-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri May 6 14:39:00 2016 New Revision: 268784 URL: http://llvm.org/viewvc/llvm-project?rev=268784=rev Log: test: attempt to repair windows build Replace use of /dev/null with /var/empty. lit will substitute the /dev/null include path resulting in failures. Use a path

r268777 - Frontend: support -I=path for sysroot expansion

2016-05-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri May 6 14:13:55 2016 New Revision: 268777 URL: http://llvm.org/viewvc/llvm-project?rev=268777=rev Log: Frontend: support -I=path for sysroot expansion From the GCC manpage: -I dir ... If dir begins with =, then the = will be replaced by the sysroot prefix;

[libcxxabi] r268477 - libc++abi: fix visibility of personalities

2016-05-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue May 3 23:22:29 2016 New Revision: 268477 URL: http://llvm.org/viewvc/llvm-project?rev=268477=rev Log: libc++abi: fix visibility of personalities The personality routines need to be exposed to the users as the functions reference the personality routine to handle

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-30 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. Committed as SVN r268167. Thanks for the patch! http://reviews.llvm.org/D17841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r268167 - python: add bindings for children of diagnostics

2016-04-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 30 16:14:01 2016 New Revision: 268167 URL: http://llvm.org/viewvc/llvm-project?rev=268167=rev Log: python: add bindings for children of diagnostics This exposes the Clang API bindings clang_getChildDiagnostics (which returns a CXDiagnosticSet) and

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-28 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:369 @@ +368,3 @@ +def __len__(self): +return int(conf.lib.clang_getNumDiagnosticsInSet(self.diag_set)) + Why

[libunwind] r267509 - unwind: remove last instance of -Wexpansion-to-defined

2016-04-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Apr 25 20:11:29 2016 New Revision: 267509 URL: http://llvm.org/viewvc/llvm-project?rev=267509=rev Log: unwind: remove last instance of -Wexpansion-to-defined This unifies the definition of _LIBUNWIND_BUILD_SJLJ_APIS. It also further generalises the definition to allow

[libunwind] r267365 - unwind: remove unnecessary header

2016-04-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 24 16:01:04 2016 New Revision: 267365 URL: http://llvm.org/viewvc/llvm-project?rev=267365=rev Log: unwind: remove unnecessary header Availablity.h is not used within config.h. The locations which use the availability infrastructure already include the necessary

[libunwind] r267364 - unwind: unify _LIBUNWIND_ABORT

2016-04-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 24 16:00:59 2016 New Revision: 267364 URL: http://llvm.org/viewvc/llvm-project?rev=267364=rev Log: unwind: unify _LIBUNWIND_ABORT Rather than use the `__assert_rtn` on libSystem based targets and a local `assert_rtn` function on others, expand the function

[libunwind] r267169 - unwind: unify some more macros

2016-04-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 22 12:11:05 2016 New Revision: 267169 URL: http://llvm.org/viewvc/llvm-project?rev=267169=rev Log: unwind: unify some more macros The macros were defined identically across both cases. Unify the definitions to have a single definition for

[libunwind] r266927 - unwind: remove another instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 17:18:50 2016 New Revision: 266927 URL: http://llvm.org/viewvc/llvm-project?rev=266927=rev Log: unwind: remove another instance of -Wexpansion-to-defined Remove the use of undefined behaviour in the c preprocessor by always defining the value according to the

[libunwind] r266926 - unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 17:18:47 2016 New Revision: 266926 URL: http://llvm.org/viewvc/llvm-project?rev=266926=rev Log: unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS Unify the definition of the _LIBUNWIND_SUPPORT_FRAME_APIS macro. This is in preparation to remove

[libunwind] r266915 - unwind: remove an instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:54:51 2016 New Revision: 266915 URL: http://llvm.org/viewvc/llvm-project?rev=266915=rev Log: unwind: remove an instance of -Wexpansion-to-defined This follows the pattern in the Apple clause duplicating a tuple of definitions. However, it will define them to

[libunwind] r266916 - unwind: remove a second instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:54:55 2016 New Revision: 266916 URL: http://llvm.org/viewvc/llvm-project?rev=266916=rev Log: unwind: remove a second instance of -Wexpansion-to-defined Remove the use of undefined behaviour in the c preprocessor by always defining the value according to the

[libunwind] r266913 - unwind: unify _LIBUNWIND_SUPPORT_DWARF_UNWIND

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:53:40 2016 New Revision: 266913 URL: http://llvm.org/viewvc/llvm-project?rev=266913=rev Log: unwind: unify _LIBUNWIND_SUPPORT_DWARF_UNWIND Join the two paths for this macro. At the end of the day, the difference was that MIPS and ARM on Apple have different

r266039 - Basic: fix profiling with GNU EABI

2016-04-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Apr 11 22:05:03 2016 New Revision: 266039 URL: http://llvm.org/viewvc/llvm-project?rev=266039=rev Log: Basic: fix profiling with GNU EABI The GNU profiling support indicates that the interface is `_mcount` rather than `mcount`. Conditionalise the behaviour according

r265899 - Correct pg instrumentation for AArch64

2016-04-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 10 09:29:55 2016 New Revision: 265899 URL: http://llvm.org/viewvc/llvm-project?rev=265899=rev Log: Correct pg instrumentation for AArch64 It seems that there was a miscommunication between Renato and I, and the original behaviour of AArch64 was to be preserved and

r265889 - test: add additional tests for SVN r265888

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 22:31:09 2016 New Revision: 265889 URL: http://llvm.org/viewvc/llvm-project?rev=265889=rev Log: test: add additional tests for SVN r265888 Add test cases for AArch64 as well as that was changed as part of that change. Modified:

r265888 - Add support for __gnu_mcount_nc as the pg interface

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 22:19:47 2016 New Revision: 265888 URL: http://llvm.org/viewvc/llvm-project?rev=265888=rev Log: Add support for __gnu_mcount_nc as the pg interface This adds support to optionally support using `__gnu_mcount_nc` as the mcount interface rather than `mcount` for

r265878 - Basic: thread TargetOptions into TargetInfo

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 14:09:25 2016 New Revision: 265878 URL: http://llvm.org/viewvc/llvm-project?rev=265878=rev Log: Basic: thread TargetOptions into TargetInfo This threads TargetOptions into the TargetInfo hierarchy. This is a rework of the original attempt to thread additional

r265807 - Move EABIVersion from CodeGenOptions to TargetOptions

2016-04-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 8 11:52:05 2016 New Revision: 265807 URL: http://llvm.org/viewvc/llvm-project?rev=265807=rev Log: Move EABIVersion from CodeGenOptions to TargetOptions It is possible to argue that the EABIVersion field is similar in spirit to the ABI field in TargetOptions. It

r265702 - Basic: move CodeGenOptions from Frontend

2016-04-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 7 12:49:44 2016 New Revision: 265702 URL: http://llvm.org/viewvc/llvm-project?rev=265702=rev Log: Basic: move CodeGenOptions from Frontend This is a mechanical move of CodeGenOptions from libFrontend to libBasic. This fixes the layering violation introduced

r265640 - Basic: thread CodeGenOptions into TargetInfo

2016-04-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 7 00:41:11 2016 New Revision: 265640 URL: http://llvm.org/viewvc/llvm-project?rev=265640=rev Log: Basic: thread CodeGenOptions into TargetInfo This threads CodeGenOptions into the TargetInfo hierarchy. This is motivated by ARM which can change some target

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

2016-03-08 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sorry about the delay with this change. Thanks for removing the parameter. I think that this is fine as is. Do you have commit rights, or should I commit this on your behalf?

r262780 - Misc: add a test for TargetParser usage

2016-03-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Mar 5 15:12:33 2016 New Revision: 262780 URL: http://llvm.org/viewvc/llvm-project?rev=262780=rev Log: Misc: add a test for TargetParser usage Ensure that an invalid value passed to target parser does not cause an assertion in +Asserts builds. Supporting test for

r262030 - Basic: fix __USER_LABEL_PREFIX__ on Cygwin

2016-02-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 26 10:34:01 2016 New Revision: 262030 URL: http://llvm.org/viewvc/llvm-project?rev=262030=rev Log: Basic: fix __USER_LABEL_PREFIX__ on Cygwin Adjust the user label prefix for cygwin x86_64. Resolves PR26744. Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D17349: ARM: fix VFP asm constraints

2016-02-18 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Yeah, constraint validation is not one of the highlights of the current implementation. This seems reasonable enough to merge I think.

r261192 - Sema: provide an extension warning for enable_if

2016-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 18 00:49:31 2016 New Revision: 261192 URL: http://llvm.org/viewvc/llvm-project?rev=261192=rev Log: Sema: provide an extension warning for enable_if Clang implements an enable_if attribute as an extension. Hook up `-Wpedantic` to issue an extension usage warning

Re: [PATCH] D17349: ARM: fix VFP asm constraints

2016-02-17 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd added a comment. Test cases? It seems that 't' and 'w' are not available in thumb-1 mode. http://reviews.llvm.org/D17349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-17 Thread Saleem Abdulrasool via cfe-commits
Feb 4, 2016 at 8:12 PM, Saleem Abdulrasool via cfe-commits > >> <cfe-commits@lists.llvm.org> wrote: > >>> > >>> Author: compnerd > >>> Date: Thu Feb 4 22:12:40 2016 > >>> New Revision: 259874 > >>> > >>> URL: http

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-17 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: lib/Headers/unwind.h:61 @@ +60,3 @@ +#define _UNWIND_ARM_EHABI 0 +#endif + logan wrote: > compnerd wrote: > > logan wrote: > > > Since this is `unwind.h`, I feel that we can get a step further and use > > >

Re: r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-16 Thread Saleem Abdulrasool via cfe-commits
On Thu, Feb 4, 2016 at 8:12 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Feb 4 22:12:40 2016 > New Revision: 259874 > > URL: http://llvm.org/viewvc/llvm-project?rev=259874=rev > Log: > CodeGen: correct Wind

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-16 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. This change seems fine to me as is, just waiting to iron out the macro situation with @logan before accepting it. Comment at: lib/Headers/unwind.h:61 @@ +60,3 @@ +#define _UNWIND_ARM_EHABI 0 +#endif + logan wrote: > Since this is

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-15 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. It was on the mailing list, which won't show up on phabricator (email is still the defacto review system). Why not create a local macro and use that to make this easier to read? #if defined(__arm__) && !defined(__USING_SJLJ_EXCEPTIONS__) &&

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-15 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd requested changes to this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision now requires changes to proceed. These should be guarded by a check to ensure that they are not defined when EHABI is not in effect at

r260867 - Sema: prevent assertion on stack return checking

2016-02-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 14 19:51:24 2016 New Revision: 260867 URL: http://llvm.org/viewvc/llvm-project?rev=260867=rev Log: Sema: prevent assertion on stack return checking In the case that the array indexing itself is within a type dependent context, bail out of the evaluation. We would

r260864 - Sema: constify EvalAddr, EvalVal

2016-02-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 14 18:36:49 2016 New Revision: 260864 URL: http://llvm.org/viewvc/llvm-project?rev=260864=rev Log: Sema: constify EvalAddr, EvalVal Propagate const throughout these methods as they are non-mutating analyzers of state. NFC. Modified:

r260865 - silence -Wreturn-type warnings

2016-02-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 14 18:36:52 2016 New Revision: 260865 URL: http://llvm.org/viewvc/llvm-project?rev=260865=rev Log: silence -Wreturn-type warnings These codepaths would generate warnings with GCC on linux even though the switch was covered. Add llvm_unreachable markers to indicate

[PATCH] D17239: Sema: typo correct both sides of binary expression

2016-02-12 Thread Saleem Abdulrasool via cfe-commits
compnerd created this revision. compnerd added a reviewer: rtrieu. compnerd added a subscriber: cfe-commits. When parsing a ternary expression, we would parse the middle and the last components of the expression. If there was a typo in both, we would only run the typo correction once. Normally,

[libcxx] r260195 - Use the reserved spellings for attributes

2016-02-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 8 22:05:37 2016 New Revision: 260195 URL: http://llvm.org/viewvc/llvm-project?rev=260195=rev Log: Use the reserved spellings for attributes Change the no_sanitize attribute to use the reserved spelling. Modified: libcxx/trunk/include/__config Modified:

[libcxx] r260071 - build: silence warnings in in-tree build

2016-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 7 21:50:18 2016 New Revision: 260071 URL: http://llvm.org/viewvc/llvm-project?rev=260071=rev Log: build: silence warnings in in-tree build Avoid the developer warnings from cmake when configuring libc++ as part of the LLVM layout. Setup the custom macro paths

r260011 - Index: provide adjustment thunk information for C++ manglings

2016-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 6 16:36:34 2016 New Revision: 260011 URL: http://llvm.org/viewvc/llvm-project?rev=260011=rev Log: Index: provide adjustment thunk information for C++ manglings Add support for exposing the adjustment thunk for virtual methods as appropriate. Modified:

r260019 - Driver: adjust linker invocation for GNUTools

2016-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 7 00:03:38 2016 New Revision: 260019 URL: http://llvm.org/viewvc/llvm-project?rev=260019=rev Log: Driver: adjust linker invocation for GNUTools Adjust the driver to invoke the linker more similar to gcc. -dynamic-linker is only passed if -static and -shared are

r260016 - Sema: handle typo correction with ARC'ed objc properties

2016-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 6 20:30:55 2016 New Revision: 260016 URL: http://llvm.org/viewvc/llvm-project?rev=260016=rev Log: Sema: handle typo correction with ARC'ed objc properties We would previously assert in findCapturingExpr when performing a typo correction resulting in an assignment

r260017 - Sema: handle typo correction on ARC'ed ivar

2016-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 6 20:30:59 2016 New Revision: 260017 URL: http://llvm.org/viewvc/llvm-project?rev=260017=rev Log: Sema: handle typo correction on ARC'ed ivar The ivar ref would be transformed by the Typo Correction TreeTransform, but not be owned, resulting in the source location

r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-04 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 4 22:12:40 2016 New Revision: 259874 URL: http://llvm.org/viewvc/llvm-project?rev=259874=rev Log: CodeGen: correct Windows ARM C++ assertion Because the Decl is explicitly passed as nullptr further up the call chain, it is possible to invoke isa on a nullptr,

Re: [PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

2016-02-01 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. I think it would be better if we could actually create a helper to get the profiling library name for a specific library, and use that in both locations. Do we have a test for the math case at the very least? http://reviews.llvm.org/D16264

Re: [PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

2016-01-30 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. `-p` or `-pg` also effects the math library. Please adjust the tests and the driver to reflect that. http://reviews.llvm.org/D16264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-11 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

r255273 - libclang: expose dllexport, dllimport attributes

2015-12-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Dec 10 12:45:18 2015 New Revision: 255273 URL: http://llvm.org/viewvc/llvm-project?rev=255273=rev Log: libclang: expose dllexport, dllimport attributes These attributes were previously unexposed. Expose them through the libclang interfaces. Add tests that cover both

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-10 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

r255328 - Driver: add multilibs for ARM EB

2015-12-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Dec 11 00:20:59 2015 New Revision: 255328 URL: http://llvm.org/viewvc/llvm-project?rev=255328=rev Log: Driver: add multilibs for ARM EB This improves the coverage for the multilib directories used for ARM. Also add tests covering the internal triple (thumbv7-*). The

r255225 - libclang: correct inverted logic

2015-12-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Dec 10 00:30:23 2015 New Revision: 255225 URL: http://llvm.org/viewvc/llvm-project?rev=255225=rev Log: libclang: correct inverted logic The complete dtor is only emitted when there is a virtual destructor. The test itself was incorrect, so the issue in the code was

[libcxxabi] r254690 - c++abi: whitespace adjustment

2015-12-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Dec 3 20:14:41 2015 New Revision: 254690 URL: http://llvm.org/viewvc/llvm-project?rev=254690=rev Log: c++abi: whitespace adjustment Cleanup some code with clang-format to make the following change easier to identify material difference. NFC. Modified:

[libcxxabi] r254692 - .gitignore: ignore vim swap files

2015-12-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Dec 3 20:15:02 2015 New Revision: 254692 URL: http://llvm.org/viewvc/llvm-project?rev=254692=rev Log: .gitignore: ignore vim swap files Modified: libcxxabi/trunk/.gitignore Modified: libcxxabi/trunk/.gitignore URL:

[libcxxabi] r254691 - ibc++abi: mark visibility

2015-12-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Dec 3 20:14:58 2015 New Revision: 254691 URL: http://llvm.org/viewvc/llvm-project?rev=254691=rev Log: ibc++abi: mark visibility Mark functions and types with the appropriate visibility. This is particularly useful for environments which explicitly indicate origin of

Re: r252853 - libclang: add clang_Cursor_getCXXManglings

2015-11-18 Thread Saleem Abdulrasool via cfe-commits
11, 2015 at 7:57 PM, Saleem Abdulrasool via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: compnerd >> Date: Wed Nov 11 21:57:22 2015 >> New Revision: 252853 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252853=rev >> Log: >> li

[libcxxabi] r253435 - c++abi: use __builtin_offsetof instead of offsetof

2015-11-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Nov 17 23:33:38 2015 New Revision: 253435 URL: http://llvm.org/viewvc/llvm-project?rev=253435=rev Log: c++abi: use __builtin_offsetof instead of offsetof Use `__builtin_offsetof` in place of `offsetof`. Certain environments provide a macro definition of `offsetof`

[clang-tools-extra] r253310 - modularize: add install rule

2015-11-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Nov 16 23:09:18 2015 New Revision: 253310 URL: http://llvm.org/viewvc/llvm-project?rev=253310=rev Log: modularize: add install rule This allows modularize to be installed. Previously, no install rule would be created for it. Modified:

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Wow, this is tricky: the code change is in LLVM, and test change in clang :(. However, this does seem to

r252853 - libclang: add clang_Cursor_getCXXManglings

2015-11-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Nov 11 21:57:22 2015 New Revision: 252853 URL: http://llvm.org/viewvc/llvm-project?rev=252853=rev Log: libclang: add clang_Cursor_getCXXManglings This function permits the mangling of a C++ 'structor. Depending on the ABI and the declaration, the declaration may

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

2015-11-05 Thread Saleem Abdulrasool via cfe-commits
On Wednesday, November 4, 2015, Tamas Berghammer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tberghammer created this revision. > tberghammer added a reviewer: echristo. > tberghammer added a subscriber: cfe-commits. > > Add new compiler flag to enable the generation of dwarf

Re: [PATCH] D14385: Correct atomic libcall support for __atomic_*_fetch builtins.

2015-11-05 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. Unfortunate that they have this crazy behavior. Comment at: lib/CodeGen/CGAtomic.cpp:901 @@ -897,1 +900,3 @@ + PostOp = llvm::Instruction::Add; +// Fall through. case AtomicExpr::AO__c11_atomic_fetch_add: I think we

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2015-11-02 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Yeah, this is a COFF limitation. Its unfortunate we don't have a better way to detect COFF targets.

r251729 - Sema: correct typo recovery with blocks

2015-10-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 30 19:39:15 2015 New Revision: 251729 URL: http://llvm.org/viewvc/llvm-project?rev=251729=rev Log: Sema: correct typo recovery with blocks Handle blocks in the tree transform for the typo correction as otherwise, the capture may miss. This would trigger an

Re: [PATCH] D14188: Format: support inline namespaces

2015-10-30 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r251690 with the mod. http://reviews.llvm.org/D14188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

2015-10-30 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. This looks like what I had in mind wrt use of `-meabi`. Comment at: lib/CodeGen/BackendUtil.cpp:524 @@ +523,3 @@ + .Case("5", llvm::EABI::Eabi5) + .Case("gnu", llvm::EABI::Gnu) + .Default(llvm::EABI::Default); I'd

[PATCH] D14188: Format: support inline namespaces

2015-10-29 Thread Saleem Abdulrasool via cfe-commits
compnerd created this revision. compnerd added a reviewer: djasper. compnerd added a subscriber: cfe-commits. Herald added a subscriber: klimek. Correct handling for C++17 inline namespaces. We would previously fail to identify the inline namespaces as a namespace name since multiple ones may be

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

2015-10-29 Thread Saleem Abdulrasool via cfe-commits
compnerd requested changes to this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision now requires changes to proceed. Please add a unit test for this. http://reviews.llvm.org/D14180 ___ cfe-commits mailing list

r251690 - Format: support inline namespaces

2015-10-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 30 00:07:56 2015 New Revision: 251690 URL: http://llvm.org/viewvc/llvm-project?rev=251690=rev Log: Format: support inline namespaces Correct handling for C++17 inline namespaces. We would previously fail to identify the inline namespaces as a namespace name since

r251599 - Driver: inline some small arrays

2015-10-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 28 22:36:42 2015 New Revision: 251599 URL: http://llvm.org/viewvc/llvm-project?rev=251599=rev Log: Driver: inline some small arrays Use an initializer list to remove a couple of small static arrays. NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

r251600 - Driver: CrossWindows sanitizers link support

2015-10-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 28 22:36:45 2015 New Revision: 251600 URL: http://llvm.org/viewvc/llvm-project?rev=251600=rev Log: Driver: CrossWindows sanitizers link support Add the required libraries to the linker invocation when building with sanitizers. Modified:

r251603 - test: fix overzealous match

2015-10-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 28 22:52:14 2015 New Revision: 251603 URL: http://llvm.org/viewvc/llvm-project?rev=251603=rev Log: test: fix overzealous match Accidentally made the test too strict. Modified: cfe/trunk/test/Driver/windows-cross.c Modified:

r251410 - Index: expose is_mutable_field

2015-10-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 27 10:50:22 2015 New Revision: 251410 URL: http://llvm.org/viewvc/llvm-project?rev=251410=rev Log: Index: expose is_mutable_field Expose isMutable via libClang and python bindings. Patch by Jonathan B Coe! Modified: cfe/trunk/bindings/python/clang/cindex.py

Re: [PATCH] D13874: Atomics: support __c11_* calls on _Atomic struct types

2015-10-27 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGAtomic.cpp:782 @@ +781,3 @@ + LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy); + AtomicInfo

r251493 - Driver: support -fuse-ld= on cross windows

2015-10-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 27 23:45:58 2015 New Revision: 251493 URL: http://llvm.org/viewvc/llvm-project?rev=251493=rev Log: Driver: support -fuse-ld= on cross windows Update the linker selection to support the `-fuse-ld=` option for selecting a linker. Added:

<    3   4   5   6   7   8   9   >