[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1679529 , @thakis wrote: > 4. Make it so that if DisableFormat is explicitly set to true and > SortIncludes isn't explicitly set, then it disables SortIncludes. Or, put a > different way, when DisableFormat is set,

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1677983 , @MyDeveloperDay wrote: > I assume the intention was that users could have DisableFormat=true and > SortIncludes=true when they want to sort the includes but not perform any > additional formatting in the

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier updated this revision to Diff 221065. SamMaier added a comment. Diff with more context Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67843/new/ https://reviews.llvm.org/D67843 Files: clang/lib/Format/Format.cpp clang/test/Format/disable-format.cpp

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. SamMaier added a reviewer: thakis. Previously, in order to have clang-format //not// format something, you had to give both: SortIncludes: false DisableFormat: true This is confusing to

[PATCH] D66964: Sort Java imports without newline

SamMaier added a comment. In D66964#1651496 , @yannic wrote: > Right now, this change only adds a test that shows the broken behavior. > > SamMaier@ you're the author of https://reviews.llvm.org/D52800 which > implemented Java import sorting. Is there a

[PATCH] D60203: Updating Chromium's Java import order

SamMaier added a comment. In D60203#1453313 , @thakis wrote: > Thanks! > > (Test?) We currently don't have tests for Chromium's specific Java import order. The tests for Java import order use their own order. Should this change? Repository: rC

[PATCH] D60203: Updating Chromium's Java import order

SamMaier created this revision. SamMaier added a reviewer: thakis. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Adding in androidx as another import group. Repository: rC Clang https://reviews.llvm.org/D60203 Files: lib/Format/Format.cpp Index:

[PATCH] D53434: Java annotation declaration being handled correctly

SamMaier created this revision. Herald added a subscriber: cfe-commits. Previously, Java annotation declarations (`@interface AnnotationName`) were being handled as ObjC interfaces. This caused the brace formatting to mess up, so that when you had a class with an interface defined in it, it

[PATCH] D52800: Java import sorting in clang-format

SamMaier added inline comments. Comment at: lib/Format/Format.cpp:1932 +bool IsStatic = false; +if (Static.contains("static")) { + IsStatic = true; krasimir wrote: > Hm, this would also pick up the `static` in `import a.*; // static`,

[PATCH] D52800: Java import sorting in clang-format

SamMaier updated this revision to Diff 168304. SamMaier marked 11 inline comments as done. SamMaier added a comment. Addressing comments Repository: rC Clang https://reviews.llvm.org/D52800 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CMakeLists.txt

[PATCH] D52800: Java import sorting in clang-format

SamMaier updated this revision to Diff 168111. SamMaier set the repository for this revision to rC Clang. SamMaier added a comment. Changed std::sort to llvm::sort Repository: rC Clang https://reviews.llvm.org/D52800 Files: include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D52800: Java import sorting in clang-format

SamMaier created this revision. Herald added subscribers: cfe-commits, mgrang, mgorny, srhines. This is for https://bugs.chromium.org/p/chromium/issues/detail?id=768983 - however it will be useful for anyone using clang-format for Java, not just Chromium. Repository: rC Clang