[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

sfantao added a comment. @tra, thank you for the patch. This makes sense. The patch looks good but it has to be someone else to okay it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao added a comment. In D21856#1338687 , @thakis wrote: > Sorry about the years-later question, but what's the motivation for shelling > out to an external command here? In general, LLVM tries to use a > library-based approach, and LLVM went e.g.

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added inline comments. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); + gtbercea wrote: > sfantao wrote: > > gtbercea wrote: > > > sfantao

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added a comment. Hi Doru, Thanks for updating the patch. I've a few comments below. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); +

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added a comment. > In a discussion off-list I proposed adding constructor functions to all > object files and handle them like shared libraries are already handled today > (ie register separately and let the runtime figure out how to relocate > symbols in different translation units).

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added a comment. @gtbercea, thanks for the patch. > INTEROPERABILITY WITH OTHER COMPILERS: These bundled object files can end up > being passed between Clang and other compilers which may lead to > incompatibilities: passing a bundled file from Clang to another compiler > would lead

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > sfantao wrote: > > Hahnfeld wrote: > > > Is that intentionally not in the `protected`

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao updated this revision to Diff 83236. sfantao marked 2 inline comments as done. sfantao added a comment. - Privatize Order, Flags and Kind of the offload entry. https://reviews.llvm.org/D28298 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao marked an inline comment as done. sfantao added a comment. Hi Jonas, Thanks for the review. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > Is that