[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added a comment. In D111490#3053564 , @xgupta wrote: > The patch is not applying cleanly so can't be committed. please follow the > above phabricator docs I suggested before to upload it. Oh there was an error in the web interface which

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378467. SamuelMarks added a comment. push/popd for build dirs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files: clang/docs/HowToSetupToolingForLLVM.rst clang/docs/LibASTMatchersTutorial.rst

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release xgupta wrote: > SamuelMarks wrote: > > xgupta wrote: > > > why removed `cd

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378466. SamuelMarks marked an inline comment as done. SamuelMarks added a comment. pushd/popd to the various build dirs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files:

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378463. SamuelMarks added a comment. Also updates appveyor to latest release version of ninja CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files: clang/docs/HowToSetupToolingForLLVM.rst

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release xgupta wrote: > why removed `cd ninja` & `git checkout release`? @xgupta To

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks created this revision. SamuelMarks added a project: LLVM. SamuelMarks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111490 Files:

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

SamuelMarks updated this revision to Diff 330487. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98594/new/ https://reviews.llvm.org/D98594 Files: clang/docs/HowToSetupToolingForLLVM.rst clang/docs/LibASTMatchersTutorial.rst Index: clang/docs/LibASTMatchersTutorial.rst

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

SamuelMarks created this revision. SamuelMarks added a project: LLVM. SamuelMarks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98594 Files: