[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

2017-01-04 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu added a comment. If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames array at all, The reason I had them in AddlRegNames was to tell Clang that they alias regs in GCCRegNames. I followed X86TargetInfo's example - it has "ax" in GCCRegNames, and "al", "ah",

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-21 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu added a comment. Would someone with a llvm bugzilla account please file the PR for me? New user registration is disabled, and I've been waiting for llvm-ad...@lists.llvm.org to respond for nearly a week now. And how should I proceed after that? Would one of the reviewers commit the

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-07 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu updated this revision to Diff 80721. saaadhu added a comment. Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead of short. {U,}INT16_TYPE still gets defined as short though - lib/Frontend/InitPreprocessor.cpp::DefineExactWidthIntType does not use

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-07 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu updated this revision to Diff 80575. saaadhu added a comment. Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ differences as well. I've added those defines to the test. Unrelated, but I also