[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski marked 5 inline comments as done. skirkovski added a comment. Rebased and fixed warning. My local compiler was yelling at me for adding a default case to switch which already covers everything. For the commit: Author: Seraphime Kirkovski email: skirkovski at vmware.com Repository:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 352753. skirkovski added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. Ping, I do not have commit access, can someone submit this as time permits ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. @MyDeveloperDay, Thanks for the review. I do not have submit access. Can you take care of landing the revision when you have some free time ? Comment at: clang/unittests/Format/FormatTest.cpp:1243 + verifyFormat("int *f1(int ) const & = 0;",

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351649. skirkovski marked 3 inline comments as done. skirkovski added a comment. Sort ReferenceAlignment after RawStringFormats in mapping() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351645. skirkovski added a comment. Remove PAS_Pointer from Webkit style (since it derives from LLVM which already has it) Add empty lines between style change in the test case Split a verifyFormat with 3 different cases into different ones Add test cases

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski created this revision. skirkovski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a roll-forward of D90238 originally implemented by @mrexodia and @catskul This introduces

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

skirkovski added a comment. In D90238#2810132 , @MyDeveloperDay wrote: > @curdeius , @HazardyKnusperkeks any thoughts, personally I don't have any > problems with this even if its not my personal preference. @skirkovski if > this is something you need

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

skirkovski added a comment. Hi @catskul, @MyDeveloperDay, Is there still interest in this feature ? My organization has had an internal implementation of this for years and I would like to replace it with an upstream version (and this one seems almost approved). Let me know if I can help