[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f87be6888d: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc (authored by barannikov88). Changed prior to commit: https://reviews.llvm.org/D159393?vs=557644=557657#toc

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557644. barannikov88 added a comment. Add a hyphen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added a comment. @aaron.ballman I added a release note as requested. Please see if it looks the way it should. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557643. barannikov88 added a comment. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557642. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added a comment. Should I create a github PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 ___ cfe-commits mailing list

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18a628ec4ef7: [AST] Use correct APSInt width when evaluating string literals (authored by barannikov88). Repository: rG LLVM Github Monorepo

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:35 +CXX11(clang::warn_unused_result) + // CHECK: __gnu__::__const__: 1 For the context, the attribute is defined with the following spellings: ``` let Spellings =

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 51. barannikov88 added a comment. Update one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 created this revision. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls, krytarowski, arichardson, dylanmckay. Herald added a reviewer: aaron.ballman. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers:

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7eaaba69906: [Parser] Parse string literal arguments of availability… (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 updated this revision to Diff 554497. barannikov88 added a comment. Update the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 Files: clang/lib/Parse/ParseDecl.cpp

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 created this revision. barannikov88 added reviewers: cor3ntin, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2349 + if (isVariadicStringLiteralArgument(Args[N])) { +for (; N < sizeof(uint32_t); N++) + Bits |= (1 << N); maskTrailingZeros might also be useful

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16413 +APSInt C = Char.getInt(); +Result.push_back(static_cast(C.getExtValue())); +if (!HandleLValueArrayAdjustment(Info, PtrExpression, String, CharTy, 1)) aaron.ballman

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. In D154290#4483055 , @cor3ntin wrote: > In D154290#4482975 , @barannikov88 > wrote: > >> According to the current wording, the static_assert-message is either >> unevaluated string

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

barannikov88 created this revision. barannikov88 added a reviewer: cor3ntin. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The width of the APSInt values should be the width of an element.

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. According to the current wording, the static_assert-message is either unevaluated string or an expression evaluated at compile time. Unevaluated strings don't allow certain escape sequences, but if I wrap the string in a string_view-like class, I'm allowed to use

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3883 + ///< message. +CCEK_StaticAssertMessageData, ///< Call to data() in a static assert + ///< message.

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added a comment. @cor3ntin I've been working on pretty much the same functionality in our downstream fork. I was not aware of the paper, nor of the ongoing work in this direction, and so I unfortunately missed the review. Thanks for this patch, it significantly reduces the number

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:138 - Implemented `P2738R1: constexpr cast from void* `_. +- Partially implemented `P2361R6: constexpr cast from void* `_. + The changes to

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:520 +static llvm::StructType *getAMDGPUKernelDescriptorType(llvm::LLVMContext ) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); + llvm::Type *Int16 = llvm::IntegerType::getInt16Ty(C);

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } JOE1994 wrote: > barannikov88 wrote: > > Just

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. Looks pretty straightforward. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty);

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG234890226861: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC) (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

barannikov88 updated this revision to Diff 535736. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153694/new/ https://reviews.llvm.org/D153694 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

barannikov88 updated this revision to Diff 534205. barannikov88 added a comment. - Remove unused argument of EmitDynamicCastToVoid - While here, adjust the name to start with lowercase letter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:90 +StoragePtr = CGF.Builder.CreateAddrSpaceCast( +StoragePtr, llvm::PointerType::getUnqual(CGF.getLLVMContext()), "atomic_bitfield_base"); I suppose

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr

barannikov88 created this revision. Herald added a project: All. barannikov88 updated this revision to Diff 534190. barannikov88 added a comment. barannikov88 added reviewers: nikic, JOE1994. barannikov88 published this revision for review. Herald added subscribers: cfe-commits, StephenFan. Herald

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. In D153229#134 , @IncludeGuardian wrote: > @barannikov88 no it's not. I was going to commit separately to keep the > change small, but it turns out that if I move this to the source file there > are no additional

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1610 +} + } while (NonComments < 2 and ReadCount > 0); + return NextNextToken; This is much more common. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1474 Address AtomicInfo::emitCastToAtomicIntPointer(Address addr) const { llvm::IntegerType *ty = as it no longer emits anything. Repository: rG LLVM Github Monorepo

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. Is SmallVector.h still required in Error.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cfe-commits mailing list

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. - I'd prefer Lex() over equivalent getParser().Lex() because it is shorter. - Ideally, every change should be tested. - The tests should be minimal. That is, they should be assembly files passed to llvm-mc rather than ll files passed to llc. I'm not very familiar

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG44e63ffe2bf7: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo.Type,

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo.Type,

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This needs to be rebased, there will be conflicts with 992cb984 . Comment at: clang/lib/CodeGen/CGBlocks.cpp:1264 -addr =

[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

barannikov88 abandoned this revision. barannikov88 added a comment. Abandoning as D148094 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147962/new/ https://reviews.llvm.org/D147962

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG992cb98462ab: [clang][CodeGen] Break up TargetInfo.cpp [8/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63534779b4ef: [clang][CodeGen] Break up TargetInfo.cpp [7/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 532358. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files:

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 532357. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files:

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4d48d73d39: [clang] Replace use of Type::getPointerTo() (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. In D152321#4428398 , @JOE1994 wrote: > With the updated revision, I don't see new test failures from `ninja > check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja > check-llvm-unit` . Thank you, it was my

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 requested changes to this revision. barannikov88 added a comment. This revision now requires changes to proceed. @JOE1994 Please run the testsuite locally (`ninja check-clang`), there is at least one test that crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. Herald added a subscriber: wangpc. Does the test have to be a C source? Why not just plain asm (fed into llvm-mc)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. I guess you need to rebase onto 066fb7a5 at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with CI fixed, thanks. I'd like @nikic to also take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. Please use clang-format on the modified lines. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine = "") { +return

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// equal or lower levels. This is used to

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4396739 , @Sedeniono wrote: > Oh damn, I executed `arc diff --update D151047` on the main branch instead of > my own local branch... Sorry. > Can I somehow revert that? Or should I simply use the "abandon review"

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. @efriedma Thank you for all your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 528209. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 528208. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8bd2a57849e: [clang][CodeGen] Break up TargetInfo.cpp [6/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151789: [test] Add llc to the list of known tools for clang tests (NFCI)

barannikov88 created this revision. Herald added a project: All. barannikov88 added a reviewer: erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some tests such as CodeGen/2005-09-24-AsmUserPrefix.c use llc. This

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150887#4373695 , @nikic wrote: > I wanted to check whether you plan to do more opaque pointer test conversions > in clang. Just to make sure we don't duplicate work... I'm done for now Repository: rG LLVM Github

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4369742 , @Sedeniono wrote: > To create a new fix, do I understand the guide > correctly that > I basically execute `arc diff --verbatim` and

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

barannikov88 added a comment. Hi, just a heads-up, some bots seem to be unhappy with the test: https://lab.llvm.org/buildbot/#/builders/216/builds/21765 error: 'note' diagnostics expected but not seen: File

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

barannikov88 added inline comments. Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.h:22 #include "mlir/Interfaces/SideEffectInterfaces.h" +#include IncludeGuardian wrote: > I wasn't sure if it is possible to include `` within `HLFIROps.td` so > it

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc01e9e75: [clang][CodeGen] Break up TargetInfo.cpp [5/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a86e05d1da0: [clang][CodeGen] Break up TargetInfo.cpp [4/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG940b02095bf9: [clang][CodeGen] Break up TargetInfo.cpp [3/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a646ed6835f: [clang][CodeGen] Break up TargetInfo.cpp [2/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2492f7cf0b1: [clang][CodeGen] Break up TargetInfo.cpp [1/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 added a comment. In D148089#4357219 , @rjmccall wrote: > Sergei, feel free to start landing patches like this one that were already > approved. You don't need the entire sequence to be approved first. Ah, OK! I thought it is required.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523846. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523845. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523844. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523843. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

barannikov88 updated this revision to Diff 523842. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

barannikov88 updated this revision to Diff 523841. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

barannikov88 updated this revision to Diff 523840. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 updated this revision to Diff 523839. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }*

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. In D150966#4356695 , @john.brawn wrote: >> Q: What is it the -Wsystem-header can warn about? I mean, no system header >> is included by the test, what can go wrong? > > The buffer is treated as a system header. I've

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }*

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. Q: What is it the -Wsystem-header can warn about? I mean, no system header is included by the test, what can go wrong? Comment at: clang/test/Preprocessor/predefined-macros-no-warnings.c:2 +// Check that the predefined macros don't contain

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. Is it possible/worth to add an assertion to Builder.defineMacro to enforce this one definition rule? Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1305 +Builder.defineMacro("__ELF__"); + } + Redundant braces.

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }*

[PATCH] D150829: [clang] Convert several tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf5f632ed53: [clang] Convert several tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150829/new/

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523240. barannikov88 added a comment. Undo remaining unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files:

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523236. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523235. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523232. barannikov88 added a comment. Update BUILD.gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523230. barannikov88 added a comment. Add a virtual destructor to DefaultABIInfo to pin the vtable to a cpp file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523227. barannikov88 added a comment. Move complexTempStructure to its only user (PPC.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files:

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 added a comment. These did require some intellectual work. I've noted changes that might be worth noticing. Comment at: clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp:22 +// CHECK: store i32 0, ptr @arr +// CHECK: call void @_ZN1AC1EPKc(ptr {{[^,]*}}

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 created this revision. barannikov88 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523163. barannikov88 added a comment. Rebase & ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523161. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523160. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523159. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

barannikov88 updated this revision to Diff 523158. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp

  1   2   3   >