[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

2022-03-23 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb planned changes to this revision. arcbbb added a comment. Herald added a subscriber: StephenFan. I started a discussion on how RVV clang builtins interact with FENV_ACCESS in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/147 I would drop this patch if those builtins are going

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

2022-03-03 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683 +Ops.push_back(VL); +Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy + } kito-cheng wrote: > Is this operand for tail policy? if so why this is `UNDEF`? I guess

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

2022-02-23 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb created this revision. arcbbb added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, monkchiang, eopXD, khchen. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D115709: [RISCV] Remove Zvamo Extention

2021-12-19 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb accepted this revision. arcbbb added a comment. This revision is now accepted and ready to land. LGTM too. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709

[PATCH] D111692: [RISCV] Remove Zvamo C intrinsics and builtins.

2021-10-13 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb added a reviewer: jrtc27. arcbbb added a comment. @jrtc27 commented to keep it in https://reviews.llvm.org/D105396?id=356342 LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111692/new/ https://reviews.llvm.org/D111692

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

2021-07-06 Thread ShihPo Hung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf1cbea3e5275: [RISCV] Remove Zvamo implication for v1.0-rc change (authored by arcbbb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105396/new/

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

2021-07-04 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 356369. arcbbb added a comment. Fix FileCheck prefix: ZVAMO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105396/new/ https://reviews.llvm.org/D105396 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

2021-07-03 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 356353. arcbbb retitled this revision from "[RISCV] Remove Zvamo extension for v1.0-rc change" to "[RISCV] Remove Zvamo implication for v1.0-rc change". arcbbb edited the summary of this revision. arcbbb added a comment. keep Zvamo0p10 and remove the

[PATCH] D105396: [RISCV] Remove Zvamo extension for v1.0-rc change

2021-07-03 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb created this revision. arcbbb added reviewers: rogfer01, frasercrmck, jrtc27, craig.topper, evandro, HsiangKai, khchen, kito-cheng. Herald added subscribers: vkmr, dexonsmith, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, jfb, the_o,

[PATCH] D103603: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

2021-06-04 Thread ShihPo Hung via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf8827a98be: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C (authored by arcbbb). Repository: rG LLVM

[PATCH] D103603: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

2021-06-03 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 349600. arcbbb marked an inline comment as done. arcbbb retitled this revision from "[Sema][RISCV] Allow ?: to select Typedef BuiltinType in C" to "[Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C". arcbbb added a reviewer: frasercrmck. arcbbb

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

2021-06-03 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb created this revision. arcbbb added reviewers: rsandifo-arm, efriedma, sdesmalen, rovka, rjmccall, rengolin, HsiangKai, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

2021-04-21 Thread ShihPo Hung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG11072a0bdbc0: [RISCV][Clang] Add RVV AMO builtins (authored by arcbbb). Changed prior to commit: https://reviews.llvm.org/D100448?vs=338419=339139#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

2021-04-18 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 338419. arcbbb added a comment. re-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/ https://reviews.llvm.org/D100448 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

2021-04-18 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 338416. arcbbb marked 3 inline comments as done. arcbbb added a comment. Addressed @khchen's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/ https://reviews.llvm.org/D100448 Files:

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

2021-04-18 Thread ShihPo Hung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG27edaee84e3e: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker… (authored by arcbbb). Changed prior to commit: https://reviews.llvm.org/D100615?vs=338004=338410#toc

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

2021-04-16 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb updated this revision to Diff 338004. arcbbb added a comment. Addressed @MaskRay 's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100615/new/ https://reviews.llvm.org/D100615 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

2021-04-15 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb created this revision. arcbbb added reviewers: asb, craig.topper, frasercrmck, rogfer01, jrtc27, mgrang. Herald added subscribers: vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

2021-04-14 Thread ShihPo Hung via Phabricator via cfe-commits
arcbbb created this revision. arcbbb added reviewers: craig.topper, rogfer01, khchen, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,