[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

scchan accepted this revision. scchan added a comment. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156426/new/ https://reviews.llvm.org/D156426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155213: [Driver] Add `-f[no-]offload-uniform-block`

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155213/new/ https://reviews.llvm.org/D155213 ___ cfe-commits mailing list

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:71 +In the above command, the ``--hip-link`` flag instructs Clang to link the HIP runtime library. However, +the use of this flag is unnecessary if a HIP input file is already present in your program. +

[PATCH] D155213: [HIP] Add `-fno-offload-uniform-block`

scchan added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2391 if (TargetDecl->hasAttr()) { if (getLangOpts().OpenCLVersion <= 120) { The block here needs to be aware of this new flag. CHANGES SINCE LAST ACTION

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 ___ cfe-commits mailing list

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:65 + + clang++ --offload-arch=gfx906 -xhip sample.cpp -o sample + missing --hip-link Comment at: clang/docs/HIPSupport.rst:77 + + clang++ --offload-arch=native -xhip

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 ___ cfe-commits mailing list

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc4bbb85c72: [HIP] Ignore host linker flags for device-only (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 541060. scchan added a comment. minor formatting fixes, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

scchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, arsenm wrote: > Can we avoid adding yet another

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 540481. scchan added a comment. added extra checks for not host, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 539173. scchan added a comment. addressed comments from yaxunl, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan created this revision. scchan added a reviewer: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When compiling in device only mode (e.g. --offload-device-only), the host linker

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:82 +=== + +1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via environment variables. I think

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 test.hip -o test.o + can we add -xhip to enable HIP for files without the .hip file ext? Comment at: clang/docs/HIPSupport.rst:56

[PATCH] D152207: [HIP] Instruct lld to go through all archives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aee32f1c85: [HIP] Instruct lld to go through all archives (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529667. scchan added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529400. scchan added a comment. Removed redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529366. scchan added a comment. added a matching --no-whole-archive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529311. scchan added a comment. fix some formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529061. scchan added a comment. remove ws Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529060. scchan added a comment. Updated patch to address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files:

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan created this revision. Herald added a subscriber: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add the --whole-archive flag when linking HIP programs to instruct lld to go

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

scchan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56184bb3ad3f: [AMDGCN] Fix device lib test to work with lib64 (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

scchan added a comment. In D142506#4078402 , @arsenm wrote: > The resource directory should be strictly controlled. why would lib64 ever be > used here? The intention is to eventually move the device libs into the library directory inside clang's

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

scchan created this revision. scchan added reviewers: yaxunl, mgorny. Herald added subscribers: kosarev, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes an issue introduced by

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4076614 , @mgorny wrote: > I'm sorry for reporting it this late (clang's been broken for over two weeks, > so we couldn't periodically test it) but this change is causing test > regressions on Gentoo/amd64: Thanks

[PATCH] D140315: [AMDGCN] Update search path for device libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18fe67b9fcf: [AMDGCN] Update search path for device libraries (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4011440 , @yaxunl wrote: > files under > clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem > not used. removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan updated this revision to Diff 484945. scchan added a comment. Remove unused bitcode files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add support for finding

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGcecb0e98d4b1: [HIP] stop forcing the lang std in the driver (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134314/new/

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

scchan created this revision. scchan added a reviewer: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D103221 changed HIP's default to C++14, removing

[PATCH] D133705: [HIP] Fix unbundling archive

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 ___ cfe-commits mailing list

[PATCH] D133705: [HIP] Fix unbundling archive

scchan requested changes to this revision. scchan added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959 + if (FoundAOB) +break; } The AOBFileNames small vector needs to

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

scchan created this revision. scchan added reviewers: yaxunl, saiislam, ronlieb. Herald added a project: All. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix backward compatibility issue due to D120662

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 420218. scchan added a comment. - fixed the hip-link-bundle-archive.hip test issue on Windows - fixed a couple of formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 419847. scchan added a comment. update the failing lit tests to recognize the new switches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 Files:

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 418711. scchan added a comment. update the clang-offload-bundler-asserts-on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 Files:

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 418710. scchan added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. fix lit test failures on Windows, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: asavonic, kerbowa, jvesely. Herald added a reviewer: alexander-shaposhnikov. scchan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D106571: [HIP] Fix visibility of __hip_fatbin

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106571/new/ https://reviews.llvm.org/D106571 ___ cfe-commits mailing list

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

scchan added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:29 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static constexpr __attribute__((always_inline, nothrow)) +#define __constant__ __attribute__((constant)) `__DEVICE__` should not

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan updated this revision to Diff 353041. scchan added a comment. Minor clean up in the hip-header.hip test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104392/new/ https://reviews.llvm.org/D104392 Files:

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan updated this revision to Diff 353035. scchan added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104392/new/ https://reviews.llvm.org/D104392 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan created this revision. scchan added a reviewer: yaxunl. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add runtime functions to detect invalid calls to pure or deleted virtual functions Repository: rG LLVM Github

[PATCH] D85471: Make clang HIP headers compatible with C++98

scchan created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. scchan requested review of this revision. Automation to detect compiler features, such as CMake's target_compile_features, would attempt to detect compiler features by explicitly using

[PATCH] D48493: [HIP] Support flush denorms bitcode

scchan added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D48493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31210: [AMDGPU] Add new address space mapping

scchan added a comment. In https://reviews.llvm.org/D31210#706955, @yaxunl wrote: > In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > > > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > > > I'm concerned about the default address space to be 64 bit. It would move >