[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

2023-09-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG06c9cc7eaa8a: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

2023-09-12 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @tahonermann for reviews and feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159474/new/ https://reviews.llvm.org/D159474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

2023-09-08 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 556273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159474/new/ https://reviews.llvm.org/D159474 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

2023-09-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. Manna requested review of

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-09-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158293#4629232 , @tahonermann wrote: > Thanks, Soumi, looks good to me! Thank you @tahonermann for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-09-05 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rG33b02d766eb8: [NFC][Clang] Fix static code analyzer concern about null value dereference (authored by

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + assert(CurLexer && "Invalid lexer value");

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 554810. Manna added a comment. This patch splits all predicates and updates assert messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 Files: clang/lib/Lex/PPDirectives.cpp Index:

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 554762. Manna marked an inline comment as done. Manna added a comment. Thanks @tahonermann for review and feedback. I have added an assert separately to tell which predicate failed if a failure occurs in future. CHANGES SINCE LAST ACTION

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158227#4610219 , @dyung wrote: > In D158227#4610097 , @Manna wrote: > >> The failure seems unrelated to my change. > > Hi @Manna, I'm not sure which failure you are referring to, but

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c60ec52f15: [NFC][CLANG] Fix static analyzer bugs about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Failure is unrelated to my patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. The failure seems unrelated to my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - useless call (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:555 while (true) { CurLexer->Lex(Tok); tahonermann wrote: > I don't think this change is sufficient. If `CurLexer` is null, then the

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 552706. Manna edited the summary of this revision. Manna removed reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 Files:

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. This has already been addressed by https://reviews.llvm.org/D157989 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158522#4607628 , @tahonermann wrote: > Looks fine to me! Thanks @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 552428. Manna added a comment. Fix build errors. I have updated CodeGenFunction.h as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158522#4607054 , @sdesmalen wrote: > It indeed makes sense to pass these by reference. Thank you @sdesmalen for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project:

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @aaron.ballman for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 552347. Manna retitled this revision from "[NFC][CLANG] Fix potential dereferencing of null return values" to "[NFC][Clang] Fix static code analyzer concern about null value dereference". Manna added a comment. Herald added subscribers: manas, ASDenysPetrov,

[PATCH] D158295: [NFC][clang][analyzer] Avoid potential dereferencing of null pointer value

2023-08-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a

[PATCH] D158293: [NFC][CLANG] Fix potential dereferencing of null return values

2023-08-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Manna requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

2023-08-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-17 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: RKSimon, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53426 Repository: rG LLVM Github Monorepo

[PATCH] D157989: [NFC] Initialize pointer field

2023-08-16 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1ddc5850b1: [NFC][OpenMP] Initialize pointer field (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/

[PATCH] D157989: [NFC] Initialize pointer field

2023-08-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @tahonermann for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/ https://reviews.llvm.org/D157989 ___ cfe-commits mailing list

[PATCH] D157989: [NFC] Initialize pointer field

2023-08-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. Manna requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

2023-06-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa806ec4857c2: [analyzer] Refactor codes in findMethodDecl() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152194/new/

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

2023-06-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7372c0d46d21: [CLANG] Fix potential integer overflow value in getRVVTypeSize() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG213709e7be03: [CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @tahonermann and @tra for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && + LHSBuiltinTy && RHSBuiltinTy &&

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG982a87ab74d8: [CLANG] Fix potential null pointer dereference bugs (authored by Manna). Changed prior to commit: https://reviews.llvm.org/D153033?vs=532138=533742#toc Repository: rG LLVM Github

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you for reviews @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG11528fceac6b: [Clang] Fix Static Code Analysis Concerns with copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @tahonermann and @aaronpuchert for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you everyone for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5e12f5ab2df1: [CLANG] Fix uninitialized scalar field issues (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 533589. Manna edited the summary of this revision. Manna added a comment. Thank you @erichkeane for review and comments. I have changed the types of variables MinElts and EltSize to uint64_t instead of the cast. CHANGES SINCE LAST ACTION

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. ping @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added a comment. ping @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. In getRVVTypeSize(clang::​ASTContext &, clang::​BuiltinType const *) potential integer overflow occurs

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368 - VD = VD->getCanonicalDecl(); + VD = cast(VD->getCanonicalDecl()); auto I = FunctionGlobalizedDecls.find(CGF.CurFn);

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 532138. Manna added a comment. Address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane and @steakhal for reviews and comments. In D152194#4402377 , @steakhal wrote: > Please update the title and the summary of this patch to reflect what it > actually achieves. > We also usually use the

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:505-511 const unsigned *i = C.lookup(D); llvm::errs() << " -> "; + if (!i) { +llvm::errs() << "<>"; +return; + } dumpVarDefinitionName(*i);

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531976. Manna retitled this revision from "[NFC][CLANG] Fix potential null pointer dereference bugs" to "[CLANG]Fix potential null pointer dereference bugs". Manna added a comment. Herald added subscribers: steakhal, martong. Address review comment and update

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531773. Manna added a comment. Update patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSafety.cpp

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531766. Manna added a comment. Fix build error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSafety.cpp

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match and adds nullptr

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).EC !=

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 529138. Manna retitled this revision from "[NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()" to "Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()". Manna edited the

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 529133. Manna retitled this revision from "[NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool" to "[StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool". Manna edited the summary of this revision. Manna added a

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with dereference after null check

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756 if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() || ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) { const

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision.

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3581e6b857f4: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152107/new/ https://reviews.llvm.org/D152107 ___ cfe-commits mailing list

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

2023-06-04 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match

[PATCH] D151010: [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool

2023-06-04 Thread Soumi Manna via Phabricator via cfe-commits
Manna abandoned this revision. Manna added a comment. This is False Positive. Closing the PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

2023-06-04 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb0525f66988e: [NFC][CLANG] [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151928/new/

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns

2023-06-04 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc7550310738b: [NFC][CLANG] Fix Static Code Analyzer Concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151947/new/

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG82659941ccb8: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG02ce49afb9a0: [NFC][CLANG] Fix bug with dereference null return value in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:956 // Determine whether the type argument is substitutable for the bound. if (typeArgObjC->isObjCIdType()) { // When the type argument is 'id', the only acceptable type

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/ https://reviews.llvm.org/D151957 ___ cfe-commits mailing list

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151947/new/ https://reviews.llvm.org/D151947 ___ cfe-commits mailing list

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

2023-06-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151928/new/ https://reviews.llvm.org/D151928 ___ cfe-commits mailing list

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

2023-06-01 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

2023-06-01 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match In

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concern with nullptr dereference issue

2023-06-01 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

2023-06-01 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in ConvertQualTypeToKind(clang::​ASTContext

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

2023-05-31 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb069246573: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

2023-05-31 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG071d4ab377d3: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

2023-05-31 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151770/new/ https://reviews.llvm.org/D151770 ___ cfe-commits mailing list

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

2023-05-31 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp === ---

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526877. Manna added a comment. Rebase the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna abandoned this revision. Manna added a comment. Closing this PR. Codes give an assert for unknown type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151770/new/ https://reviews.llvm.org/D151770

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in SetValueDataBasedOnQualType(clang::​Value

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Manna requested review of this

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcf236a037fd8: [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151529/new/

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0c05128aeaf8: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151721/new/ https://reviews.llvm.org/D151721 ___ cfe-commits mailing list

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526647. Manna added a comment. Thank you @erichkeane for reviews! I have updated assert message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151529/new/ https://reviews.llvm.org/D151529 Files: clang/lib/Sema/SemaTemplateDeduction.cpp Index:

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf64f760e2d20: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

2023-05-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151525/new/ https://reviews.llvm.org/D151525 ___ cfe-commits mailing list

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

2023-05-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a5aeadb558: [NFC][CLANG] Fix issue with dereference null return value in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf59795b2b703: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151480/new/

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526264. Manna added a comment. Fix clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 Files: clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

2023-05-27 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 526259. Manna added a comment. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

2023-05-26 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: mattd, gchakrabarti, asavonic, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

2023-05-25 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e7c6e9e080: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

2023-05-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. DeduceTemplateArgumentsByTypeMatch() returns null value which is dereferenced without checking since getAsIncompleteArrayType()

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

2023-05-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match

  1   2   3   >