Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

2016-10-19 Thread Stefan Kempf via cfe-commits
Brad Smith wrote: > On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote: > > On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: > > > Author: emaste > > > Date: Fri Oct 14 12:59:53 2016 > > > New Revision: 284256 > > > > > > URL:

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

2016-09-10 Thread Stefan Kempf via cfe-commits
Ed Maste wrote: > emaste added a comment. > > Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's > toolchain. Could you commit it please if it looks ok? This diff is what OpenBSD has in its tree. We'd like to get it upstream. > https://reviews.llvm.org/D22130 > > >

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

2016-09-05 Thread Stefan Kempf via cfe-commits
sisnkemp added a comment. Ping? https://reviews.llvm.org/D22130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

2016-08-15 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 68046. sisnkemp added a comment. Now with test case. https://reviews.llvm.org/D22130 Files: lib/Driver/Tools.cpp test/Driver/openbsd.c Index: test/Driver/openbsd.c === ---

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

2016-08-09 Thread Stefan Kempf via cfe-commits
sisnkemp added a comment. Ping? https://reviews.llvm.org/D22130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

2016-07-08 Thread Stefan Kempf via cfe-commits
sisnkemp created this revision. sisnkemp added a reviewer: rafael. sisnkemp added a subscriber: cfe-commits. When building a static PIE binary, linking against /usr/lib/crt0.o results in segfaults when trying to run the binary. Static PIE programs must link against /usr/lib/rcrt0.o instead to

Re: r253886 - Disable frame pointer elimination when using -pg

2015-11-24 Thread Stefan Kempf via cfe-commits
Hi, David Blaikie via cfe-commits wrote: > On Mon, Nov 23, 2015 at 9:30 AM, Xinliang David Li via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: davidxl > > Date: Mon Nov 23 11:30:31 2015 > > New Revision: 253886 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=253886=rev >

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-23 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40933. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-20 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40794. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-20 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40793. sisnkemp added a comment. Added a test with -momit-leaf-frame-pointer as requested by davidxl. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp-1.c

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-15 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40230. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-08 Thread Stefan Kempf via cfe-commits
sisnkemp added a comment. Ping. Can somebody please comment on this? http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-08 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 39651. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c

[PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-01 Thread Stefan Kempf via cfe-commits
sisnkemp created this revision. sisnkemp added a subscriber: cfe-commits. When using -pg in combination with optimizations (e.g. -O3), compiled programs crash in the profiling routine mcount(). This is because mcount (on x86_64 at least) relies on the frame pointer to be valid. See test case to