[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#4107816 , @jansvoboda11 wrote: > @stella.stamenova ping Thanks for the reminder! I spent some time looking for a combination of VS + Win 10 SDK that would work with the new flag, and I believe I've found

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3921902 , @jansvoboda11 wrote: > @stella.stamenova Any updates? We haven't had time to come up with a proper solution yet. One short-term solution (assuming there's urgency in making the change) would be to

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3902772 , @jansvoboda11 wrote: > In D135128#3902698 , > @stella.stamenova wrote: > >> This caused some failures on the windows mlir buildbot: >>

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128

[PATCH] D133773: [clang] fix linker executable path in test

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. In D117977#3680655 , @stella.stamenova wrote: > This change broke the `LLVMConfig` generation and now when including `llvm` > through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no > longer have

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. This change broke the `LLVMConfig` generation and now when including `llvm` through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no longer have the correct paths. For example, before this change: set(LLVM_TOOLS_BINARY_DIR

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9bef0707db1: [clang-format] Fix incorrect isspace input (NFC) (authored by kevcadieux, committed by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of this change to also point to >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. Can we update the lldb instructions as part of this change to also point to VS2019? Alternatively, I can send a separate change for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3192823 , @stella.stamenova wrote: > In D114639#3191752 , @RKSimon wrote: > >> @rnk @stella.stamenova How long do you think it will be before you can >> update your

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3191752 , @RKSimon wrote: > @rnk @stella.stamenova How long do you think it will be before you can update > your buildbots to VS2019 or VS2022 please? The mlir buildbot was updated already. The lldb buildbot

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3160031 , @mehdi_amini wrote: > In D114639#3158401 , @RKSimon wrote: > >>> Have you checked whether there are any bots in the lab that will need to be >>> updated?

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. In D88666#2828306 , @thakis wrote: > We also see check-all timeout recently (fairly consistently), see > https://bugs.chromium.org/p/chromium/issues/detail?id=1221702 > > Since Stella reported problems with this too, I

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm not running all of the clang tests repeatedly to see if I can get a repro that way. The online tests appear to always hang either in the InitialScanAsync or

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. This is the best I can do from the online builds. I'll try and repro locally as well: FAIL: Clang-Unit :: DirectoryWatcher/./DirectoryWatcherTests.exe/DirectoryWatcherTest.InitialScanAsync (75980 of 75980) TEST 'Clang-Unit ::

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. In D88666#2825300 , @compnerd wrote: > Interesting, are the logs from the runs available? I have run the test > ~1 times locally and its been stable. Perhaps the logs can show what is > going on. Unfortunately,

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

stella.stamenova created this revision. stella.stamenova added a reviewer: v.g.vassilev. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The library depends on Attributes.inc, so it has

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

stella.stamenova added a comment. This change is generating warnings when building with clang: /usr/bin/clang++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Basic

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

stella.stamenova added a comment. It looks like this caused a couple of failures on the Windows LLDB bot due to crashes in clang: https://lab.llvm.org/buildbot/#/builders/83/builds/7142 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/

[PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. Herald added a reviewer: JDevlieghere.

[PATCH] D68997: Allow searching for prebuilt implicit modules.

stella.stamenova added a comment. This change broke the windows lldb bot: http://lab.llvm.org:8011/#/builders/83/builds/570 Can you please fix this or revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

stella.stamenova added a comment. It looks like this broke the windows lldb buildbot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15542 It already had a test failure, so you probably didn’t get the email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. In D73534#1880790 , @stella.stamenova wrote: > I am not sure this was the cause of the failure, but other than your patches, > there was only one other change in the first failing build. I have not had > time to fully

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. It looks like this broke the windows lldb bot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13902 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

stella.stamenova added a comment. This also broke a number of the tests on the Windows LLDB bot, so when you get around to resubmitting the change with a fix, please make sure the bot doesn't get broken again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12551 Repository:

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

stella.stamenova added a comment. This broke the windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11751 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova added a comment. @thakis Thanks for the information, I had actually missed that. The way this test is written, it needs to use a directory (so %T is "correct"), but to remove %T, it could be changed to use something like ```%t.doesnotexist.somename``` instead. If you feel

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

This revision was automatically updated to reflect the committed changes. Closed by commit rC352252: Fixed frontend clang tests in windows read-only container (authored by stella.stamenova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. Thanks. You have to change a couple of the locations to '%T' though - '%t' is a file and '%T' is a directory - and you're using '%t' as a directory in a couple

[PATCH] D56829: Move decl context dumping to TextNodeDumper

stella.stamenova added a comment. It looks like this change broke a number of the LLDB tests: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/781 Could you look into this or revert the change, so that the bot can go back to green? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: test/Frontend/output-failures.c:1 -// RUN: not %clang_cc1 -emit-llvm -o %S/doesnotexist/somename %s 2> %t -// RUN: FileCheck

[PATCH] D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows (authored by stella.stamenova, committed by ).

[PATCH] D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: kadircet, asmith. Herald added a subscriber: cfe-commits. The test passes on Windows only when it is executed on the C: drive. If the build and tests run on a different drive, the test is currently failing. Repository:

[PATCH] D51354: Fix the -print-multi-directory flag to print the selected multilib.

stella.stamenova added a comment. I saw this test fail in our testing as well. I think the matches are too broad and I suspect this will fail intermittently on the bots too causing confusion: Command Output (stderr): --

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339074: [lit, python] Always add quotes around the python path in lit (authored by stella.stamenova, committed by ).

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

stella.stamenova updated this revision to Diff 159395. Repository: rC Clang https://reviews.llvm.org/D50281 Files: test/Tooling/clang-diff-json.cpp Index: test/Tooling/clang-diff-json.cpp === ---

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, zturner. Herald added a subscriber: cfe-commits. The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by

[PATCH] D46485: Add python tool to dump and construct header maps

stella.stamenova added a comment. This breaks the clang tests on Windows when building using Visual Studio as none of the updated tests can find hmaptool. Visual Studio as a generator supports multiple configurations, so its bin folder varies depending on the build configuration. The