[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

stbergmann wrote: I think the discourse thread [Clang is overly aggressive when evaluating constexpr functions](https://discourse.llvm.org/t/clang-is-overly-aggressive-when-evaluating-constexpr-functions/67006) is relevant here. https://github.com/llvm/llvm-project/pull/77753

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

stbergmann wrote: This change started to cause ``` $ cat test.cc template struct P { ~P() { p->f(); } T * p; }; struct X; struct B { virtual ~B(); }; struct S: B { P x; }; ``` ``` $ clang++ -std=c++23 -fsyntax-only test.cc test.cc:2:13: error: member access into incomplete type 'X' 2

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

stbergmann wrote: This change started to break the following C++26 code: ``` $ cat test.cc enum E1 { E11 }; enum E2 { E21 = E11, E22 = 1, E23 = E21 + E22 }; ``` ``` clang++ -std=c++26 -fsyntax-only test.cc test.cc:5:15: error: invalid arithmetic between different enumeration types

[clang] d812488 - Call MarkVirtualMembersReferenced on an actual class definition

Author: Stephan Bergmann Date: 2023-03-02T15:50:12+01:00 New Revision: d812488d3c54c07f24d4bef79e329f17e7f19c3b URL: https://github.com/llvm/llvm-project/commit/d812488d3c54c07f24d4bef79e329f17e7f19c3b DIFF:

[clang] 4996e3f - [test] Check for more -fsanitize=array-bounds behavior

Author: Stephan Bergmann Date: 2022-07-05T08:12:53+02:00 New Revision: 4996e3f68315f9ee7f43f2de9d368ab9979080db URL: https://github.com/llvm/llvm-project/commit/4996e3f68315f9ee7f43f2de9d368ab9979080db DIFF:

[clang] b5b9489 - Only consider built-in compound assignment operators for -Wunused-but-set-*

Author: Stephan Bergmann Date: 2021-06-14T08:04:03+02:00 New Revision: b5b9489b2415dc48c39d4d7d4bae6197dc499f38 URL: https://github.com/llvm/llvm-project/commit/b5b9489b2415dc48c39d4d7d4bae6197dc499f38 DIFF:

[clang] 215ed9b - Adapt CastExpr::getSubExprAsWritten to ConstantExpr

Author: Stephan Bergmann Date: 2021-01-12T09:41:03+01:00 New Revision: 215ed9b33ccbe9858aeb65b357bdcff354be URL: https://github.com/llvm/llvm-project/commit/215ed9b33ccbe9858aeb65b357bdcff354be DIFF:

[clang] 7a5184e - [scan-build] Fix clang++ pathname again

Author: Stephan Bergmann Date: 2020-11-03T08:17:17+01:00 New Revision: 7a5184ed951ad38d652d7b3c339f4c6ae7842eeb URL: https://github.com/llvm/llvm-project/commit/7a5184ed951ad38d652d7b3c339f4c6ae7842eeb DIFF:

Re: r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

On 09/10/2019 04:04, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 8 19:04:54 2019 New Revision: 374135 URL: http://llvm.org/viewvc/llvm-project?rev=374135=rev Log: [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue whose value is not ignored. We don't

r375104 - Include leading attributes in DeclStmt's SourceRange

Author: sberg Date: Thu Oct 17 04:20:21 2019 New Revision: 375104 URL: http://llvm.org/viewvc/llvm-project?rev=375104=rev Log: Include leading attributes in DeclStmt's SourceRange Differential Revision: https://reviews.llvm.org/D68581 Modified: cfe/trunk/lib/Parse/ParseStmt.cpp

r369345 - Rudimentary support for Doxygen \retval command

Author: sberg Date: Tue Aug 20 01:36:21 2019 New Revision: 369345 URL: http://llvm.org/viewvc/llvm-project?rev=369345=rev Log: Rudimentary support for Doxygen \retval command ...so that at least a preceding \param etc. that lacks a description gets a -Wdocumentation warning (instead of

r366186 - Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

Author: sberg Date: Mon Jul 15 23:23:27 2019 New Revision: 366186 URL: http://llvm.org/viewvc/llvm-project?rev=366186=rev Log: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO" i.e., recent 5745eccef54ddd3caca278d1d292a88b2281528b: * Bump the function_type_mismatch handler

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue May 21 16:15:20 2019 New Revision: 361329 URL: http://llvm.org/viewvc/llvm-project?rev=361329=rev Log: [c++20] P1330R0: permit simple-assignments that change the active member of a union within constant

Re: r360308 - [c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whose

On 15/05/2019 18:16, Stephan Bergmann wrote: The below commit started to cause the following failure: ...and which apparently got fixed in the meantime, presumably by "Make tentative parsing to detect

Re: r360308 - [c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whose

The below commit started to cause the following failure: $ cat test.cc template struct S1 { static int const n = 0; }; template struct S2 { typedef int t; }; template struct S3 { typename S2::n < 0, int>::t n; }; $ clang++ -fsyntax-only test.cc test.cc:3:53: error: use 'template' keyword to

r359759 - Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

Author: sberg Date: Wed May 1 23:40:33 2019 New Revision: 359759 URL: http://llvm.org/viewvc/llvm-project?rev=359759=rev Log: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO This follows up after b7692bc3e9ad2691fc07261904b88fb15f30696b "[UBSan] Fix isDerivedFromAtOffset on iOS

r353931 - Look through typedefs in getFunctionTypeWithExceptionSpec

Author: sberg Date: Wed Feb 13 01:39:17 2019 New Revision: 353931 URL: http://llvm.org/viewvc/llvm-project?rev=353931=rev Log: Look through typedefs in getFunctionTypeWithExceptionSpec Fixes https://bugs.llvm.org/show_bug.cgi?id=40658 Differential Revision: https://reviews.llvm.org/D58056

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

On 04/10/2018 01:14, Richard Smith wrote: On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Sep 27 18:16:43 2018 &g

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead of

r326990 - Propagate DLLAttr to friend re-declarations of member functions

Author: sberg Date: Wed Mar 7 23:34:40 2018 New Revision: 326990 URL: http://llvm.org/viewvc/llvm-project?rev=326990=rev Log: Propagate DLLAttr to friend re-declarations of member functions ...that have already been constructed (e.g., in inner classes) while parsing the class definition. They

r321861 - Commit new test file forgotten in previous commit

Author: sberg Date: Thu Jan 4 23:59:57 2018 New Revision: 321861 URL: http://llvm.org/viewvc/llvm-project?rev=321861=rev Log: Commit new test file forgotten in previous commit Added: cfe/trunk/test/CodeGenCXX/ubsan-function-noexcept.cpp Added:

r321859 - No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

Author: sberg Date: Thu Jan 4 23:57:12 2018 New Revision: 321859 URL: http://llvm.org/viewvc/llvm-project?rev=321859=rev Log: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17 As discussed in the mail thread

r321519 - -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid

Author: sberg Date: Thu Dec 28 04:45:41 2017 New Revision: 321519 URL: http://llvm.org/viewvc/llvm-project?rev=321519=rev Log: -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid ...when such an operation is done on an object during con-/destruction. This is the cfe part of

Re: r320982 - Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17"

On 12/19/2017 01:58 PM, Richard Smith wrote: On 18 Dec 2017 15:23, "Stephan Bergmann via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: On 12/18/2017 03:05 PM, Richard Smith wrote: Can we just strip the noexcept from th

Re: r320982 - Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17"

main() { g(reinterpret_cast(f)); } On 18 Dec 2017 13:52, "Stephan Bergmann via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: Author: sberg Date: Mon Dec 18 05:51:48 2017 New Revision: 320982 URL: http://llvm.org/v

r320982 - Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17"

Author: sberg Date: Mon Dec 18 05:51:48 2017 New Revision: 320982 URL: http://llvm.org/viewvc/llvm-project?rev=320982=rev Log: Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17" At least

r320978 - No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

Author: sberg Date: Mon Dec 18 05:05:42 2017 New Revision: 320978 URL: http://llvm.org/viewvc/llvm-project?rev=320978=rev Log: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17 As discussed in the mail thread

r320135 - In stdbool.h, define bool, false, true only in gnu++98

Author: sberg Date: Fri Dec 8 00:28:08 2017 New Revision: 320135 URL: http://llvm.org/viewvc/llvm-project?rev=320135=rev Log: In stdbool.h, define bool, false, true only in gnu++98 GCC has meanwhile corrected that with the similar "C++11

r318530 - Indent code blocks so they are actually treated as such

Author: sberg Date: Fri Nov 17 08:34:36 2017 New Revision: 318530 URL: http://llvm.org/viewvc/llvm-project?rev=318530=rev Log: Indent code blocks so they are actually treated as such Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

[libcxxabi] r318043 - Remove excess whitespace from syslog message; NFC

Author: sberg Date: Mon Nov 13 07:40:31 2017 New Revision: 318043 URL: http://llvm.org/viewvc/llvm-project?rev=318043=rev Log: Remove excess whitespace from syslog message; NFC Modified: libcxxabi/trunk/src/private_typeinfo.cpp Modified: libcxxabi/trunk/src/private_typeinfo.cpp URL:

r306799 - Fold exception-warnings.cpp into warn-throw-out-noexcept-func.cpp

Author: sberg Date: Fri Jun 30 00:22:02 2017 New Revision: 306799 URL: http://llvm.org/viewvc/llvm-project?rev=306799=rev Log: Fold exception-warnings.cpp into warn-throw-out-noexcept-func.cpp I had failed to notice the latter existed when I recently introduced the former. Removed:

r306715 - Fixed -Wexceptions derived-to-base false positives

Author: sberg Date: Thu Jun 29 10:58:59 2017 New Revision: 306715 URL: http://llvm.org/viewvc/llvm-project?rev=306715=rev Log: Fixed -Wexceptions derived-to-base false positives ...as introduced with recent "Emit warning when throw exception in destruct or

r306377 - Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

Author: sberg Date: Tue Jun 27 01:19:09 2017 New Revision: 306377 URL: http://llvm.org/viewvc/llvm-project?rev=306377=rev Log: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion With struct S1 {}; struct S2 { operator S1(); }; S1 f(S2

r306374 - Make sure TraverseInitListExpr visits InitListExpr exactly twice

Author: sberg Date: Tue Jun 27 01:04:08 2017 New Revision: 306374 URL: http://llvm.org/viewvc/llvm-project?rev=306374=rev Log: Make sure TraverseInitListExpr visits InitListExpr exactly twice ... once each for the syntactic and semantic form. Without this fix, behavior of the newly added tests

r306373 - Switch TestVisitor to Lang_C via -x c

Author: sberg Date: Tue Jun 27 00:59:56 2017 New Revision: 306373 URL: http://llvm.org/viewvc/llvm-project?rev=306373=rev Log: Switch TestVisitor to Lang_C via -x c ...instead of -std=c99, as the latter lead to error: invalid argument '-std=c99' not allowed with 'C++' complaints in test logs

r299522 - Don't issue a warning if the shadowing declaration is in a class

Author: sberg Date: Wed Apr 5 03:36:58 2017 New Revision: 299522 URL: http://llvm.org/viewvc/llvm-project?rev=299522=rev Log: Don't issue a warning if the shadowing declaration is in a class Follow-up to r299363 "Enhance -Wshadow to warn when shadowing typedefs or type aliases". Patch by Ahmed

r298490 - Add LibreOffice Clang plugin to ExternalClangExamples.rst

Author: sberg Date: Wed Mar 22 03:45:49 2017 New Revision: 298490 URL: http://llvm.org/viewvc/llvm-project?rev=298490=rev Log: Add LibreOffice Clang plugin to ExternalClangExamples.rst Reviewers: rsmith, rizsotto.mailinglist Subscribers: cfe-commits Differential Revision:

r289647 - Replace APFloatBase static fltSemantics data members with getter functions

Author: sberg Date: Wed Dec 14 05:57:17 2016 New Revision: 289647 URL: http://llvm.org/viewvc/llvm-project?rev=289647=rev Log: Replace APFloatBase static fltSemantics data members with getter functions At least the plugin used by the LibreOffice build

[clang-tools-extra] r289647 - Replace APFloatBase static fltSemantics data members with getter functions

Author: sberg Date: Wed Dec 14 05:57:17 2016 New Revision: 289647 URL: http://llvm.org/viewvc/llvm-project?rev=289647=rev Log: Replace APFloatBase static fltSemantics data members with getter functions At least the plugin used by the LibreOffice build

Re: [PATCH] D23907: Fix documentation of MemberExpr::getMemberDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL281469: Fix documentation of MemberExpr::getMemberDecl (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D23907?vs=69317=71357#toc Repository: rL LLVM

r281469 - Fix documentation of MemberExpr::getMemberDecl

Author: sberg Date: Wed Sep 14 09:03:50 2016 New Revision: 281469 URL: http://llvm.org/viewvc/llvm-project?rev=281469=rev Log: Fix documentation of MemberExpr::getMemberDecl Differential Revision: https://reviews.llvm.org/D23907 Modified: cfe/trunk/include/clang/AST/Expr.h Modified:

[PATCH] D23907: Fix documentation of MemberExpr::getMemberDecl

sberg created this revision. sberg added reviewers: rsmith, doug.gregor. sberg added a subscriber: cfe-commits. https://reviews.llvm.org/D23907 Files: include/clang/AST/Expr.h Index: include/clang/AST/Expr.h === ---

Re: [PATCH] D22128: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

sberg added a comment. (I'm not sure where and how to add a test for this?) http://reviews.llvm.org/D22128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22128: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

sberg created this revision. sberg added a reviewer: rsmith. sberg added a subscriber: cfe-commits. Herald added a subscriber: aemerson. With > struct S1 {}; > struct S2 { operator S1(); }; > S1 f(S2 s) { return static_cast(s); } the static_cast expr is > CXXStaticCastExpr 0x... 'struct S1'

Re: [PATCH] D21682: DeadStoresChecker: Don't warn about dead stores into volatile variables

sberg closed this revision. sberg added a comment. Committed revision 273689. http://reviews.llvm.org/D21682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273689 - DeadStoresChecker: Don't warn about dead stores into volatile variables

Author: sberg Date: Fri Jun 24 11:26:43 2016 New Revision: 273689 URL: http://llvm.org/viewvc/llvm-project?rev=273689=rev Log: DeadStoresChecker: Don't warn about dead stores into volatile variables Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

[PATCH] D21682: DeadStoresChecker: Don't warn about dead stores into volatile variables

sberg created this revision. sberg added a reviewer: zaks.anna. sberg added a subscriber: cfe-commits. http://reviews.llvm.org/D21682 Files: lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp test/Analysis/dead-stores.c Index: test/Analysis/dead-stores.c

Re: [PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

This revision was automatically updated to reflect the committed changes. Closed by commit rL264841: For MS ABI, emit dllexport friend functions defined inline in class (authored by sberg). Changed prior to commit: http://reviews.llvm.org/D18430?vs=51517=52024#toc Repository: rL LLVM

r264841 - For MS ABI, emit dllexport friend functions defined inline in class

Author: sberg Date: Wed Mar 30 01:27:31 2016 New Revision: 264841 URL: http://llvm.org/viewvc/llvm-project?rev=264841=rev Log: For MS ABI, emit dllexport friend functions defined inline in class ...as that is apparently what MSVC does. This is an updated version of r263738, which had to be

Re: r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

On 03/22/2016 06:38 PM, Reid Kleckner wrote: Ugh, templates and friend function definitions strike again! I think this is where "semantic" vs. "lexical" DeclContexts come into play. Try doing D->getLexicalDeclContext()->isDependentContext(). Great, thanks, that's what I'd been searching for.

[PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. ...as that is apparently what MSVC does. This is an updated version of r263738, which had to be reverted in r263740 due to test failures. The original version had erroneously emitted functions that

Re: r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

On 03/17/2016 09:06 PM, Reid Kleckner via cfe-commits wrote: Author: rnk Date: Thu Mar 17 15:06:58 2016 New Revision: 263740 URL: http://llvm.org/viewvc/llvm-project?rev=263740=rev Log: Revert "For MS ABI, emit dllexport friend functions defined inline in class" This reverts commit r263738.

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added a comment. friendly ping http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17567: [GCC] PR23529 Sema part of attrbute abi_tag support

sberg added a subscriber: sberg. Comment at: lib/Sema/SemaDeclAttr.cpp:4497 @@ +4496,3 @@ +static void handleAbiTagAttr(Sema , Decl *D, const AttributeList ) { + SmallVector Tags; + for (unsigned I = 0, E = Attr.getNumArgs(); I != E; ++I) {

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg added a comment. friendly ping http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added a comment. friendly ping http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. ...in cases where a member function is redeclared as a friend of a nested class. (LibreOffice happens to get tripped up by this.) http://reviews.llvm.org/D16632 Files:

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg updated this revision to Diff 46228. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D16628 Files: lib/Parse/ParseDeclCXX.cpp test/Parser/ms-anachronism.c Index: test/Parser/ms-anachronism.c

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

sberg added a comment. Yeah, my first naive finding when encountering the error was that it went away when unconditionally using FD->getCanonicalDecl() instead of FD in that if-else-if block. But that caused other parts of clang-test to fail. The current version passes all tests (happens to),

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg updated this revision to Diff 46227. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D15267 Files: include/clang/AST/ASTConsumer.h include/clang/Frontend/MultiplexConsumer.h include/clang/Sema/Sema.h lib/CodeGen/CodeGenAction.cpp

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) majnemer wrote: > What about

[PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. The Microsoft compiler emits warning C4229: anachronism used : modifiers on data are ignored for struct {} __cdecl s; but ICU's gendict can generate such (and does when building LibreOffice),

Re: [PATCH] D16301: Allow mode attribute for member variables again

sberg added a comment. Please somebody push this for me; I don't have commit access. Thanks http://reviews.llvm.org/D16301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16301: Allow mode attribute for member variables again

sberg updated this revision to Diff 45310. sberg added a comment. oops, had erroneously based it on some other local patch; rebased now http://reviews.llvm.org/D16301 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h

Re: [PATCH] D16301: Allow mode attribute for member variables again

sberg updated this revision to Diff 45268. sberg added a comment. updated the diagnostic message to mention fields in addition to variables and typedefs http://reviews.llvm.org/D16301 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D16301: Allow mode attribute for member variables again

sberg created this revision. sberg added reviewers: ABataev, aaron.ballman. sberg added a subscriber: cfe-commits. ...after r257868 "PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration" (presumably accidentally) restricted it to variables and typedefs, excluding

Re: [PATCH] D12834: add gcc abi_tag support

sberg added a subscriber: sberg. sberg added a comment. I can't figure out how to add code to someone else's Phabricator review, so sent it to the mailing list instead:

[PATCH] Re D12834 add gcc abi_tag support

I can't figure out how to add code to someone else's Phabricator review , so sending it here to the mailing list instead. * Attached 0001-add-gcc-abi_tag-support.patch rebases against recent trunk (there were three

Re: [PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg abandoned this revision. sberg added a comment. Ah, I see. I'll wait for that approach to be implemented then. http://reviews.llvm.org/D13386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg created this revision. sberg added reviewers: cfe-commits, rsmith. As discussed in [[ https://llvm.org/bugs/show_bug.cgi?id=24115 | "llvm-nm fails to build with gcc 5.1's libstdc++," ]] both llvm-nm and LibreOffice fail to build against GCC 5.1 libstdc++, due to Clang trying (and failing)

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

sberg added a subscriber: sberg. sberg added a comment. causes false positive for char * f(char *); char * g(char * p) { return f(p); } http://reviews.llvm.org/D12359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org