[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

STL_MSFT added a comment. A couple of notes/reminders that may help you make a decision here (I have no particular opinion as this doesn't impact how VS and microsoft/STL use Clang): 1. VS 2013's support lifecycle, documented at

[PATCH] D115685: [NFC] Fix typos in release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd106a89172: [NFC] Fix typos in release notes. (authored by STL_MSFT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115685: [NFC] Fix typos in release notes

STL_MSFT created this revision. STL_MSFT added reviewers: ldionne, Mordante, EricWF, mclow.lists. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. STL_MSFT requested review of this revision. Herald added projects: clang, libc++, clang-tools-extra. Herald added subscribers:

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

STL_MSFT added a comment. FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 affected `return _Istr;` occurrences in `` and `` for VS 2022 17.0 Preview 4. If you find any other affected return statements, please let us know ASAP (as the VS release process locks down the

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

STL_MSFT added a comment. > I would like to revive D66394 to get it > disabled by default soon. As I recently informed @thakis via email, our compiler documentation was incorrect (I've informed the doc team and they're going to publish a fixed article soon).

[PATCH] D19031: [clang-format] Flexible line endings

STL_MSFT added a comment. MSVC's STL currently uses CRLF (DOS) line endings, not LF (Unix). I wrote a validator, https://github.com/microsoft/STL/blob/58bb49d63d92e7a0346a05af29816aeea6b4cf0f/tools/validate/validate.cpp , to detect LF files, mixed line endings (LF and CRLF in the same file),

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Committed: https://github.com/llvm/llvm-project/commit/3a7a22445e806c08f80cf6d83d1760f7ff732ed0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

STL_MSFT created this revision. STL_MSFT added reviewers: ldionne, zoecarver. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, arphaman, dexonsmith. Herald added projects: clang, LLVM. [www] More HTTPS and outdated link fixes. Repository: rG LLVM Github Monorepo

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed: https://github.com/llvm/llvm-project/commit/2e4f1e112dfee1d16c138d42f2bc7ee639f9ae05 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69363/new/ https://reviews.llvm.org/D69363

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT marked an inline comment as done. STL_MSFT added inline comments. Comment at: clang/www/cxx_status.html:78 Rvalue references - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n2118.html;>N2118 + https://wg21.link/n2118;>N2118 Clang 2.9

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, ldionne, mclow.lists, zoecarver. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, arphaman, dexonsmith, christof. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This changes most URLs

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

STL_MSFT added a comment. This will definitely help us clean up our code, since we run the MSVC STL test suite with `-fno-ms-compatibility -fno-delayed-template-parsing`. Other possible occurrences of ms-extensions that should be considered ms-compatibility: - ParseDeclCXX.cpp says "MSVC

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

STL_MSFT added a comment. @rnk I've forwarded this to the compiler front-end and Universal CRT teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 ___

[PATCH] D53912: [Headers] [MS] Add intrin0.h

STL_MSFT added a comment. Yes, the "real builtin" approach seems to be best. For a recent example, https://reviews.llvm.org/D49606 added `__shiftright128` as an inline function in intrin.h, but that didn't work with MSVC's STL when I moved our declaration of `__shiftright128` from intrin.h to

[PATCH] D52843: Update Clang Windows getting started docs

STL_MSFT added inline comments. Comment at: clang/www/get_started.html:160 http://www.cmake.org/cmake/resources/software.html;> http://www.cmake.org/cmake/resources/software.html +Visual Studio 2015 or later This URL redirects to

[PATCH] D51868: [libcxx] Build and test fixes for Windows

STL_MSFT added inline comments. Comment at: test/support/test_macros.h:147 -# elif defined(_WIN32) -#if defined(_MSC_VER) && !defined(__MINGW32__) -# define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library compnerd wrote: > I think that the

[PATCH] D49338: Implement - P0122R7

STL_MSFT added inline comments. Comment at: test/std/containers/views/span.comparison/op.eq.pass.cpp:23 +#include +#include + The comparison tests appear to be unnecessarily including ``. Comment at:

[PATCH] D48616: Implement LWG 2946, 3075 and 3076

STL_MSFT added inline comments. Comment at: test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp:26 +// The deduction guide shall not participate in overload resolution if Allocator is +// is a type that does not qualify as an allocator. +

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed with a follow-up to use the requested macro. https://reviews.llvm.org/D45595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Approved by Eric. https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed, with a follow-up to use the C1XX macro. https://reviews.llvm.org/D45594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45596: [libcxx] [test] Avoid unary_function.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Avoid unary_function. Replace unary_function inheritance (which was never required, even in C++98) with argument_type and result_type typedefs. This increases portability, as unary_function was removed

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. https://reviews.llvm.org/D45595 Files:

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Silence MSVC warning C4146. This test code triggers the MSVC warning: "unary minus operator applied to unsigned type, result still unsigned" Although it would be possible to change the test code to

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Avoid MSVC truncation warnings. MSVC emits "warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data" when it sees pair constructed from (whatever, 4),

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT updated this revision to Diff 135352. STL_MSFT added a comment. Update based on code review feedback. https://reviews.llvm.org/D43273 Files: test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT added a comment. Would pragmas guarded by `_MSC_VER` be acceptable for the truncation warnings? https://reviews.llvm.org/D43273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix MSVC warnings and errors. test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass.cpp

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

STL_MSFT added a comment. Seems reasonable to me. Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, I've checked this in as-is. I would support an LWG issue to change the Standardese here. https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT added a comment. Ping? (And happy Patch Tuesday!) https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT added a comment. Ping? (And happy new year!) https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. Herald added a subscriber: jfb. [libcxx] [test] Improve MSVC portability. test/support/msvc_stdlib_force_include.hpp When testing MSVC's STL with C1XX, simulate a couple more compiler feature-test macros. When

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete. https://reviews.llvm.org/D40991

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

STL_MSFT added a comment. Would you like me to drop the changes to TODO.TXT? https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref.

STL_MSFT created this revision. [libcxx] [test] Fix MSVC warnings, null pointer deref. test/std/algorithms/alg.modifying.operations/alg.generate/generate_n.pass.cpp Silence MSVC warning C4244. This is expected when passing floating-point values for size.

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

STL_MSFT created this revision. [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII. I recently wrote a tool to audit MSVC's codebase for inconsistent line endings and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too. I don't need any of these changes to be

[PATCH] D39064: implement __has_unique_object_representations

STL_MSFT added a comment. Looks good to me modulo comments. Comment at: lib/Parse/ParseExpr.cpp:719 /// '__is_union' +/// '__has_unique_object_representations' [MS] /// Should this be marked as MS if it's cross-vendor?

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

STL_MSFT added a comment. FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update. Repository: rL LLVM https://reviews.llvm.org/D38646

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

STL_MSFT added a comment. > do you think `__declspec(nothrow)` calling the terminate handler in Clang is > a bug? It's certainly a behavior difference with potential performance impact, although I don't think it can be viewed as a bug, strictly speaking. MSVC treats `__declspec(nothrow)` as

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

STL_MSFT added a comment. This sounds right to me and the test looks good. (I'll let an actual compiler dev sign off) https://reviews.llvm.org/D38209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Looks good to myself. https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37024: [libcxx] [test] Cleanup nullopt_t tests

STL_MSFT added a comment. Otherwise, looks cromulent to me. Comment at: test/std/utilities/optional/optional.nullopt/nullopt_t.pass.cpp:38 -static_assert(test(nullopt) == 3, ""); +static_assert(std::is_same_v); +static_assert(test()); You're

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT added a comment. It's been two weeks - if there are no objections, I'd like to commit this soon. Thanks! https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

STL_MSFT added a comment. In https://reviews.llvm.org/D36860#846232, @thakis wrote: > Many driver tests check in a basic representative directory structure (e.g. > test/Driver/Inputs/basic_freebsd_tree/ and its many siblings). > > But if you're happy with others breaking this code, I suppose

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

STL_MSFT marked an inline comment as done. STL_MSFT added a comment. In https://reviews.llvm.org/D36860#845469, @thakis wrote: > This approach looks good to me. Thanks! > Is there any chance we could have a test for this? Unfortunately, testing this involves having a VS toolset with the

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

STL_MSFT updated this revision to Diff 111776. STL_MSFT edited the summary of this revision. STL_MSFT added a comment. This addresses Don Hinton's feedback. It also unifies `IsVS2017OrNewer` and `IsDevDivInternal` into a 3-state `enum class ToolsetLayout`. https://reviews.llvm.org/D36860

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

STL_MSFT created this revision. This is a minimally intrusive change, which I've verified works for both x86 and x64. The idea is to add another bool data member, `IsDevDivInternal`. (This could be unified with `IsVS2017OrNewer`, since it's a 3-way setting. Either a build is DevDiv-internal,

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT created this revision. [libcxx] [test] Update for C++17 feature removals. test/std/containers/Emplaceable.h test/std/containers/NotConstructible.h test/support/counting_predicates.hpp Replace unary_function/binary_function inheritance with typedefs.

[PATCH] D34534: [libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char', possible loss of data".

STL_MSFT added a comment. As I've made this exact change in other tests before, I'll commit this soon-ish if there are no comments or objections. https://reviews.llvm.org/D34534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34535: [libcxx] [test] Fix MSVC warning C4067 "unexpected tokens following preprocessor directive - expected a newline".

STL_MSFT added a comment. Ping for this one - there's no functional change here, but since I don't have any glibc coverage, I wanted to get a review. https://reviews.llvm.org/D34535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

STL_MSFT added a comment. Yeah, I just wanted to check that you didn't mean to actually use these typedefs for something. Thanks! https://reviews.llvm.org/D34536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D34536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34536: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings.

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef warnings. https://reviews.llvm.org/D34536 Files: test/std/numerics/complex.number/complex.transcendentals/acos.pass.cpp test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp

[PATCH] D34535: [libcxx] [test] Fix MSVC warning C4067 "unexpected tokens following preprocessor directive - expected a newline".

STL_MSFT created this revision. [libcxx] [test] Fix MSVC warning C4067 "unexpected tokens following preprocessor directive - expected a newline". Also fixes Clang/LLVM 4.0 (for Windows) error "function-like macro 'TEST_GLIBC_PREREQ' is not defined". https://reviews.llvm.org/D34535 Files:

[PATCH] D34534: [libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char', possible loss of data".

STL_MSFT created this revision. [libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char', possible loss of data". https://reviews.llvm.org/D34534 Files: test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp

[PATCH] D33953: [libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and make it friendlier to C1XX.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D33953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33955: [libcxx] [test] Remove a Clang/C2 workaround.

STL_MSFT created this revision. [libcxx] [test] Remove a Clang/C2 workaround. Clang/LLVM doesn't need this workaround. https://reviews.llvm.org/D33955 Files: test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp Index:

[PATCH] D33953: [libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and make it friendlier to C1XX.

STL_MSFT created this revision. [libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and make it friendlier to C1XX. Style/paranoia: 42.1 doesn't have an exact binary representation. Although this doesn't cause failures, it makes me uncomfortable, so I'm changing it to

[PATCH] D33741: [libc++] Undef min/max in test_macros.h

STL_MSFT added a comment. I haven't seen min/max test failures, probably because our CRT/STL headers never drag in Windows.h. I have no objection to undeffing min/max although I wouldn't do this myself (it creates order dependencies which I think are totally evil).

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

STL_MSFT added inline comments. Comment at: test/support/test_workarounds.h:21 #if defined(TEST_COMPILER_C1XX) -# define TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR -# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_COPYABLE Do you need to go update

[PATCH] D32927: [libc++] Implement exception_ptr on Windows

STL_MSFT resigned from this revision. STL_MSFT added inline comments. Comment at: include/exception:192 +#endif +void* __ptr1_; +void* __ptr2_; BillyONeal wrote: > I hope you realize you are doing "evil" unsupported things :). (We won't go > out of our

[PATCH] D32926: [libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained manner.

STL_MSFT created this revision. [libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained manner. https://reviews.llvm.org/D32926 Files: test/std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp

[PATCH] D32727: [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated".

STL_MSFT closed this revision. STL_MSFT added a comment. Committed with requested changes. https://reviews.llvm.org/D32727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32924: [libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant with another constant".

STL_MSFT created this revision. [libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant with another constant". The expressions `1 == 1` and `true` have the same type, value category, and value. https://reviews.llvm.org/D32924 Files:

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

STL_MSFT added inline comments. Comment at: test/support/msvc_stdlib_force_include.hpp:76 +#include + EricWF wrote: > Is the `stdlib.h` include above not enough? It isn't enough. In MSVC there's a distinction between CRT headers like `stdlib.h` and STL

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

STL_MSFT accepted this revision. STL_MSFT added inline comments. This revision is now accepted and ready to land. Comment at: test/support/archetypes.hpp:20 protected: +#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK NullBase() = default; I think that

[PATCH] D32727: [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated".

STL_MSFT created this revision. [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated". In C++17, these iterators are allowed but not required to inherit from the deprecated std::iterator base class. https://reviews.llvm.org/D32727 Files:

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

STL_MSFT created this revision. [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER. _HAS_CXX17 indicates whether MSVC's STL is in C++17 mode. https://reviews.llvm.org/D32726 Files: test/support/msvc_stdlib_force_include.hpp Index:

[PATCH] D32386: [libcxx] [test] Avoid P0138R2, direct-list-init of fixed enums from integers.

STL_MSFT created this revision. [libcxx] [test] Avoid P0138R2, direct-list-init of fixed enums from integers. This C++17 Core Language feature isn't necessary when testing std::byte. It's a minor convenience, but it limits test coverage to very new compilers. (I encountered this because C1XX

[PATCH] D31966: [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp.

STL_MSFT created this revision. [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp. This happens when using Clang with MSVC's STL, so there are no actual uses of this variable. https://reviews.llvm.org/D31966 Files:

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

STL_MSFT added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) aaron.ballman wrote: > EricWF wrote: > > aaron.ballman wrote: > > > Has

[PATCH] D29140: [libcxx] [test] Avoid MSVC's non-Standard ABI in underlying_type.pass.cpp.

STL_MSFT created this revision. [libcxx] [test] Avoid MSVC's non-Standard ABI in underlying_type.pass.cpp. When compiled with Clang for Windows, this was emitting "enumerator value evaluates to 4294967295, which cannot be narrowed to type 'int' [-Wc++11-narrowing]". The test should more

[PATCH] D29139: [libcxx] [test] Fix Clang -Wpessimizing-move "moving a temporary object prevents copy elision".

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wpessimizing-move "moving a temporary object prevents copy elision". N4618 30.6.6 [futures.unique_future]/12 declares "shared_future share() noexcept;". https://reviews.llvm.org/D29139 Files:

[PATCH] D29138: [libcxx] [test] Fix Clang -Wdeprecated-declarations with MSVC's CRT.

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wdeprecated-declarations with MSVC's CRT. libcxx's tests use various C Standard Library functions that have been marked by MSVC's CRT as deprecated by Microsoft (not by ISO). libcxx's usage is cromulent (just checking with decltype to

[PATCH] D29137: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3.

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3. test/std/strings/string.classes/typedefs.pass.cpp Actually test what basic_string's typedefs stand for. test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp NotDerived and ND were

[PATCH] D29136: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 2/3.

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 2/3. These typedefs were completely unused. https://reviews.llvm.org/D29136 Files: test/std/containers/sequences/deque/deque.cons/size.pass.cpp

[PATCH] D29135: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3.

STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3. Mark typedefs as LIBCPP_ONLY when their only usage is within LIBCPP_STATIC_ASSERT. test/std/containers/sequences/vector.bool/move_assign_noexcept.pass.cpp

[PATCH] D28837: [libcxx] [test] Fix MSVC warnings C4127 and C6326 about constants.

STL_MSFT created this revision. [libcxx] [test] Fix MSVC warnings C4127 and C6326 about constants. MSVC has compiler warnings C4127 "conditional expression is constant" (enabled by /https://reviews.llvm.org/W4) and C6326 "Potential comparison of a constant with another constant" (enabled by

[PATCH] D28592: [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant".

STL_MSFT abandoned this revision. STL_MSFT added a comment. Actually, this pattern annoys "warning C6326: Potential comparison of a constant with another constant." from /analyze. I'll figure out a better fix, probably with integral_constant. https://reviews.llvm.org/D28592

[PATCH] D28592: [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant". MSVC has a compiler warning (enabled at /https://reviews.llvm.org/W4) that's potentially useful,

[PATCH] D28591: [libcxx] [test] Don't ask whether Incomplete& can be assigned to.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Don't ask whether Incomplete& can be assigned to. This is the subject of an active NB comment. Regardless of what the Working Paper currently says, asking this

[PATCH] D27786: [libcxx] [test] Strip trailing whitespace.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Strip trailing whitespace. https://reviews.llvm.org/D27786 Files: test/std/experimental/utilities/meta/meta.detect/detected_or.pass.cpp

[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix recently introduced warnings emitted by MSVC. test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_pair_const_lvalue_pair.pass.cpp

[PATCH] D27777: [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

[PATCH] D27270: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4.

STL_MSFT abandoned this revision. STL_MSFT added a comment. Abandoning; I have changes in our STL to fix the bulk of these warnings, plus a small number of test changes that I'm about to send out. https://reviews.llvm.org/D27270 ___ cfe-commits

[PATCH] D27691: [libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.

STL_MSFT retitled this revision from "[libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp." to "[libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.". STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 81160. STL_MSFT

[PATCH] D27691: [libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp. This test was triggering MSVC x64 warning C4267 "conversion from 'size_t' to 'int', possible

[PATCH] D26623: [libcxx] [test] Swapping non-equal non-POCS allocators is UB.

STL_MSFT abandoned this revision. STL_MSFT added a comment. r289358 fixes everything for me, thanks! Abandoning this revision. https://reviews.llvm.org/D26623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

STL_MSFT abandoned this revision. STL_MSFT added a comment. Verified compiler fix. Abandoning this patch - nothing has been committed. https://reviews.llvm.org/D27555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

STL_MSFT added a comment. Actually, the compiler bug was resolved as fixed earlier today. Verifying... https://reviews.llvm.org/D27555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27270: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4.

STL_MSFT added a comment. Yeah, users are free to do this, which also triggers conversion warnings for us. I think I'll need to investigate actually fixing/suppressing them in our sources and abandoning this patch; leaving it open for now as a todo. https://reviews.llvm.org/D27270

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

STL_MSFT added a comment. Hmm, would a pragma guarded by _MSC_VER be better? I can easily do that. I've tried to avoid cluttering the test with VC-specific pragmas, but I understand your concern about initializing too much memory. https://reviews.llvm.org/D27555

[PATCH] D27633: [libcxx] [test] Fix string_view tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix string_view tests. test/std/strings/string.view/string.view.ops/compare.pointer_size.pass.cpp Passing -1 to size_t triggers signed/unsigned mismatch

[PATCH] D27622: [libcxx] [test] Add LIBCPP_ASSERT_NOEXCEPT/LIBCPP_ASSERT_NOT_NOEXCEPT, remove an unused variable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Add LIBCPP_ASSERT_NOEXCEPT/LIBCPP_ASSERT_NOT_NOEXCEPT, remove an unused variable. test/support/test_macros.h For convenience/greppability, add macros for

[PATCH] D26626: [libcxx] [test] Fix an improper assumption about Null Forward Iterators.

STL_MSFT added a comment. I could mark these assertions as libcxx-specific, but I tend to believe that they should be removed outright (even if the natural implementation of a list without debug checks provides this behavior). https://reviews.llvm.org/D26626

[PATCH] D27541: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

STL_MSFT added a comment. Responded to https://reviews.llvm.org/D27540. tuple is affected just like pair. https://reviews.llvm.org/D27541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 80810. STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Changed test/std/re/re.traits/value.pass.cpp to iterate with wchar_t as requested. https://reviews.llvm.org/D27544 Files:

  1   2   >