[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351030. Stephen added a comment. Try again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351029. Stephen added a comment. Try specifying the commit range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351028. Stephen added a comment. Undo that last move, since that didn't work. I'm absolutely incompetent with this tool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351024. Stephen added a comment. Fix the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 350950. Stephen added a comment. Fix the expected error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen created this revision. Stephen added a reviewer: hokein. Herald added subscribers: kbarton, nemanjai. Stephen requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Also standardize control flow of handleX conversion functions

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen marked an inline comment as done. Stephen added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-ignoreconversionfromtypes-option.cpp:12 + +typedef long long size_t; + njames93 wrote: > This

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen updated this revision to Diff 342472. Stephen added a comment. 1. Updating D99543 : [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck. # 2. Enter a brief description of the changes included in this update. 3.

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen requested review of this revision. Stephen added a comment. Thanks, ymandel! Anything else, aaron.ballman or hokein? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/new/ https://reviews.llvm.org/D99543

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen updated this revision to Diff 342409. Stephen marked 2 inline comments as done. Stephen added a comment. Within clang-tidy's NarrowingConversionsCheck. - Allow opt-out of some common occurring patterns, such as: - Implicit casts between types of equivalent bit widths. - Implicit

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen updated this revision to Diff 338273. Stephen added a comment. (fix patch to include all local changes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/new/ https://reviews.llvm.org/D99543 Files:

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen requested review of this revision. Stephen added a comment. Thanks for the review! I think I've addressed the comments -- hopefully I kept it inline with what you're thinking. Please have another look at your leisure. Comment at:

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen updated this revision to Diff 338272. Stephen added a comment. - Add ability to pass semi-colon separated list of types to ignore, instead of assuming only size_type and difference_type. - Remove ability to avoid warnings on ::size() method, since it's subsumed by allowing narrowing