[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

saudi abandoned this revision. saudi added a comment. Herald added a project: All. In D102633#2786288 , @aganea wrote: > @dexonsmith Yes, using the Clang Tooling C++ API seems like a good option, > however some logic could/would be needed from >

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG822c274477ea: [clang-cl] Ignore #pragma managed/unmanaged (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi added a comment. In D139632#3985341 , @thakis wrote: > LG (except for thieta's nit.) > > Do you have commit permissions, or do you need someone to land this for you? > If the latter, which name and email should we use for landing it? I have

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi created this revision. saudi added reviewers: thakis, rnk, thieta. saudi added a project: clang. Herald added a project: All. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Those 2 pragmas are ignored by MSVC when not compiling with `/CLR`, which clang

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3438a596d4: [CodeGen][X86] Crash fixes for patchable-function pass (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

saudi added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

saudi updated this revision to Diff 477182. saudi added a comment. Small update: improve comments, remove empty line modification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 Files:

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

saudi updated this revision to Diff 476960. saudi added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added support for empty MBB: ensures 2-byte nop is inserted, to make the function patchable. This should also support the requirement for the functions not to

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

saudi added inline comments. Herald added a subscriber: ributzka. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:487 +if (!llvm::sys::path::has_extension(CurrentO)) + LastO = (CurrentO + ".obj").str(); +else

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

saudi added a comment. Nice! It's much more straightforward now, the reverse iteration was pretty confusing. Thanks! Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:478 + if (Arg == "-Xclang") +++I; + A test for boundary

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi added a comment. Sorry, I flagged this as "accepted", but I'm not sure I am allowed to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi accepted this revision. saudi added a comment. This revision is now accepted and ready to land. It is indeed much cleaner this way`, thanks! The tests are not anymore the same for `clang-cl` as for `clang`, but I agree what needs testing is the clang-cl specific behaviors, not having the

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

saudi abandoned this revision. saudi added a comment. I understand, making `clang-cl -Wall` behave differently than `/Wall' is indeed confusing. We'll take different steps for setting up the warnings in our Build System. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

saudi created this revision. saudi added reviewers: rnk, hans. saudi added a project: clang. Herald added subscribers: jeroen.dobbelaere, dang. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Currently, for clang-cl, `-Wall` is treated identically as `/Wall` and

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82a844961a5: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when… (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

saudi created this revision. saudi added reviewers: dexonsmith, jansvoboda11, Bigcheese. saudi added a project: clang. Herald added a subscriber: jeroen.dobbelaere. saudi requested review of this revision. Herald added a subscriber: cfe-commits. The `#pragma` directives `push_macro`/`pop_macro`

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + jansvoboda11 wrote: > saudi wrote: > > jansvoboda11 wrote: > > > saudi wrote: > > > > Hello, > > > >

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + jansvoboda11 wrote: > saudi wrote: > > Hello, > > > > I encountered crashes on Windows targets,

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + Hello, I encountered crashes on Windows targets, related to this line, when rebasing

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

saudi created this revision. saudi added reviewers: arphaman, dexonsmith, Bigcheese. saudi added projects: clang, LLVM. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Switching back to `std::thread` to simplify the logic, as `ThreadPool` adds a layer of task

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saudi marked 2 inline comments as done. Closed by commit rG6052a8a53559: [clang] In DependencyCollector on Windows, ignore case and separators when… (authored by

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi updated this revision to Diff 344947. saudi added a comment. Updated for comments from @rnk, except for the canonicalization part. Are you suggesting that the `DependencyCollector` should be called with the already canonicalized paths? There are a few code paths leading to the

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi created this revision. saudi added reviewers: rnk, thakis, dexonsmith, Bigcheese. saudi added a project: clang. saudi requested review of this revision. Herald added a subscriber: cfe-commits. We noticed that the dependency collectors of `clang` may report duplicate paths under Windows,

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318553. saudi marked an inline comment as done. saudi added a comment. Applied the suggestions from the parent patch D95099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:12-16 { "directory": "DIR", - "command": "clang -E DIR/regular_cdb_input.cpp -IInputs -o adena.o", + "command": "clang -E -IInputs -o adena.o -- DIR/regular_cdb_input.cpp", "file":

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi updated this revision to Diff 318304. saudi marked 5 inline comments as done. saudi added a comment. Updated for suggested modifications CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 Files: clang/lib/Tooling/Tooling.cpp

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi marked an inline comment as done. saudi added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/static-analyzer-cdb.json:4-5 "directory": "DIR", - "command": "clang --analyze DIR/static-analyzer.c", - "file": "DIR/static-analyzer.c" + "command": "clang

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318248. saudi edited the summary of this revision. saudi added a comment. Removed the support for "--" command lines, it was extracted to patch D95099 . Applied suggested fixes. CHANGES SINCE LAST ACTION

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi updated this revision to Diff 318214. saudi added a comment. Bugfixes on the use of the iterator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 Files: clang/lib/Tooling/Tooling.cpp clang/test/ClangScanDeps/Inputs/regular_cdb.json

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk, dexonsmith, hans. saudi added a project: clang. Herald added a subscriber: tschuett. saudi requested review of this revision. Herald added a subscriber: cfe-commits. This fixes argument injection when clang

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92136/new/ https://reviews.llvm.org/D92136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 316768. saudi edited the summary of this revision. saudi added a comment. Updated the tests for clang-cl command lines: I moved the input files to end of command line, with `--`, to avoid linux-style paths conflict with clang-cl arguments. I also had to fix

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG640ad769110f: [clang-scan-deps] Support clang-cl (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308770. saudi added a comment. Rebase after https://reviews.llvm.org/D92330. Also, improved the detection of target obj file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Files:

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79ba7967f481: [clang-scan-deps] Improve argument parsing to find target object file path. (authored by saudi). Repository: rG LLVM Github

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett. saudi requested review of this revision. This patch adds support for the joined version of `-o` (e.g. `-ofilename`) command parameter

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308068. saudi added a comment. Removed `/Fo` option. `-o` is also supported by clang-cl and overrides /Fo options that are found earlier in the command line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett, ormris. saudi requested review of this revision. clang-scan-deps contains some command line parsing and modifications. This

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi updated this revision to Diff 307854. saudi added a comment. Update patch : clang-format fixes. There remains some clang-tidy warnings in `Path.cpp` and `Path.h` from `llvm/Support`. I would like extra opinions on this, because fixing them would break the homogeneity with the rest of the

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi created this revision. saudi added reviewers: rnk, thakis, rsmith, AndyG. saudi added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ormris, hiraditya. Herald added a project: LLVM. saudi requested review of this revision. The test now moves the header

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

This revision was automatically updated to reflect the committed changes. Closed by commit rG79105e464429: [clang-scan-deps] Fix for input file given as relative path in compilation… (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304648. saudi added a comment. Simplified the `RealFS` initialization, as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi marked 2 inline comments as not done. saudi added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:158-160 + llvm::IntrusiveRefCntPtr PhysicalFileSystem( + llvm::vfs::createPhysicalFileSystem().release()); + RealFS =

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304629. saudi added a comment. Removed use of ProxyFileSystem CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D91204: [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304327. saudi added a comment. Updated the patch. Followed suggestion from @dexonsmith. Indeed it simplifies the code. Also, improved the test, to also test with -j 2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/

[PATCH] D91204: [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi created this revision. saudi added reviewers: arphaman, dexonsmith. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett. saudi requested review of this revision. The bug appeared when clang-scan-deps was run from a different directory than the one provided in the

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { saudi wrote: > I encountered an assert inside

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { I encountered an assert inside

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

This revision was automatically updated to reflect the committed changes. Closed by commit rG226489715cb8: [clang] Disable check for system sanitizer blacklists files if -fno-sanitizer… (authored by saudi). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75853: [Clang][test] Add .i files for test discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rGf75f19c23748: [Clang][test] Add .i files for test discovery (authored by saudi). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION