[PATCH] D106577: [clang] Define __STDC_ISO_10646__

ThePhD added a comment. Hi, my name is JeanHeyd Meneide. I'm the Project Editor for C, but more importantly I'm the author of this paper: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2728.htm This paper was accepted yesterday (September 3rd, 2021) into the C Standard, and (after I merge

[PATCH] D93031: Enable fexec-charset option

ThePhD added a comment. Just a tiny comment: could you please make sure the name of the resolved encoding is also propagated to InitPreprocessor.cpp that sets the `__clang_literal_encoding__` macro? (https://github.com/llvm/llvm-project/blob/main/clang/lib/Frontend/InitPreprocessor.cpp#L784)

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD added a comment. In D100346#2686342 , @aaron.ballman wrote: > Okay, I'm sold. Thank you for the detailed explanation! The changes LGTM. Do > you have commit privileges or would you like me to commit on your behalf? (If > you'd like me to

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337178. ThePhD set the repository for this revision to rG LLVM Github Monorepo. ThePhD added a comment. Oops, almost forgot the doc fixes for the *wide__* macro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD marked 4 inline comments as done. ThePhD added a comment. In D100346#2685530 , @aaron.ballman wrote: > ... > > What about for folks using this from C where there isn't `constexpr` > functionality to help them? The unfortunate bit is that C

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337158. ThePhD added a comment. Change `NOTE:` to `FIXME:`. Update the text for the documentation to be more explicit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files:

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337035. ThePhD marked an inline comment as done. Herald added subscribers: aheejin, dschuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/docs/LanguageExtensions.rst

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD marked an inline comment as done. ThePhD added a comment. In D100346#2684705 , @rsmith wrote: > Exposing this information seems fine to me. I think it'd be more useful to > expose it in a way the preprocessor can inspect ... The reason it's done

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337024. ThePhD added a comment. The tests check for macros in strict byte-value "alphabetical" order. We also need documentation, as was suggested!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337008. ThePhD added a comment. Fixes formatting derps in the pre-linter check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files:

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD created this revision. ThePhD added a reviewer: aaron.ballman. ThePhD added a project: clang. ThePhD requested review of this revision. Herald added a subscriber: cfe-commits. **//Short version://** Please let us know the encoding that the compiler chooses for it's