[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-02-01 Thread Timm Baeder via cfe-commits
tbaederr wrote: You can diasable it via `-fno-color-diagnostics`. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-02-01 Thread Timm Baeder via cfe-commits
tbaederr wrote: Looks a lot like the stack trace mentioned in https://github.com/llvm/llvm-project/issues/80127 https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79130 >From db25ed3917079ea9bf3c05a899b40415e3c5df8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 23 Jan 2024 09:14:02 +0100 Subject: [PATCH] [clang][Interp] Handle imaginary literals

[clang] [clang][Interp] Handle casts between complex types (PR #79269)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-31 Thread Timm Baeder via cfe-commits
@@ -112,11 +112,13 @@ bool Context::evaluateAsInitializer(State , const VarDecl *VD, #endif // Ensure global variables are fully initialized. - if (shouldBeGloballyIndexed(VD) && !Res.isInvalid() && - (VD->getType()->isRecordType() || VD->getType()->isArrayType())) {

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/70772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Bail out on missing ComparisonCategoryInfo (PR #80131)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/80131 Instead of asserting. This can happen in real-world code. >From 3548cdb9907a44c25da61887b2f8e83268e3c2d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 31 Jan 2024 12:53:39 +0100

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70772 >From 8449070d0cec2ad120c9d8a36a72594d595b7fea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 07:17:16 +0100 Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-31 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79452 >From d4364d84bff990a241904cdf6644afac9b304923 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 25 Jan 2024 15:20:52 +0100 Subject: [PATCH] [clang][Interp] Handle complex values in

[clang] [clang][Interp] Handle casts between complex types (PR #79269)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/79269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/79130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Move isSimpleTypeSpecifier() from Sema to Token (PR #80101)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -13,6 +13,7 @@ #ifndef LLVM_CLANG_LEX_TOKEN_H #define LLVM_CLANG_LEX_TOKEN_H +#include "clang/Basic/LangOptions.h" tbaederr wrote: I think we can get by with a forward-declaration of `LangOptions` instead of the include here?

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/72892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From c45c1c9bbd944744f69e811b2104de01cf82c55b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 09:48:15 +0100 Subject:

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From c45c1c9bbd944744f69e811b2104de01cf82c55b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 09:48:15 +0100 Subject:

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program , std::vector , const Floating , Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program , std::vector , + const IntegralAP , bool ) { + size_t Size = Val.bytesToSerialize(); + + if (Code.size() + Size >

[clang] [clang] Fix a possible out-of-bounds read (PR #80023)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/80023 Fixes #79964 >From 77c9461b321fa82c82e3e4a1e29c825b912c8ed2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 17:04:23 +0100 Subject: [PATCH] [clang] Fix a possible

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From 13b8fa29188bcf1f2122fb8a0708ecc468b8e097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 09:48:15 +0100 Subject: [PATCH] [clang][Interp] Support arbitrary precision

[llvm] [clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From c9f1518241b27978c40b7a5fc52f2c5ad9d32604 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 15:57:07 +0100 Subject:

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program , std::vector , const Floating , Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program , std::vector , + const IntegralAP , bool ) { + size_t Size = Val.bytesToSerialize(); + + if (Code.size() + Size >

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program , std::vector , const Floating , Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program , std::vector , + const IntegralAP , bool ) { + size_t Size = Val.bytesToSerialize(); + + if (Code.size() + Size >

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Here's gnome-terminal's default colors, first normal and then bright: ![Screenshot from 2024-01-30 14-55-37](https://github.com/llvm/llvm-project/assets/49720664/9f225494-0cc9-4d53-a0e1-98b45b5b4c4b) Here the same with xterm: ![Screenshot from 2024-01-30

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Nice, thanks! https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79973 >From 46f91cbdda7d11ca597f3727151bd11232b0415f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 08:50:34 +0100 Subject: [PATCH] [clang][Interp] Fix MemberExpr initializing an

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79973 This is similar to c1ad363e6eba308fa94c47374ee98b3c79693a35, but with the additional twist that initializing an existing value from a `MemberExpr` was not working correctly. >From

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Yeah, I read that too when first working on this. Let me try some stuff. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: > But it's a bit off the point. We should pick colors that have good contrast > against both light and dark color themes by default, and not ask everyone to > change their color palette. Also make sure to zoom out when you look at this > yourself: issue is more apparent this

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Does it look that bad in your local terminal as well? It's okay-ish with the default colors here: ![Screenshot from 2024-01-30 09-48-38](https://github.com/llvm/llvm-project/assets/49720664/ca6fb7d1-d729-4fea-b0fd-0385b0e5fba2) We might have to file a bug against

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-29 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/72892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: For reference, the generated code with this patch looks like this: ```c++ #if defined(GET_EVAL_PROTO) || defined(GET_LINK_PROTO) bool emitConstFloat(const Floating &, const SourceInfo &); #endif #ifdef GET_LINK_IMPL bool ByteCodeEmitter::emitConstFloat(const Floating , const

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79753 The Float print type is backed by the Floating class, which in turn uses APFloat, which might heap-allocate memory, so might be expensive to copy. Add an 'AsRef' bit to the ArgType tablegen class, which

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79747 Add (de)serialization support for them, like we do for Floating values. Unfortunately I wasn't able to eliminate the code duplication coming from the signed/unsigned split here. I was trying to avoid adding a

[clang] [clang][Interp] Support zero init for complex types (PR #79728)

2024-01-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79728 >From 0b6925d01645fbe3af9a1ac51ee6e396cbe67a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 07:21:06 +0100 Subject:

[clang] [clang][Interp] Support zero init for complex types (PR #79728)

2024-01-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79728 Initialize both elements to 0. >From 0b6925d01645fbe3af9a1ac51ee6e396cbe67a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 07:21:06 +0100 Subject: [PATCH] [clang][Interp]

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: Don't think I can get the Windows+libcxx pre-commit CI working :| `libcxx/gdb/gdb_pretty_printer_test.sh.cpp` has `UNSUPPORTED` lines for clang 16-18 but 19 is missing now. Not sure how this works for others. https://github.com/llvm/llvm-project/pull/66514

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 5014d98b1893225ebdcc1e9ce0941b348f504740 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-25 Thread Timm Baeder via cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70772 >From 7f4cb1f727a497c6da1fc3f4740522ff5adb3964 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 07:17:16 +0100 Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 29c174e595dd839cf96ca54778712ab3bc543103 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/70053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-25 Thread Timm Baeder via cfe-commits
@@ -54,7 +54,7 @@ class ByteCodeExprGen : public ConstStmtVisitor, bool>, public: /// Initializes the compiler and the backend emitter. template - ByteCodeExprGen(Context , Program , Tys &&... Args) + ByteCodeExprGen(Context , Program , Tys &&...Args)

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr unassigned https://github.com/llvm/llvm-project/pull/79452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr unassigned https://github.com/llvm/llvm-project/pull/79452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr unassigned https://github.com/llvm/llvm-project/pull/79452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr unassigned https://github.com/llvm/llvm-project/pull/79452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle complex values in visitBool() (PR #79452)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79452 In C++, we get a ComplexToBool cast, but we might not in C. >From b207bff4cda462869bcf8547e44d23e5b8fc5e94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 25 Jan 2024 15:20:52 +0100

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 2a0b02a285203228944d5dd206f968e776757993 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-25 Thread Timm Baeder via cfe-commits
@@ -389,10 +390,29 @@ template class LocalScope : public VariableScope { if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) { this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{}); this->Ctx->emitRecordDestruction(Local.Desc); +

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-25 Thread Timm Baeder via cfe-commits
@@ -54,7 +54,7 @@ class ByteCodeExprGen : public ConstStmtVisitor, bool>, public: /// Initializes the compiler and the backend emitter. template - ByteCodeExprGen(Context , Program , Tys &&... Args) + ByteCodeExprGen(Context , Program , Tys &&...Args)

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-25 Thread Timm Baeder via cfe-commits
@@ -389,10 +390,29 @@ template class LocalScope : public VariableScope { if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) { this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{}); this->Ctx->emitRecordDestruction(Local.Desc); +

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -368,6 +369,7 @@ template class LocalScope : public VariableScope { return; this->emitDestructors(); this->Ctx->emitDestroy(*Idx, SourceInfo{}); +removeStoredOpaqueValues(); tbaederr wrote: Ah, didn't see that. Well, it's fine to leave

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-24 Thread Timm Baeder via cfe-commits
tbaederr wrote: Adding Aaron since we're probably getting close. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr requested changes to this pull request. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -389,10 +391,28 @@ template class LocalScope : public VariableScope { if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) { this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{}); this->Ctx->emitRecordDestruction(Local.Desc); +

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -368,6 +369,7 @@ template class LocalScope : public VariableScope { return; this->emitDestructors(); this->Ctx->emitDestroy(*Idx, SourceInfo{}); +removeStoredOpaqueValues(); tbaederr wrote: Inline this function here.

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -389,10 +391,28 @@ template class LocalScope : public VariableScope { if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) { this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{}); this->Ctx->emitRecordDestruction(Local.Desc); +

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2024-01-24 Thread Timm Baeder via cfe-commits
@@ -389,10 +391,28 @@ template class LocalScope : public VariableScope { if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) { this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{}); this->Ctx->emitRecordDestruction(Local.Desc); +

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 69aa9b23a7d5afb58b89a703e7755924561dd54f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang] [clang][Interp] Handle casts between complex types (PR #79269)

2024-01-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79269 Just handle this like two primtive casts. >From ecc963e4fbcfe1cd1c1f40c642c1c0fbf916a8c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 24 Jan 2024 10:04:50 +0100 Subject: [PATCH]

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/78699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79130 Initialize the first element to 0 and the second element to the value of the subexpression. >From 34f0c1b9297bd817f8aaf9ddcb29457fa5e96aca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date:

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2024-01-22 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > Seems you pinged this without the commit to fix the things we've requested? Right, I was more looking for guidance what to do

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2024-01-22 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67095 ___

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-22 Thread Timm Baeder via cfe-commits
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72892 >From dcdb669e8d15ddfed5725efff9d9951306368f7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 20 Nov 2023 11:53:40 +0100 Subject: [PATCH] [clang][Interp] Add inline descriptor to global

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-21 Thread Timm Baeder via cfe-commits
tbaederr wrote: The policy is to ping _once a week_. It's the weekend. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned char c, return AllowDollar && c == '$'; } + +LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) { + // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER + static

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned char c, return AllowDollar && c == '$'; } + +LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) { + // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER + static

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned char c, return AllowDollar && c == '$'; } + +LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) { + // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER + static

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned char c, return AllowDollar && c == '$'; } + +LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) { + // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER + static

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -378,3 +378,92 @@ namespace Packs { static_assert(foo() == 2, ""); static_assert(foo<>() == 0, ""); } + +namespace std { +template struct remove_reference { using type = T; }; +template struct remove_reference { using type = T; }; +template struct remove_reference {

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2024-01-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70772 >From c6c7d246b334a95306cda410e7d115353acb7c5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 07:17:16 +0100 Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2024-01-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/71315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-19 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 41bb52dc591ce1c154a4272abb738c80a7a57b90 Mon Sep 17 00:00:00 2001 From:

[llvm] [clang] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-19 Thread Timm Baeder via cfe-commits
@@ -11,7 +11,7 @@ #error // expected-error@-1 {{}} -// CHECK: error: no expected directives found: consider use of 'expected-no-diagnostics' +// CHECK: error: no expected directives found: consider use of '{{.*}}-no-diagnostics' tbaederr wrote:

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-19 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 41bb52dc591ce1c154a4272abb738c80a7a57b90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?=

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-19 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 41bb52dc591ce1c154a4272abb738c80a7a57b90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023

[clang] [clang][Interp] Implement integral->complex casts (PR #75590)

2024-01-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/75590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] IndirectMember initializers (PR #69900)

2024-01-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69900 ___ cfe-commits mailing list

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-18 Thread Timm Baeder via cfe-commits
@@ -11,7 +11,7 @@ #error // expected-error@-1 {{}} -// CHECK: error: no expected directives found: consider use of 'expected-no-diagnostics' +// CHECK: error: no expected directives found: consider use of '{{.*}}-no-diagnostics' tbaederr wrote:

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-18 Thread Timm Baeder via cfe-commits
@@ -11,7 +11,7 @@ #error // expected-error@-1 {{}} -// CHECK: error: no expected directives found: consider use of 'expected-no-diagnostics' +// CHECK: error: no expected directives found: consider use of '{{.*}}-no-diagnostics' tbaederr wrote:

[clang] [clang][Interp] Fix diagnosing non-const variables pre-C++11 (PR #76718)

2024-01-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/76718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement integral->complex casts (PR #75590)

2024-01-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/75590 >From 93d58a2aaeaae142723c844a2f19d4bec7c6bdf1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Dec 2023 13:11:16 +0100 Subject: [PATCH] [clang][Interp] Implement integral->complex

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 34ca28505542d55f62da80d8fd3c2561535185d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject:

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
@@ -1112,6 +1121,140 @@ prepareAndFilterRanges(const SmallVectorImpl , return LineRanges; } +/// Creates syntax highlighting information in form of StyleRanges. +/// +/// The returned unique ptr has always exactly size +/// (\p EndLineNumber - \p StartLineNumber + 1). Each

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2024-01-18 Thread Timm Baeder via cfe-commits
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const FunctionDecl *FD) { bool Context::evaluateAsRValue(State , const Expr *E, APValue ) { assert(Stk.empty()); ByteCodeExprGen C(*this, *P, Parent, Stk, Result); - if (Check(Parent, C.interpretExpr(E)))

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2024-01-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/71315 >From b549c6aaa47b4b6b90e03cb2b4a59f323e95888d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 14:57:51 +0100 Subject: [PATCH] EvaluationResult ---

[clang] [clang][Interp] Implement ComplexToReal casts (PR #77294)

2024-01-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/77294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2024-01-18 Thread Timm Baeder via cfe-commits
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const FunctionDecl *FD) { bool Context::evaluateAsRValue(State , const Expr *E, APValue ) { assert(Stk.empty()); ByteCodeExprGen C(*this, *P, Parent, Stk, Result); - if (Check(Parent, C.interpretExpr(E)))

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
tbaederr wrote: > The only thing we need to make sure is that highlighting isn't done in CI/ > redirected output It now respects `DiagOpts->ShowColors`, so that should work. But I guess you're talking about a test. :) https://github.com/llvm/llvm-project/pull/66514

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 34ca28505542d55f62da80d8fd3c2561535185d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-17 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [llvm] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-17 Thread Timm Baeder via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected

<    1   2   3   4   5   6   7   8   9   10   >