https://github.com/tstellar approved this pull request.
LGTM. Thanks, this should help free up some builder resources.
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/tstellar commented:
If we aren't running the tests any more, can we build clang with
`-DLLVM_TARGETS_TO_BUILD=Native`
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/90138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/92591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
> Did you consider the parallel setting as well?
Forgot about that part, I will make that change too.
https://github.com/llvm/llvm-project/pull/90138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/tstellar approved this pull request.
LGTM, thank you.
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
tstellar wrote:
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/90138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/92591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/92591
This fixes two problems with the 2-stage PGO builds. The first problem was
that the stage2-instrumented and stage2 targets would not be built on the
second ninja invocation. For example:
# This would work
tstellar wrote:
@phoebewang Can you add a release note for this on the PR for the release
branch and then add the release:note label.
https://github.com/llvm/llvm-project/pull/91694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tstellar wrote:
This was merged in another PR: b7e2397c54b7cddac8fa188e68073f78e895a57a.
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tstellar wrote:
Two questions:
* Did you use a script to generate this patch?
* Why do we need to make this change?
https://github.com/llvm/llvm-project/pull/91856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tstellar wrote:
/cherry-pick 53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/90139
Set this in the cache file directly instead of via the test-release.sh script
so that the release builds can be reproduced with just the cache file.
>From 67f3d1ede686758238bb37a2ea50790750f7693f Mon Sep 17
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/90138
None
>From 0d0484ac99affdc8ccb9bc3a1eff827cf996c51c Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 24 Apr 2024 07:54:41 -0700
Subject: [PATCH] [CMake][Release] Use the TGZ cpack generator for binaries
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/89812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/89812
>From 275979816a1de8b16a6c45b5ee2ef4e73c8828ba Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Tue, 23 Apr 2024 19:29:04 +
Subject: [PATCH] [CMake][Release] Refactor cache file and use two stages for
tstellar wrote:
I've been testing this with #89521.
https://github.com/llvm/llvm-project/pull/89812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/89517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/89812
Completely refactor the cache file to simplify it and remove unnecessary
variables. The main functional change here is that the non-PGO builds now use
two stages, so `ninja -C build stage2-package` can be
tstellar wrote:
@petrhosek Would you be able to add a comment to the llvm_check_linker_flag
function explaining this so someone else doesn't try to do the same thing.
https://github.com/llvm/llvm-project/pull/86602
___
cfe-commits mailing list
https://github.com/tstellar approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/86602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/89517
This target will be used to generate the release binary package for uploading
to GitHub.
>From 79e4f21df778ede9238c66e06ca289d7599f9f5c Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 15 Apr 2024
tstellar wrote:
@owenca Is there a PR for the cherry-pick ?
https://github.com/llvm/llvm-project/pull/87953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
PR is here: https://github.com/llvm/llvm-project/pull/89000
https://github.com/llvm/llvm-project/pull/88465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar commented:
I'm fine with this as long as @AaronBallman approves.
https://github.com/llvm/llvm-project/pull/87130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tstellar wrote:
/cherry-pick 0d2bb7f017f13ceae793fab7d83d3e67e8d8d8f8)
https://github.com/llvm/llvm-project/pull/88465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/88465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/88465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
> I'm assuming this is a stop-gap, and the plan is to eventually fix the issue
> and reenable PGO in the release cache?
Yes, I would like to fix this at some point, but not sure when I'll get to it.
https://github.com/llvm/llvm-project/pull/88465
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/88465
Running the test-release.sh script with PGO enabled causes build errors like:
ld.lld: error: Function Import: link error: linking module flags
'ProfileSummary': IDs have conflicting values
I believe this a
https://github.com/tstellar requested changes to this pull request.
I'm going to NAK this change for now. Given the recent
[developments](https://www.openwall.com/lists/oss-security/2024/03/29/4) with
the xz project and considering this feature was requested by a user associated
with the
https://github.com/tstellar approved this pull request.
https://github.com/llvm/llvm-project/pull/86945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
Do we need to backport this to release/18.x?
https://github.com/llvm/llvm-project/pull/84230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
> FWIW I don't think the build bots are actually building `libclc`.
>
> Locally, at least, it's not sufficient to specify
> `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need
> `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me in-tree,
> because it assumes
https://github.com/tstellar approved this pull request.
https://github.com/llvm/llvm-project/pull/85634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar approved this pull request.
Good catch.
https://github.com/llvm/llvm-project/pull/85354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
This will make backports more difficult, but I think it's OK. If we wanted to
avoid impacting backports, we'd have to wait ~10 weeks to merge this, but that
doesn't seem practical.
https://github.com/llvm/llvm-project/pull/82217
___
tstellar wrote:
Could we have the upstream default be to install a clang.cfg file in bin/ which
has -fimplicit-openmp-rpath (or whatever the hoption is)?
https://github.com/llvm/llvm-project/pull/82004
___
cfe-commits mailing list
tstellar wrote:
> > > I believe right now the `rtlib-rpath` points to the path
> > > `${CLANG_BINARY}../lib/${HOST_TRIPLE}/`. I think it's definitely
> > > reasonable to not put this on system libraries if that's a solution,
> > > since we can generally assume it's a global installation and
tstellar wrote:
>
> I believe right now the `rtlib-rpath` points to the path
> `${CLANG_BINARY}../lib/${HOST_TRIPLE}/`. I think it's definitely reasonable
> to not put this on system libraries if that's a solution, since we can
> generally assume it's a global installation and already
tstellar wrote:
> We could make this logic more complicated by checking the system
> automatically `execute_command(lsb_release)` or something.
I think this is too complicated and fragile. If we want to do something
specifically to support the distro use case, I think we should do this:
tstellar wrote:
> Does Fedora only use default configurations when building its packages?
We try to stick to the defaults as much as possible. Having an implicit rpath
by default causes issues when building other RPMs with clang, and typically, if
we need to change something in order to
tstellar wrote:
I don't think a CMake option is the right way to go here. For example, I doubt
we would actually use this CMake option in Fedora if this patch is committed.
Does gcc use rpath for libgomp?
https://github.com/llvm/llvm-project/pull/82004
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED)
message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to
llvm-profdata")
else()
add_custom_target(generate-profdata
- COMMAND "${Python3_EXECUTABLE}"
${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py
tstellar wrote:
Tracking the backport request here: #81096
https://github.com/llvm/llvm-project/pull/80628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar approved this pull request.
https://github.com/llvm/llvm-project/pull/80713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,13 @@
+diff --git a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+index 1a04ca9a74e5..d092820e4115 100644
+--- a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS
+
@@ -0,0 +1,13 @@
+diff --git a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+index 1a04ca9a74e5..d092820e4115 100644
+--- a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS
+
@@ -0,0 +1,13 @@
+diff --git a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+index 1a04ca9a74e5..d092820e4115 100644
+--- a/clang/cmake/caches/BOLT-PGO.cmake
b/clang/cmake/caches/BOLT-PGO.cmake
+@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS
+
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/78879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,7 +2,7 @@ set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "")
set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "")
set(LLVM_ENABLE_PROJECTS "clang;lld" CACHE STRING "")
-set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi" CACHE STRING "")
+set(LLVM_ENABLE_RUNTIMES
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/78879
>From 0719f49ecc6dd69ae4698c3e84dbf175a1bf2ed3 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sun, 21 Jan 2024 00:25:47 +
Subject: [PATCH 1/4] [CMake][PGO] Add libunwind to list of stage1 runtimes
This
@@ -11,11 +15,11 @@ if(LLVM_BUILD_INSTRUMENTED)
add_lit_testsuite(generate-profraw "Generating clang PGO data"
${CMAKE_CURRENT_BINARY_DIR}/pgo-data/
EXCLUDE_FROM_CHECK_ALL
-DEPENDS clang clear-profraw ${CLANG_PERF_TRAINING_DEPS}
+DEPENDS clang clear-profraw
@@ -0,0 +1,31 @@
+; RUN: llc -mtriple s390x-ibm-zos -mcpu=z15 -asm-verbose=true < %s | FileCheck
%s
+; REQUIRES: systemz-registered-target
+
+; CHECK:.section".ppa2"
+; CHECK: @@PPA2:
+; CHECK:.byte 3
+; CHECK:.byte 231
+; CHECK:.byte 34
+; CHECK:
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/78879
>From 0719f49ecc6dd69ae4698c3e84dbf175a1bf2ed3 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sun, 21 Jan 2024 00:25:47 +
Subject: [PATCH 1/4] [CMake][PGO] Add libunwind to list of stage1 runtimes
This
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/78879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/78823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/78879
>From 0719f49ecc6dd69ae4698c3e84dbf175a1bf2ed3 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sun, 21 Jan 2024 00:25:47 +
Subject: [PATCH 1/3] [CMake][PGO] Add libunwind to list of stage1 runtimes
This
@@ -15,7 +19,7 @@ if(LLVM_BUILD_INSTRUMENTED)
)
tstellar wrote:
@petrhosek CLANG_PERF_TRAINING_DEPS was an existing variable that's used here.
I think it was meant to be added to cache files, but I added it to
CMakeLists.txt file here so that it could be
tstellar wrote:
I split the new configuration option out into a separate PR: #78879, because it
seems useful regardless of what the default is. We can continue to discuss the
best default on this PR.
https://github.com/llvm/llvm-project/pull/77347
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/78879
The new CLANG_PGO_TRAINING_DATA_SOURCE_DIR allows users to specify a CMake
project to use for generating the profile data. For example, to use the
llvm-test-suite to generate profile data you would do:
$
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/78869
This fixes the build since 8f90e6937a1fac80873bb2dab5f382c82ba1ba4e which made
libcxxabi use llvm's libunwind by default.
>From 0719f49ecc6dd69ae4698c3e84dbf175a1bf2ed3 Mon Sep 17 00:00:00 2001
From: Tom
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/78823
>From b23e23f862bec32e42fa7aa96da1fe0c4ed38a54 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 06:44:32 +
Subject: [PATCH 1/2] [CMake][Release] Add option for enabling PGO to release
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/78216
>From 035d4129ff02b776df53bfe149ce4af4af6072c4 Mon Sep 17 00:00:00 2001
From: Konrad Kleine
Date: Thu, 24 Mar 2022 09:44:21 +0100
Subject: [PATCH 01/10] Produce DWARF4 by default
Have a look at the following
tstellar wrote:
This commit broke the [ llvm-x86_64-debian-dylib
bot](https://lab.llvm.org/buildbot/#/builders/196/builds/42821)
https://github.com/llvm/llvm-project/pull/74629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/78823
The option is LLVM_RELEASE_ENABLE_PGO and it's turned on by default.
>From b23e23f862bec32e42fa7aa96da1fe0c4ed38a54 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 06:44:32 +
Subject:
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/69523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED)
message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to
llvm-profdata")
else()
add_custom_target(generate-profdata
- COMMAND "${Python3_EXECUTABLE}"
${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77347
>From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 07:46:01 +
Subject: [PATCH 1/7] [CMake][PGO] Use check-clang target to generate profdata
for
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/69523
>From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 18 Oct 2023 04:56:28 -0700
Subject: [PATCH 1/7] workflows: Refactor release-tasks.yml
* Split out the lit
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/69523
>From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 18 Oct 2023 04:56:28 -0700
Subject: [PATCH 1/6] workflows: Refactor release-tasks.yml
* Split out the lit
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/69523
>From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 18 Oct 2023 04:56:28 -0700
Subject: [PATCH 1/5] workflows: Refactor release-tasks.yml
* Split out the lit
@@ -26,21 +35,26 @@ jobs:
prepare:
name: Prepare to build binaries
runs-on: ubuntu-22.04
-if: github.repository == 'llvm/llvm-project'
outputs:
- release-version: ${{ steps.validate-tag.outputs.release-version }}
- flags: ${{
tstellar wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/69523
>From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 18 Oct 2023 04:56:28 -0700
Subject: [PATCH 1/5] workflows: Refactor release-tasks.yml
* Split out the lit
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/69523
>From 6a7f298f403e0e454644f3d945242120f8b2b321 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Wed, 18 Oct 2023 04:56:28 -0700
Subject: [PATCH 1/4] workflows: Refactor release-tasks.yml
* Split out the lit
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/77398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77398
>From 71574d1f8b37747b2b7176fffee8483a53fee4be Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 8 Jan 2024 16:39:00 -0800
Subject: [PATCH] Add OpenSSF Best Practice Badge
---
README.md | 1 +
1 file
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED)
message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to
llvm-profdata")
else()
add_custom_target(generate-profdata
- COMMAND "${Python3_EXECUTABLE}"
${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED)
message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to
llvm-profdata")
else()
add_custom_target(generate-profdata
- COMMAND "${Python3_EXECUTABLE}"
${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77347
>From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 07:46:01 +
Subject: [PATCH 1/6] [CMake][PGO] Use check-clang target to generate profdata
for
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/77035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77347
>From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 07:46:01 +
Subject: [PATCH 1/5] [CMake][PGO] Use check-clang target to generate profdata
for
tstellar wrote:
cc @zmodem Since I borrowed your idea from #71067.
https://github.com/llvm/llvm-project/pull/77347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
I was able to figure out how to generate profile data by compiling Sema.cpp
from the clang source tree, so I switched that to the default and added an
option so that users can override this with an external CMake project, like the
LLVM Test Suite.
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/77347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/77347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77347
>From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 07:46:01 +
Subject: [PATCH 1/4] [CMake][PGO] Use check-clang target to generate profdata
for
https://github.com/tstellar approved this pull request.
I'm in favor of removing this. It doesn't make a lot of sense now that we have
better config file support.
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/73214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
My goal right now is to make this simple and easy to use. I'm not opposed to
making something configurable, but it would be nice to have a default that
actually helped improve performance, so that a new user or a distribution
maintainer could just use the cache file as is.
https://github.com/tstellar edited
https://github.com/llvm/llvm-project/pull/77347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/77347
>From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Sat, 6 Jan 2024 07:46:01 +
Subject: [PATCH 1/2] [CMake][PGO] Use check-clang target to generate profdata
for
tstellar wrote:
@kwk fyi
https://github.com/llvm/llvm-project/pull/77347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/77347
When doing a multi-stage PGO build of clang, run the check-clang and check-llvm
targets using the instrumented clang and use that profile data for building the
final stage2 clang. This is what is recommended
1 - 100 of 398 matches
Mail list logo
