RE: r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

2019-02-26 Thread Topper, Craig via cfe-commits
You're right. It was already there after Ganesh's patch this morning. I hadn't updated my clang tree so I thought it was missing. Sorry. -Original Message- From: Roman Lebedev [mailto:lebedev...@gmail.com] Sent: Tuesday, February 26, 2019 11:29 AM To: Topper, Craig Cc:

RE: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-18 Thread Topper, Craig via cfe-commits
I just committed a change to go back to only definining _XCR_XFEATURE_ENABLED_MASK when clang is in MSVC compatibility mode. I don’t think I meant to define it outside of that since it doesn’t appear gcc does. For the other two files, I assume you’re getting a collision of names similar to