[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk updated this revision to Diff 199496. torbjoernk added a comment. minor rewording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/ https://reviews.llvm.org/D61827 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk updated this revision to Diff 199483. torbjoernk edited the summary of this revision. torbjoernk added a comment. Herald added a subscriber: arphaman. Addressed Roman Lebedev's comment regarding reference to `NOLINT` in the docs. As I don't have commit rights, I'd be grateful someone

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk updated this revision to Diff 199326. torbjoernk edited the summary of this revision. torbjoernk added a comment. Herald added subscribers: jdoerfert, jfb. Fixed the issues pointed out by Don Hinton and added note on OpenMP to the check's docs as suggested by Roman Lebedev. Also

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

torbjoernk added inline comments. Comment at: docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst:35-46 +.. option:: WarnOnLargeObject + + Also warns for any large trivial object caught by value. Catching a large + object by value is not dangerous but affects

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk added a comment. In D61827#1499184 , @lebedev.ri wrote: > In D61827#1499183 , @hintonda wrote: > > > In D61827#1499160 , @lebedev.ri > > wrote: > > > > > This

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-loop-convert-basic.cpp:273 + for (S::const_iterator It = Ss.begin(), E = Ss.end(); It != E; ++It) { +printf("s has value %d\n", (*It).X); hintonda wrote: > I think

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk created this revision. torbjoernk added reviewers: dergachev.a, hintonda, alexfh. torbjoernk added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. modernize-loop-convert was not detecting implicit casts to const_iterator as

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

torbjoernk created this revision. torbjoernk added reviewers: alexfh, bkramer. torbjoernk added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. run-clang-tidy.py was enforcing '-header-filter' parameter with an unfortunate default