[clang] [clang][NFC] Reformat suspicious condition (PR #89923)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89923 >From cde48906d4b9a08dc436ab94f183c124ee336e5a Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Wed, 24 Apr 2024 09:23:29 -0400 Subject: [PATCH 1/3] [clang][Lex] Reformat suspicious condition Signed-off-by:

[clang] [clang][NFC] Reformat suspicious condition (PR #89923)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89923 >From cde48906d4b9a08dc436ab94f183c124ee336e5a Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Wed, 24 Apr 2024 09:23:29 -0400 Subject: [PATCH 1/2] [clang][Lex] Reformat suspicious condition Signed-off-by:

[clang] [clang][NFC] Reformat suspicious condition (PR #89923)

Troy-Butler wrote: I see that the build has failed - what do I need to do to fix this? https://github.com/llvm/llvm-project/pull/89923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

Troy-Butler wrote: > @Troy-Butler I started to do the merge, but I cancelled it for now because it > seems that github mangles the email metadata: >

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler edited https://github.com/llvm/llvm-project/pull/89512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

Troy-Butler wrote: > > The pre-commit version of the function declaration listed the parameters in > > the order A, C, B, D to indicate the expected grouping of arguments, i.e. > > (A & C) | (B & D). Changing the order to A, B, C, D would have required > > reworking the function, which seemed

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/8] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/7] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [clang][NFC] Reformat suspicious condition (PR #89923)

Troy-Butler wrote: > Thanks for your contribution. Will you need me to merge that for you? Yes please! I don't have merging rights. Thank you! https://github.com/llvm/llvm-project/pull/89923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Lex] Reformat suspicious condition (PR #89923)

https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89923 Addresses issue #89805. Assignment + comparison performed in conditional statement. Resolved by parenthesizing comparison operation. >From cde48906d4b9a08dc436ab94f183c124ee336e5a Mon Sep 17 00:00:00 2001

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS, Instruction *CxtI, bool IsAnd, bool IsLogical = false); -

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/6] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/5] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/4] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

Troy-Butler wrote: I do not have the ability to merge, so if everything looks good with my pull request, can the last reviewer please merge this? Thank you! https://github.com/llvm/llvm-project/pull/89512 ___ cfe-commits mailing list

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler edited https://github.com/llvm/llvm-project/pull/89512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/3] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89512 >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH 1/2] Fix Definition-Declaration Mismatches Signed-off-by:

[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)

https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89512 Addresses issue #88716. >From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Sat, 20 Apr 2024 15:13:09 -0400 Subject: [PATCH] Fix Definition-Declaration Mismatches

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

https://github.com/Troy-Butler edited https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

Troy-Butler wrote: I'm not sure of how it happened, but despite fetching the latest version of files, my clone/fork didn't fully update before I made this pull request, and it's causing issues that I'm not experienced enough to resolve. To be safe, I'm going to close this pull request, erase

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

Troy-Butler wrote: I apologize - I'm not sure how this happened. I was careful to refresh my fork/clone before starting on this issue, but somehow not all of the files were updated, and now my PR requests are getting wires crossed. I think it would be safest for me to close this issue, delete

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89480 Addresses issue #85984 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

Troy-Butler wrote: > > Isn't the warning about a mismatch between declaration and definition, not > > call args? The InstCombine change does make the definition and declaration > > match. > > […](#) > > On Fri, Apr 19, 2024, at 17:07, Mehdi Amini wrote: _**@**_. commented > > on this pull

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

https://github.com/Troy-Butler reopened https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

Troy-Butler wrote: > > Isn't the warning about a mismatch between declaration and definition, not > > call args? The InstCombine change does make the definition and declaration > > match. > > […](#) > > On Fri, Apr 19, 2024, at 17:07, Mehdi Amini wrote: _**@**_. commented > > on this pull

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89294 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant Condition Signed-off-by:

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

https://github.com/Troy-Butler updated https://github.com/llvm/llvm-project/pull/89294 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant Condition Signed-off-by:

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89294 Addresses issue #88716 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/3] [LLVM][LIB] Refactor Redundant