[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a comment. > We'd need a lot more testing before we can claim to support reusing pipelines. Sure, but moving pass pipeline state into the context makes it much harder to do this kind of testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a subscriber: loladiro. vchuravy added a comment. In D137149#4653308 , @aeubanks wrote: > we don't currently support reusing a pipeline so I'm surprised that you're > able to share/reuse pipelines without running into any issues In

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a comment. Herald added a subscriber: wangpc. Late to the party here, but passing an `LLVMContext` seems really strange from a JIT perspective. We construct a pipeline that may be run over many modules each of them maybe using a different LLVM Context. Repository: rG LLVM

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

vchuravy added a comment. > Well, I've tested it and it doesn't seem to break anything for us (Gentoo) > but I don't really understand why you'd have a different install dir for LLVM > and Clang. We (Julia) ship LLVM as a dependency and put all the LLVM binaries into a separate `tools` folder

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy abandoned this revision. vchuravy added a comment. In D66035#2175839 , @pmatos wrote: > I am interested in continuing this work and have a patch in progress based > on the current available one here. Should I post the new patch here or under >

[PATCH] D73156: [clang] Build clang-shlib on mingw

vchuravy added a comment. Some additional context. We [Julia] is cross-compiling LLVM from Linux to mingw32 as part of an automatic buildsystem for our binary dependencies. The corresponding PR is https://github.com/JuliaPackaging/Yggdrasil/pull/417 Repository: rG LLVM Github Monorepo

[PATCH] D73156: [clang] Build clang-shlib on mingw

vchuravy created this revision. Herald added subscribers: cfe-commits, mstorsjo, mgorny. Herald added a project: clang. vchuravy added a reviewer: tstellar. vchuravy added a comment. Some additional context. We [Julia] is cross-compiling LLVM from Linux to mingw32 as part of an automatic

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231601. vchuravy added a comment. - fix AS in anyref testfile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.h

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy marked an inline comment as done. vchuravy added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:113 +TT.isArch64Bit() ? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" + :

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231462. vchuravy added a comment. restore previous changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.h

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231460. vchuravy added a comment. support old DL modules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files:

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231343. vchuravy marked 6 inline comments as done. vchuravy added a comment. - add test for passing anyref through a function - fix wrong name for funcref - fixes and formatting - fix error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy marked 4 inline comments as done. vchuravy added a comment. Rebased onto current master and added an initial test. (I will start adding more as I start integrating this with the rest of the toolchain) Comment at: llvm/lib/Object/WasmObjectFile.cpp:998 +if

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 222900. vchuravy added a comment. - change anyref AS to 256 - fix some comments and address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files:

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy added a comment. Keno has asked me to take this over for him and I will work on getting this into shape so that it can get landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035