[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/multiline.cpp:12-17 +void f(int x) \ +{ \ + printf("x=\ + %d", x); \ +} +f(i); aaron.ballman wrote: > Another fun test case: > ``` >

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Generally lgtm, let's extend the test coverage. Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// Likewise. Comment at:

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:144-146 ClangArgv.insert(ClangArgv.end(), "-Xclang"); ClangArgv.insert(ClangArgv.end(), "-fincremental-extensions"); ClangArgv.insert(ClangArgv.end(), "-c"); Hahnfeld

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev created this revision. v.g.vassilev added reviewers: junaire, sunho, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. This patch allows the users to use

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Thanks! That was blocking our jupyter integration so I decided to go ahead here since we already missed the clang17 train... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c4620c1dadc: [clang-repl] Consider the scope spec in template lookups for deduction guides. (authored by v.g.vassilev).

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Let's rely on a post-commit review here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520368. v.g.vassilev added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520322. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. @rsmith, any ideas how to support value printing of constructs such as `int i = 12`, eg, that's not a top-level statement declaration but worth printing its value? It is the shorthand of `int i = 12; i`. Comment at:

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/Decl.h:4345 + } + bool isValuePrinting() const { return IsSemiMissing; } + void setValuePrinting(bool Missing = true) { IsSemiMissing = Missing; } We should change the accessors to the

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

This revision was automatically updated to reflect the committed changes. Closed by commit rG743ff9c8bad3: [clang-repl] Do not assert if we have weak references left. (authored by v.g.vassilev). Herald added a project: clang. Changed prior to commit:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; sgraenitz wrote: > v.g.vassilev

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev updated this revision to Diff 520286. v.g.vassilev added a comment. Provide a better test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148435/new/ https://reviews.llvm.org/D148435 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; aaron.ballman wrote: > junaire

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde))

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9abe846617: [clang-repl] Correctly disambiguate dtor declarations from statements. (authored by v.g.vassilev). Herald

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev added a comment. Let's rely on a post-commit review here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148425/new/ https://reviews.llvm.org/D148425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

v.g.vassilev added a comment. This looks reasonable to me. Is there a way we could check when `+relax` start working to remember to re-add this feature? Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:46 auto JTMB = JITTargetMachineBuilder(TI.getTriple()); -

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. Thanks again for your efforts pushing this patch. It has gone a long way and I believe we are getting there. Comment at: clang/include/clang/Interpreter/Value.h:46 + +#define REPL_BUILTIN_TYPES

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D127284#4303390 , @tahonermann wrote: > This change appears to have negatively impacted some users that were > dependent on the previous

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Generally, looks good to me. I'd like to wait for @Hahnfeld and @tra's feedback at least for another week before merging. @dblaikie, I know that generally we do not want to run tests on the bots and that makes testing quite hard for this patch. Do you have a

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4891e681c5: [clang-repl] Enable debugging of JIT-ed code. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

v.g.vassilev created this revision. v.g.vassilev added reviewers: lhames, sgraenitz, junaire. Herald added a subscriber: pengfei. Herald added a project: All. v.g.vassilev requested review of this revision. This change follows llvm/llvm-project@21b5ebd and makes use of the jitlink

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. I added some of background and historical notes. I hope that helps. Comment at: clang/include/clang/Interpreter/Interpreter.h:59 + + Value LastValue; aaron.ballman wrote: > I think I'm surprised to see this as a data member of

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:7226 + // assert(DeferredDeclsToEmit.empty() && + //"Should have emitted all decls deferred to emit."); assert(NewBuilder->DeferredDecls.empty() && aaron.ballman

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rjmccall, rsmith, junaire. Herald added a project: All. v.g.vassilev requested review of this revision. Non-incremental Clang can also exit with the WeakRefReferences not empty upon such example. This patch makes

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Repository: rC Clang https://reviews.llvm.org/D148425 Files: clang/lib/Parse/ParseTentative.cpp

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a reviewer: dblaikie. v.g.vassilev added a subscriber: dblaikie. v.g.vassilev added a comment. I am adding @dblaikie as he might have ideas how to test this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

v.g.vassilev added a comment. Could we disable the test on that platform? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147823/new/ https://reviews.llvm.org/D147823 ___ cfe-commits mailing list

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added reviewers: aaron.ballman, rsmith, lhames, sgraenitz. v.g.vassilev added a comment. I think it is a good time to invite more reviewers to take a look at this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + junaire wrote: > v.g.vassilev wrote: > > junaire wrote: > > > v.g.vassilev wrote: > > > > This can

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + junaire wrote: > v.g.vassilev wrote: > > This can probably go in the RuntimeInterfaceBuilder class. > We

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:383 + +static std::string MangleName(ASTContext , GlobalDecl GD) { + std::unique_ptr MangleC(C.createMangleContext()); I suspect we could use

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/Decl.h:4345 + } + bool isValuePrinting() const { return MissingSemi; } + void setValuePrinting(bool Missing = true) { MissingSemi = Missing; } We should rename these to `isMissingSemi` or

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:39 +class Parser; +class CodeGenerator; class CompilerInstance; v.g.vassilev wrote: > We probably do not need these forward declarations. Looks like they came back.

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

v.g.vassilev added a comment. Could we use yaml2obj instead of uploading the binary? I see other tests using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147823/new/ https://reviews.llvm.org/D147823

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:296 } + LinkModules.clear(); return false; // success argentite wrote: > Hahnfeld wrote: > > This looks like a change that has implications beyond support for

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2211 + std::optional> ValuePrintingTransformer; + Instead of doing this, we could implement an ASTConsumer which the Interpreter can attach to Sema and listen for

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > v.g.vassilev wrote: > > tra wrote: > > > Is there any doc describing the big picture

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a subscriber: SimeonEhrig. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > Is there any doc describing the big

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Thanks for working on this! Comment at: clang/lib/Interpreter/Offload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// How about `DeviceOffload.cpp`? Comment at:

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288 + } + for (auto : LazySpecializations) { +Record.push_back(SpecInfo.DeclID); We should not store the lazy specialization information as an array of

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:554 +// Otherwise, eat the semicolon. +ExpectAndConsumeSemi(diag::err_expected_semi_after_expr); + } We seem to have more than one call to

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith. Herald added a project: All. v.g.vassilev requested review of this revision. `isDeductionGuideName` looks up the underlying template and if the template name is qualified we miss that qualification resulting

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 509998. v.g.vassilev added a comment. Herald added a subscriber: mgrang. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 Files: clang/include/clang/AST/DeclTemplate.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:20 +#include "clang/Interpreter/PartialTranslationUnit.h" +#include "clang/Interpreter/Value.h" We can forward declare `Value`. Comment at:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. Overall it looks like we are heading in a good direction. Here are some initial comments from my partial review. Comment at: clang/include/clang/Interpreter/Interpreter.h:109 + std::list (); + std::unique_ptr GenModule(); + Do

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ cfe-commits mailing list

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

v.g.vassilev added a comment. Thanks for working on this, looks like we are heading in a good direction! Comment at: clang/test/Interpreter/dynamic-library.cpp:1 +// RUN: head -n 7 %s | %clang -xc++ -o %T/libdynamic-library-test.so -fPIC -shared - +int ultimate_answer = 0;

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev planned changes to this revision. v.g.vassilev added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}}

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4150286 , @aaron.ballman wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> Indeed the warning is noisy but it will potentially fix broken code which >> were

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148271 , @philnik wrote: > It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. > It warns that the deduction guide is unused, but the deduction guide is > required suppress

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D143524#4148039 , @philnik wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> In D143524#4148006

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}}

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148006 , @philnik wrote: > The emitted warnings from the libc++ CI look like a false-positive to me. > While the functions are never called, they are used in an unevaluated > context. I would expect `-Wunused`

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG159073bc0a87: [clang-repl] Support compound statement as a top-level statement. (authored by v.g.vassilev). Herald added

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev added a comment. This seems like a good candidate for a post commit review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139798/new/ https://reviews.llvm.org/D139798 ___ cfe-commits mailing list

[PATCH] D143148: [clang-repl] Add basic multiline input support

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:260 + std::error_code()); +Token Tok; +do { I think we can simplify the heuristics here by asking if the end

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

v.g.vassilev added a comment. We should probably add some tests here. Alternatively we can add the tests from https://reviews.llvm.org/D143148 but that'd make this patch bulkier and probably harder to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139798/new/ https://reviews.llvm.org/D139798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

v.g.vassilev added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:211 + L->BufferOffset = + StrData - InputFile.getBufferStart(); // FIXME: this is wrong + L->BufferSize = L->BufferOffset + TokLen; Is that an outdated comment? If not maybe elaborate

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, ldionne. Herald added a project: All. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D29877 implements a useful -Wunused-template diagnostic detects unused internal linkage templates. This

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

v.g.vassilev added a comment. In D119708#4060336 , @jansvoboda11 wrote: > In D119708#4059254 , @Hahnfeld > wrote: > >> Hello, sorry for the late heads-up, but this functionality is used by ROOT: >>

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4058807 , @erichkeane wrote: > In D131858#4054348 , @v.g.vassilev > wrote: > >> In D131858#4052031 , @erichkeane >> wrote: >>

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4052031 , @erichkeane wrote: > In D131858#4052026 , @v.g.vassilev > wrote: > >> Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and >>

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!!

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4047785 , @erichkeane wrote: > @mizvekov : I'm looking at the revert of this since no work seems to have > been done to fix @steven_wu 's problem. Unfortunately, it seems that > reverting this requires

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/execute-stmts.cpp:34 + +for (; i > 4; --i) printf("i = %d\n", i); +// CHECK-NEXT: i = 5 UnionType wrote: > It seems that top-level statements

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith. Herald added a project: All. v.g.vassilev requested review of this revision. This patch teaches our incremental compilation infrastructure to push and pop a fake function scope making the Parser happy when

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > Latest test run: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48911/execution/node/74/log/ > I modified the expected string slightly to make it work: > https://reviews.llvm.org/rG811ad246ac7b > Should be all good now. Thanks for looking into this!

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969593 , @Michael137 wrote: > In D127284#3969458 , @v.g.vassilev > wrote: > >> In D127284#3969446 , @v.g.vassilev >> wrote:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969446 , @v.g.vassilev wrote: >> UPDATE: fails with clean build too >> >> Might be best to revert it for now while we figure out what's wrong > > I fail to reproduce it, can you give me access to some node where

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > UPDATE: fails with clean build too > > Might be best to revert it for now while we figure out what's wrong I fail to reproduce it, can you give me access to some node where I can debug? I suspect that should be something easy to fix. Repository: rG LLVM

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969398 , @Michael137 wrote: > In D127284#3969308 , @v.g.vassilev > wrote: > >> In D127284#3969249 , @v.g.vassilev >> wrote:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969249 , @v.g.vassilev wrote: > In D127284#3969225 , @Michael137 > wrote: > >> FYI, looks like this broke the LLDB incremental buildbot. Following tests >> started

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969225 , @Michael137 wrote: > FYI, looks like this broke the LLDB incremental buildbot. Following tests > started failing: > > >

[PATCH] D139258: Remove the enableIncrementalProcesing logic in favor of -fincremental-extensions

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith, shafik. Herald added a subscriber: kristof.beyls. Herald added a project: All. v.g.vassilev requested review of this revision. As we have discussed in https://reviews.llvm.org/D127284 we would like to phase

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4889357adb: [clang-repl] Support statements on global scope in incremental mode. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479390. v.g.vassilev added a comment. Herald added a subscriber: arphaman. Fixed the diff. I accidentally have added the commits from https://reviews.llvm.org/D139016 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. I screwed up with the last diff. Let me fix it in a bit... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +DiagnosticsEngine::Error, "Unsupported statement

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479310. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments, fix a fixme. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked 3 inline comments as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1032-1034 +// FIXME: Remove the incremental processing pre-condition and verify clang +// still can pass its test suite, which will harden +//

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev added a comment. I have modified it a little before landing it to capture better the intent and our off-list conversation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138698/new/ https://reviews.llvm.org/D138698

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae07a4372fc: [clang-repl] Add basic documentation about clang-repl (authored by sarabellei, committed by v.g.vassilev). Herald added a project:

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Sorry, selected the wrong option. This looks good to me. I can commit that change for you as I know you do not have commit access. CHANGES SINCE LAST ACTION

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. This revision now requires changes to proceed. This looks good to me. I can commit that change for you as I know you do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138698/new/

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478316. v.g.vassilev added a comment. rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. I think I have addressed all comments from @aaron.ballman and @rsmith. Comment at: clang/include/clang/Lex/Preprocessor.h:1782-1785 void enableIncrementalProcessing(bool value = true) { -IncrementalProcessing = value; +// FIXME: Drop

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478312. v.g.vassilev marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477312. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Teach CodeGen to squash contiguous top-level stmt decl blocks into a single `llvm::Function`. Rebase. CHANGES SINCE LAST ACTION

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477168. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments, support better C in clang-repl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 475470. v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. Rebase + fix the failure on windows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Usually @rsmith has something up in the sleeve in these situations ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

v.g.vassilev added a comment. In D137787#3924727 , @Hahnfeld wrote: > Yes, I fully agree that having a test is desirable, I just didn't manage so > far. Maybe it takes somebody with deep AST knowledge to explain under what > circumstances

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1033 +!isDeclarationStatement(/*DisambiguatingWithExpression=*/true)) + SingleDecl = ParseTopLevelStmtDecl(); + There is a remaining challenge which probably could be

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473496. v.g.vassilev added a comment. Remove several fixmes. Now we can deal with templates, deduction guides and operators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

<    1   2   3   4   5   6   7   >